#helmfile (2024-05)

The pull request in question is https://github.com/helmfile/helmfile/pull/1494

You’ve asked me to write some tests. As stated in my early comment on the pull request, I am not a golang programmer. I’ve spend half of the day today (Sat) trying to learn enough go to be able to perform your request, but I still don’t have enough knowledge to know how to proceed.

Do I just add something like this to the TestTemplate function in pkg/app/app_template_test.go

OR am I supposed to do something in test/e2e/template/helmfile/tmpl_test.go instead? (or as well?)

OR am I supposed to do something under test/integration/test-cases/ ?

Also a question on my change itself. Did I need to add the showOnly stuff to the HelmSpec and ReleaseSpec structs in pkg/state/state.go? The HelmSpec struct is for the helmDefault values right? And the --show-only option for helmfile template wouldn’t be something you’d likely want to set in the helmDefault section I suspect. And the ReleaseSpec struct if for the release: section of helmfile.yaml right? So probably also an area where you wouldn’t set the new parameter. I suspect I should remove it from those places?

I also don’t know if the changes I did in pkg/app/app_test.go were necessary or not?

And if I don’t need those vars in the structs, then I guess my change to pkg/state/helmx.go simply becomes the following instead?

I will help you. Waiting for my commit. Study with each other. Thanks so much.

Thanks.