SweetOps #atmos-dev for January, 2025

• New Features
• Enhanced custom command argument handling with required and default value support.
• Added new “greet” command with a configurable name argument. • Documentation
• Updated documentation for custom commands, including command name change from “hello” to “greet”.
• Clarified positional argument requirements and default value handling. • Bug Fixes
• Improved argument validation logic for custom commands.
• Added more robust error messaging for invalid command configurations. • Tests
• Introduced new test cases for the “greet” command to validate argument handling and default values.

Vinny

08:17:10 PM

@Andriy Knysh (Cloud Posse) looks like good now https://github.com/cloudposse/atmos/pull/853

Andriy Knysh (Cloud Posse)

08:38:45 PM

@Vinny this config in atmos.yaml

# Syntax highlighting configuration
  syntax:
    enabled: true
    theme: "dracula"      # or use custom colors from theme
    line_numbers: true
    wrap: false

Andriy Knysh (Cloud Posse)

08:39:23 PM

looks like it’s a separate sub-section under settings

Andriy Knysh (Cloud Posse)

08:39:31 PM

but it’s not in schema.go

Andriy Knysh (Cloud Posse)

08:40:27 PM

it’s eigher needs to be removed from atmos.yaml and the docs, or used in schema.go and in the code

Erik Osterman (Cloud Posse)

08:41:58 PM

this should be settings.terminal.syntax

Erik Osterman (Cloud Posse)

09:02:53 PM

(Which it currently is)

Vinny

09:31:15 PM

I think we are good to remove this syntax

Vinny

09:31:25 PM

colorize should handle yaml

Andriy Knysh (Cloud Posse)

09:44:44 PM

@Vinny please ping me here when you finish all the changes

Erik Osterman (Cloud Posse)

09:50:14 PM

Why remove? What does removing it solve

Vinny

09:51:04 PM

because syntax themes is implemented here https://github.com/cloudposse/atmos/pull/907/files#diff-c0d6f95f5584bc195d902401b649de3778ba9f88b3758b5f22a9bec32afa7cd8R319

Vinny

09:51:24 PM

we don’t need it there at all as we have custom colors

Erik Osterman (Cloud Posse)

09:52:36 PM

But themes is nice too :-)

Vinny

09:52:56 PM

yeah indeed its your guys decision at the end

Erik Osterman (Cloud Posse)

09:53:07 PM

But I don’t understand why we have both “syntax” and “syntax_highlighting”

Vinny

09:54:07 PM

will be only this syntax_highlighting we can rename it

Erik Osterman (Cloud Posse)

09:54:54 PM

Erik Osterman (Cloud Posse)

09:55:05 PM

Let’s combine

Erik Osterman (Cloud Posse)

09:55:14 PM

But yes, I prefer we keep support for themes

Erik Osterman (Cloud Posse)

09:55:29 PM

But document where the list of themes is found

Vinny

09:58:12 PM

so to summarize right now we have

• Glamour with markdown with custom colors

• Themes for yaml colorized

• (chroma themes for Glamour also) This is not implemented now

Vinny

09:59:13 PM

I can do this chroma in the same glamour PR or we can create another feature to implement it, up to you @Erik Osterman (Cloud Posse)

Erik Osterman (Cloud Posse)

10:00:24 PM

Let’s do that in a new PR

Erik Osterman (Cloud Posse)

10:00:39 PM

But yes, let’s do that. Can you write a linear task and self assign

Vinny

10:00:53 PM

sounds good

Vinny

10:02:19 PM

https://linear.app/cloudposse/issue/DEV-2904/theme-chrome-style-for-glamour-implementation

Vinny

10:32:35 PM

@Andriy Knysh (Cloud Posse) good to check now please

Erik Osterman (Cloud Posse)

08:40:39 PM

@Andriy Knysh (Cloud Posse) I think this is also ready https://github.com/cloudposse/atmos/pull/906

#906 Support for a circuit breaker to avoid recursive calls to atmos commands (infinite loop)

what

This PR contains the code that counts the number of recursive calls, and in case it exceeds the threshold, terminates the processes (parent + all children).

Add-on to atmos.yaml

atmos_yaml_addon

The circuit breaker in use

atmos_loop_termination

why

Avoid infinite loops

references

• Closes #765 • DEV-2688

Summary by CodeRabbit

• New Features
• Added a circuit breaker mechanism to prevent infinite shell command loops.
• Implemented maximum shell depth limit of 10 levels.
• Introduced a new command loop for testing infinite loops in the CLI.
• Enhanced environment variable tracking for nested shell executions. • Tests
• Added a new test case to verify circuit breaker functionality.
• Ensured CLI handles infinite loop scenarios gracefully.

Vinny

10:37:06 PM

This is good to start review @Andriy Knysh (Cloud Posse) https://github.com/cloudposse/atmos/pull/907

#atmos-dev (2025-01)

Discuss atmos core development (golang). If you want to help out, reach out to <@UB2EH889X>

2025-01-01

2025-01-02

2025-01-03