#codefresh (2018-12)

codefresh

Archive: https://archive.sweetops.com/codefresh/

2018-12-21

michal.matyjek avatar
michal.matyjek

@dustinvb one thing that would be great to have is being able to pause execution - for pipeline debugging purposes - add a parameter that takes step name and execution stops at this step, so that you can connect to the container and investigate things in the given state

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

yea, like a break point?

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

ohhhh yea, that is the BEST thing with circle

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

love being able to exec into a container

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

(dustin is on vacay)

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@michal.matyjek they said you can open feature requests here: https://github.com/codefresh-io/cli/issues

codefresh-io/cli

Codefresh CLI. Contribute to codefresh-io/cli development by creating an account on GitHub.

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

1 for adding that

michal.matyjek avatar
michal.matyjek
Ability to pause --local execution · Issue #254 · codefresh-io/cli

Really a must-have for debugging is ability to add breakpoint/pause pipeline execution at given point. For example: add a parameter that takes step name and execution stops at this step, so that yo…

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)
Ability to "Exec" into a pipeline container · Issue #255 · codefresh-io/cli

what We want to exec into a pipeline container why for triaging/debugging, this would speed things up considerably feature supported by CircleCI related #254

2018-12-20

dustinvb avatar
dustinvb

New option --yaml to run Codefresh pipeline using the YAML file from your local machine.

https://codefresh-io.github.io/cli/pipelines/run-pipeline/

1
dustinvb avatar
dustinvb

New option --local to run Codefresh pipeline using local Docker daemon now available see link above for option on pipeline run from CLI.

1
Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

wow, kick ass! moving fast……

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@Igor Rodionov what do you think about the local option?

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@dustinvb does it support shared configurations?

Igor Rodionov avatar
Igor Rodionov

Hello

dustinvb avatar
dustinvb

I haven’t had a chance to work with it yet and check out the shared configurations or other options. I believe right now the only thing not supported is localized volume caching.

dustinvb avatar
dustinvb

That is due out next week I believe.

Igor Rodionov avatar
Igor Rodionov

how it works with shared configurations?

Igor Rodionov avatar
Igor Rodionov

and let’s say - k8s integration

dustinvb avatar
dustinvb

Ah like getting the context?

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

--local = local development

Igor Rodionov avatar
Igor Rodionov

yea

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

oh, access to k8s integrations

dustinvb avatar
dustinvb

I’ll try it real fast, I’ve been a bit limited on time.

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

(not urgent on our end)

dustinvb avatar
dustinvb

You have sparked my interest Sir!

dustinvb avatar
dustinvb

It all appears to work fine

dustinvb avatar
dustinvb

I’ll post my command and output here.

dustinvb avatar
dustinvb
05:34:33 PM
dustinvb avatar
dustinvb

So appears to work flawless with Kube Context etc.

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

that’s freggin AWESOME

dustinvb avatar
dustinvb
dustinvanbuskirk/example-voting-app

Docker’s Example Voting App. Contribute to dustinvanbuskirk/example-voting-app development by creating an account on GitHub.

Igor Rodionov avatar
Igor Rodionov

I’m very excited to test this

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

yea, this is super dope

1
Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@fdrescher talk to @Valdemir if you want a demo

fdrescher avatar
fdrescher
09:16:08 PM

@fdrescher has joined the channel

Valdemir avatar
Valdemir

@fdrescher I d be more than happy to help. When would be most convenient for us to meet?

2018-12-19

michal.matyjek avatar
michal.matyjek

part of me says “that’s awesome” but part is like “nooooo….”

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

haha, how come?

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

i love the idea that setting up a new repo is all in code

michal.matyjek avatar
michal.matyjek

versioning I guess

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

in fact, i even like the idea of creating the repos that way too

michal.matyjek avatar
michal.matyjek

yeah

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

so that they are setup with branch protections

michal.matyjek avatar
michal.matyjek

that makes sense

michal.matyjek avatar
michal.matyjek

but to me feels like something that should be out-of-the-box from Codefresh, not separate

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

ya…. kind’a agree

michal.matyjek avatar
michal.matyjek

even basic stuff - like autocreating pipelines by the nature of having file named codefresh.yml in the root of the repo….

michal.matyjek avatar
michal.matyjek

which I guess the above is also doing

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

(or a codefresh/ directory of pipelines)

michal.matyjek avatar
michal.matyjek

that would be .codefresh/ - this is what we standardized on at Gladly, so everyone please use that

1
michal.matyjek avatar
michal.matyjek

on why “noooo….” - is we’re having discussions internally on how much to abstract from the dev team - and there are some good arguments to not to abstract (would apply to pipeline creation, but also monochart in helm etc.)

michal.matyjek avatar
michal.matyjek

there are also good arguments to abstract - for patterns, ability to easily inject stuff etc.

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

yea, i see what you mean.. getting farther away from understanding how it works

joshmyers avatar
joshmyers

A cli tool so you can run pipelines locally is awesome. Wercker (https://github.com/wercker/wercker) had a cli for local which was nice to use before they got bought

2018-12-18

michal.matyjek avatar
michal.matyjek

validate - finally….

michal.matyjek avatar
michal.matyjek

thanks!

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@michal.matyjek you should see the pipeline creation for Codefresh @Igor Rodionov wrote

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

Cicd creation of Codefresh repos wired up to pipelines

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

So you don’t need to login to Codefresh to even setup a new service

2018-12-17

dustinvb avatar
dustinvb
06:34:02 PM
Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@Igor Rodionov

Igor Rodionov avatar
Igor Rodionov
08:40:10 PM

@Igor Rodionov has joined the channel

Igor Rodionov avatar
Igor Rodionov

nice, but I can not now imaging where to use this

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

We should have this as a step in your pipeline as code stuff

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

This will validate the rendered templates of the Codefresh yaml are valid

dustinvb avatar
dustinvb

Team is working on a --local option for using local machine for runner for Codefresh builds as well. I’ll post that here as soon as available that will probably be more widely used.

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

oh that’s sweet

2018-12-14

dustinvb avatar
dustinvb

Cool. Check out my bot? It handled gitops demos during KubeCon.

https://github.com/dustinvanbuskirk/cf-demo-bot

dustinvanbuskirk/cf-demo-bot

Demo Bot. Contribute to dustinvanbuskirk/cf-demo-bot development by creating an account on GitHub.

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

this is great!

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

I want to use this pattern to open PRs against cloudposse/packages to update packages on a cron using scheduled pipelines in codefresh

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

so much I want to do…. ugh

dustinvb avatar
dustinvb

I hear you, I have a todo to add GitHub releases into the bot and want to move from one bot to two bots and make the commit items a bit more flexible maybe format them in some way.

2018-12-13

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)
cloudposse/slack-notifier

Command line utility to send messages with attachments to Slack channels via Incoming Webhooks - cloudposse/slack-notifier

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

we received a contribution which adds a SLACK_CHANNEL parameter so the same webhook can be reused

2018-12-08

richwine avatar
richwine
01:59:25 PM

@richwine has joined the channel

2018-12-07

dustinvb avatar
dustinvb
dustinvanbuskirk/example-voting-app

Docker’s Example Voting App. Contribute to dustinvanbuskirk/example-voting-app development by creating an account on GitHub.

dustinvb avatar
dustinvb

Simple step to add.

dustinvb avatar
dustinvb

This is noted in the new issue I filed on the repository.

2018-12-06

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@dustinvb do you have a link handy for your claire image scanning?

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)
codefresh-contrib/cfstep-paclair

Clair Scan Step. Contribute to codefresh-contrib/cfstep-paclair development by creating an account on GitHub.

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@dustinvb the README shows that’s it’s building one image, but testing an entirely different image

codefresh-contrib/cfstep-paclair

Clair Scan Step. Contribute to codefresh-contrib/cfstep-paclair development by creating an account on GitHub.

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)
01:37:31 AM
Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)
codefresh-io/plugins

Codefresh plugins repository. Contribute to codefresh-io/plugins development by creating an account on GitHub.

dustinvb avatar
dustinvb

Yes was just talking to Kostis about deprecating this and our older model of Twistlock.

I need to improve the README.md on Clair already to include the new Test reporting abilities instead of manual S3 upload. I’ll file an issue about the this and that now.

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@dustinvb is there some way to combine this with https://codefresh.io/codefresh-news/test-reporting/

Codefresh adds built-in reporting for test results and other custom CI/CD reports - Codefresh

One of the pillars of Continuous Integration is the active use of tests as part of the integration process. Each feature is considered “done” only when it passes all required tests on its own as well as part of a release. Codefresh has always supported the running of unit and integration tests as part of …

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

so we can bypass S3 dependency

2018-12-05

Nikola Velkovski avatar
Nikola Velkovski

Ok so I did a lot of small changes to the codefresh.yml and what I’ve noticed is some of them where the right ones but the step that fails is when pulling from codefreshes internal docker repo.

[SYSTEM] Error: Failed to calculate image name to push; caused by Error: Failed to pull image [r.cfcr.io/nikolavelkovski/nikola-dev-e[email protected]:73f53ca80ea67f96259](http://r\.cfcr\.io/nikolavelkovski/nikola\-dev\[email protected]:73f53ca80ea67f96259)
dd4e8ed66e99cde9a8da75c6c49ed1e4c1459985c9a4f; caused by Error: Failed to get registry credentials; caused by Error: Registry: '#userPassedEcr' could not be foun
Nikola Velkovski avatar
Nikola Velkovski

re-running this step works fine

Nikola Velkovski avatar
Nikola Velkovski

sometimes I need to re-run it 2 times.

Nikola Velkovski avatar
Nikola Velkovski
10:27:33 AM

Here’s a screenshot. I had to re-execute the push to ecr step 2 times in order to get it to pass without me doing any change.

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

@Nikola Velkovski can you share your pipeline? (remove all secrets )

Nikola Velkovski avatar
Nikola Velkovski

there aren’t any just a sec, so I’ve Alex on support who is investigating

Nikola Velkovski avatar
Nikola Velkovski
stage: push
title: Push image to ecr
type: push
description: Pushing to ecr
candidate: '${{build_image}}'
tag: 'codefresh-${{CF_REVISION}}'
image_name: nikola-dev-ecs
provider: ecr
accessKeyId: '${{AWS_ACCESS_KEY_ID}}'
secretAccessKey: '${{AWS_SECRET_ACCESS_KEY}}'
region: '${{AWS_ECR_REGION}}'
Nikola Velkovski avatar
Nikola Velkovski

This is the stage that it’s failing with the cryptic error

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

Are you tagging the image and then push the branch and the tags for example? Maybe it fails to push some tags?

Nikola Velkovski avatar
Nikola Velkovski

from the error message it fails to pull the branch from the internal repo

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

can you show the pull step?

Nikola Velkovski avatar
Nikola Velkovski

sure wait

Nikola Velkovski avatar
Nikola Velkovski

hmm I’ve a build and a push step

Nikola Velkovski avatar
Nikola Velkovski

the pull is automatic

Nikola Velkovski avatar
Nikola Velkovski

upon commit

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

from GitHub?

Nikola Velkovski avatar
Nikola Velkovski

yes

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

ok sec

Nikola Velkovski avatar
Nikola Velkovski
03:37:01 PM
Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)
cloudposse/statup

Contribute to cloudposse/statup development by creating an account on GitHub.

Nikola Velkovski avatar
Nikola Velkovski

ok I will

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

@michal.matyjek, @Daren

we improved https://github.com/cloudposse/github-commenter, let me test all the changes and update README with new examples, and we’ll release (today). Added delete-comment-regex arg, so if provided, the module will try to find and delete all previous comments by the regex before creating a new one.

@Daren re:

Interesting, I looked a helm chart PR to see if I could spot how k8s does their automated comments. They are not posted as review comments, they show up as Issue comments. I dont know the difference

We went through all of that, and found many new details which we did not know before :slightly_smiling_face: (and it’s little bit convoluted).

Summary FYI:

GitHub API allows these types of comments:

  1. Comments on repos/commits https://developer.github.com/v3/repos/comments
  2. Coments on PR reviews https://developer.github.com/v3/pulls/reviews/#create-a-pull-request-review
  3. Comments on PR file (at specified position) https://developer.github.com/v3/pulls/comments
  4. Comments on issues https://developer.github.com/v3/issues/comments
  5. Comments on PRs (in the global section, not on individual files) https://developer.github.com/v3/issues/comments

Since GitHub considers PRs as issues, #4 and #5 are basically the same (use the same API).

The new module release will support all five (Comment type: commit, pr, issue, pr-review or pr-file).

And all five will support the delete-comment-regex arg to delete the previous comments (if provided).

michal.matyjek avatar
michal.matyjek

Thanks!

@Daren the extreme way is to attach helm diff to helmfile, twistlock result to Dockerfile changes etc. not that we would do it

Daren avatar
Daren

Thanks @Andriy Knysh (Cloud Posse), I will try it out this week

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

some screenshots FYI to see how all five look in the UI:

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

comment on commit:

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)
04:00:57 PM
Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

comment on PR review (Comment #3):

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)
04:02:20 PM
Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

Comments on PR file (at specified position) (Comment #5):

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)
04:03:09 PM
Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

comment on issue (Comment #2):

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)
04:03:40 PM
Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

comment on PR (in the global section) (Comment #4):

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)
04:04:28 PM
Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

(all of those comments were created by the new module)

Nikola Velkovski avatar
Nikola Velkovski

@Andriy Knysh (Cloud Posse) it was solved, it turned out that if I remove the part where I explicitly state the push type and credentials and just use registry: nikola-dev-ecs it works

Nikola Velkovski avatar
Nikola Velkovski

¯_(ツ)_/¯

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

nice

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

so yea, all those credentials should be settings in the ecr registry, not in pipeline steps

Nikola Velkovski avatar
Nikola Velkovski

well if one has let’s say 50 ecr registries then it gets interesting

Nikola Velkovski avatar
Nikola Velkovski

ok and another solution which I prefer was to quote the provider param

Nikola Velkovski avatar
Nikola Velkovski

provider: ecr == provider: ‘ecr’

Nikola Velkovski avatar
Nikola Velkovski

@Andriy Knysh (Cloud Posse) thanks for the help!

:--1:1
mallen avatar
mallen
09:21:50 PM

@mallen has joined the channel

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

@Daren @michal.matyjek we just released https://github.com/cloudposse/github-commenter that supports delete-comment-regex argument

cloudposse/github-commenter

Command line utility for creating GitHub comments on Commits, Pull Request Reviews or Issues - cloudposse/github-commenter

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)
cloudposse/github-commenter

Command line utility for creating GitHub comments on Commits, Pull Request Reviews or Issues - cloudposse/github-commenter

Daren avatar
Daren

Thanks!

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

(and all those args support ENV equivalents)

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)
cloudposse/github-commenter

Command line utility for creating GitHub comments on Commits, Pull Request Reviews or Issues - cloudposse/github-commenter

2018-12-04

michal.matyjek avatar
michal.matyjek
06:00:34 PM

@michal.matyjek has joined the channel

1
michal.matyjek avatar
michal.matyjek

Anyone is posting back from Codefresh to github? Looking for a complete solution to post back to github PR (not to commit) with previous comment deletion/removal. Ideally with some templating built-in

Use case: post helm diff, or twistlock scan results to PR - in a way there’s only one comment for latest commit there.

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

sounds like you want to emulate atlantis?

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

also, you’ve seen that there’s now the ability to trigger a pipelines based on comments

michal.matyjek avatar
michal.matyjek

yeah - we do it on one repo, but also need actually more - like twistlock, config changes etc. etc.

Daren avatar
Daren

CF supports triggers based on comments?

Daren avatar
Daren

Id like to be able to see actions like /helm diff

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@michal.matyjek yes, we have our github-commenter for that

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)
cloudposse/github-commenter

Command line utility for creating GitHub comments on Commits, Pull Request Reviews or Issues - cloudposse/github-commenter

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

it supports templated comments

michal.matyjek avatar
michal.matyjek

does it overwrite?

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

no - that would be a “feature request”

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

if someone on the gladly team wants to contribute that, we’ll promptly review and get it merged

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

seems like it would be a nice feature, to be able to target a previous comment using some kind of regex

michal.matyjek avatar
michal.matyjek
Find Pull Request Containing Specific Commit Hash

This would be extremely useful! Also, a similar request was posted for getting a list of PRs between two commits.

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

--upsert-comment="/some regex/"

michal.matyjek avatar
michal.matyjek

@Daren ^^

Daren avatar
Daren
06:38:39 PM

@Daren has joined the channel

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)


getting the PR number from commit sha.

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

why?

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

We use the CF_PR_NUMBER or something

michal.matyjek avatar
michal.matyjek

oh is that in place?

michal.matyjek avatar
michal.matyjek

i had no idea

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

yea, sec

michal.matyjek avatar
michal.matyjek

I think it did not always work for us or something - have not checked in months though

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

CF_PULL_REQUEST_NUMBER

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

we use it like this NAMESPACE=pr-${{CF_PULL_REQUEST_NUMBER}}-${{CF_REPO_NAME}}

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

If you trigger a build manually, then you don’t get it

michal.matyjek avatar
michal.matyjek

oh yeah - I think it’s only if your trigger is on PR?

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

it’s only available on synchronize

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

or if you pass it manually

michal.matyjek avatar
michal.matyjek

if you trigger on commit - you also dont I think

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

but that’s maybe a tell-tale sign you don’t want to execute

michal.matyjek avatar
michal.matyjek

comment on PR - so that you can upsert previous commits

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

since it’s happening outside of a PR

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

you don’t want to do anything.

michal.matyjek avatar
michal.matyjek

well if you push new commits to PR you do want it….

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

that’s synchronize

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

that’s supported by codefresh

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)
06:41:19 PM
michal.matyjek avatar
michal.matyjek

hmmm… ok thanks!

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@Andriy Knysh (Cloud Posse) can you scope out this feature? see it it would be pretty easy to implement?

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

sure

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

override prev comment is what you are after, @michal.matyjek?

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

yea, but not just any previous comment

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

the previous related comment

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

so maybe use a regex input?

michal.matyjek avatar
michal.matyjek

yeah

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

and it would be like an “upsert”

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

update or if not found insert

michal.matyjek avatar
michal.matyjek

can be some magic string, since we can have multiple steps commenting to github from Codefresh - each comment can have separate magic string

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

ok let me see what could be done

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

the other option @Daren mentioned was

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)


I like how k8s repos replace the comment
they actually delete, then recomment

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@michal.matyjek do you have a preference?

michal.matyjek avatar
michal.matyjek

I do not, it’s OK to delete/recreate. Noone reads email here anyways except me and I am fine handling additonal github email notifications

Daren avatar
Daren

I like the delete/repost. Then the comment is inline with the action that triggered it

Daren avatar
Daren

Updating an existing comment can be confusing on PR with a lot of activity

:--1:1
Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

Yea, good point

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@Andriy Knysh (Cloud Posse)

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

:–1:

Daren avatar
Daren

Since you can post html as the body, you might be able to use metadata tags as a means of labeling the comment for deletion

Daren avatar
Daren

Interesting, I looked a helm chart PR to see if I could spot how k8s does their automated comments. They are not posted as review comments, they show up as Issue comments

Daren avatar
Daren

I dont know the difference

Daren avatar
Daren

@Erik Osterman (Cloud Posse) how do you handle posting helm diffs to PRs when it contains secrets

Daren avatar
Daren

oh found it

Daren avatar
Daren

--suppress-secrets

Daren avatar
Daren

@Andriy Knysh (Cloud Posse) do you have some repos where codefresh is performing helm commands?

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)
cloudposse/statup

Contribute to cloudposse/statup development by creating an account on GitHub.

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)
cloudposse/statup

Contribute to cloudposse/statup development by creating an account on GitHub.

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)
cloudposse/statup

Contribute to cloudposse/statup development by creating an account on GitHub.

Daren avatar
Daren

nice

Nikola Velkovski avatar
Nikola Velkovski

Morning, can someone assist me in setting up the pipeline in codefresh to push to ECR? I cannot seem to get it the push working. I am getting the following error. aused by Error: Failed to get registry credentials; caused by Error: Registry: '#userPassedEcr' could not be found

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

(i’m headed to bed, but ping me in the morning if you don’t get it resolved)

Nikola Velkovski avatar
Nikola Velkovski

good night!

    keyboard_arrow_up