#github-actions (2022-12)

Discussions related to GitHub Actions

2022-12-01

actions Archives | The GitHub Blog avatar
actions Archives | The GitHub Blog
03:55:42 PM

GitHub Actions: Larger Runners using Ubuntu-latest label will now use Ubuntu-22.04 GitHub Actions: Larger Runners using Ubuntu-latest label will now use Ubuntu-22.04

GitHub Actions: Larger Runners using Ubuntu-latest label will now use Ubuntu-22.04 | GitHub Changelogattachment image

GitHub Actions: Larger Runners using Ubuntu-latest label will now use Ubuntu-22.04

2022-12-06

actions Archives | The GitHub Blog avatar
actions Archives | The GitHub Blog
01:05:36 PM

GitHub Actions workflow notifications in Slack and Microsoft Teams GitHub Actions workflow notifications in Slack and Microsoft Teams

actions Archives | The GitHub Blog avatar
actions Archives | The GitHub Blog
11:25:33 PM

Extending Checks Retention Policies to GHES Extending Checks Retention Policies to GHES

Extending Checks Retention Policies to GHES | GitHub Changelogattachment image

Extending Checks Retention Policies to GHES

Steve Wade (swade1987) avatar
Steve Wade (swade1987)

Hey all does anyone know how to automate adding the project to a GitHub issue on creation?

Steve Wade (swade1987) avatar
Steve Wade (swade1987)

I have our sales engineering team creating bugs in our repo but I’m having to manually add the project to them to appear on my bug triage project board which is a totally pita

2022-12-14

actions Archives | The GitHub Blog avatar
actions Archives | The GitHub Blog
10:35:35 AM

GitHub Actions – Sharing actions and reusable workflows from private repositories is now GA GitHub Actions - Sharing actions and reusable workflows from private repositories is now GA

GitHub Actions - Sharing actions and reusable workflows from private repositories is now GA | GitHub Changelogattachment image

GitHub Actions - Sharing actions and reusable workflows from private repositories is now GA

3
1

2022-12-16

actions Archives | The GitHub Blog avatar
actions Archives | The GitHub Blog
06:05:37 PM

GitHub Actions: SBOMs now attached to hosted runner image releases for Ubuntu & Windows GitHub Actions: SBOMs now attached to hosted runner image releases for Ubuntu & Windows

GitHub Actions: SBOMs now attached to hosted runner image releases for Ubuntu & Windows | GitHub Changelogattachment image

GitHub Actions: SBOMs now attached to hosted runner image releases for Ubuntu & Windows

2022-12-21

Deepak Kosaraju avatar
Deepak Kosaraju

@RB related to https://sweetops.slack.com/archives/CQCDCLA1M/p1671645194194069 I am thinking to continue the discussion here for other wider discussion

wave All: I have question related to https://github.com/cloudposse/github-action-pre-commit, is this the right channel to ask

Deepak Kosaraju avatar
Deepak Kosaraju

I tried both v2.x and v3.x but auto-fix and commit didn’t work for me. My current configuration with 2.x and action error,

• I was hoping that with auto-fix and commit that it will fix the failed checks fixes them and commit back to PR. Please feel free to correct me.

wave All: I have question related to https://github.com/cloudposse/github-action-pre-commit, is this the right channel to ask

Deepak Kosaraju avatar
Deepak Kosaraju
Deepak Kosaraju avatar
Deepak Kosaraju
Deepak Kosaraju avatar
Deepak Kosaraju

I didn’t see commit for end-of-file-fixer pre-commit hook fixed the file as well.

RB avatar

Perhaps the 3.x is broken then. I have only used 2.x with success.

Did you try 2.x and see if it works for you?

The github user and email does not have to be an actual user. The previous pre-commit action did not support overriding the user and email so that was why we forked it.

RB avatar

It looks like pre-commit is not found on the github action server ?

Deepak Kosaraju avatar
Deepak Kosaraju

Thanks for the response, from the output it has pre-commit CLI. Above output was based of v2.x

RB avatar

I’m unsure what the error is from the output. It just says that it failed. Could you try it with a smaller pre commit config?

Then can you confirm if pre-commit works locally as expected?

Deepak Kosaraju avatar
Deepak Kosaraju

Sure, I am in PST, is it possible to share references of following that can help me further in the exercise of troubleshooting,

• one of CloudPosse terraform module repo that is using this action

• reference to sample PR that has this action fixed

• Screenshot of action log of what to except as end result from the action log, like when it fixes and submits as commit. Thanks for all your time @RB

Deepak Kosaraju avatar
Deepak Kosaraju

@RB - is it possible to share before EOD based on your bandwidth today

RB avatar

Sorry unsure if i can help so soon. It might be good to create an issue on the upstream github project or try to debug the issue on your gha run. The gha seems to be working for us for our clients

1
Deepak Kosaraju avatar
Deepak Kosaraju

Thanks for your time in looking in to my request. Can you share a tip on how you can test gha run locally without committing the changes. You might be having some workflow so curious to learn.

RB avatar

I mean run precommit locally

Deepak Kosaraju avatar
Deepak Kosaraju

Ran pre-commit locally and it works in auto-fixing end-of-line-fixer but not tflint, with tflint it’s showing warnings and not doing anything

RB avatar

That points to a tflint issue

RB avatar

Id run the gha with the fewest precommit config as possible to get it to work and then incrementally add more hooks

1
1
RB avatar

I bet the tflint or one of the other hooks is failing and masking the issue

Deepak Kosaraju avatar
Deepak Kosaraju

I am on leave till Jan 2nd 2023, will give a try if else I touch work in between. Thank you so much for your time and attention to detail to help me.

I wish you Warm(Weather this year has been horiable so far), Safe and Happy Holidays with family and friends. MARRY Christmas, Happy New Year my friend.

RB avatar

You’re welcome. Happy holidays!

Deepak Kosaraju avatar
Deepak Kosaraju

@RB I have disabled tflint and able to see commit from auto-fixes by other hooks. BTW: I also found this https://github.com/terraform-linters/tflint/issues/266, which I have learned that tflint don’t auto-fix so job keeps failing the action.

#266 feat: Add a --fix option to auto fix small issues like eslint

For example, we could fix

• unused variables • alphabetize aws_iam_policy_document’s actions • convert aws service roles into data sources • convert iam policy json into data source • this golang project can be used https://github.com/flosell/iam-policy-json-to-terraform • convert JSON into a local variable and use jsonencode() to dump • replace // comments with # • im sure there are many other cases

Deepak Kosaraju avatar
Deepak Kosaraju

Any suggestion how you might be handling these for your community modules, I didn’t find any references to use of github-action-pre-commit in your community module repos.

Any suggestion on how you are doing Linting from contributions to your modules? What I found from one of open PR in one of your OSS module was following,

2022-12-22

2022-12-23

    keyboard_arrow_up