Discussions related to GitHub Actions
GitHub Actions: Larger Runners using Ubuntu-latest label will now use Ubuntu-22.04 GitHub Actions: Larger Runners using Ubuntu-latest label will now use Ubuntu-22.04
GitHub Actions: Larger Runners using Ubuntu-latest label will now use Ubuntu-22.04
GitHub Actions workflow notifications in Slack and Microsoft Teams GitHub Actions workflow notifications in Slack and Microsoft Teams
Extending Checks Retention Policies to GHES Extending Checks Retention Policies to GHES
Extending Checks Retention Policies to GHES
Hey all does anyone know how to automate adding the project to a GitHub issue on creation?
I have our sales engineering team creating bugs in our repo but I’m having to manually add the project to them to appear on my bug triage project board which is a totally pita
GitHub Actions – Sharing actions and reusable workflows from private repositories is now GA GitHub Actions - Sharing actions and reusable workflows from private repositories is now GA
GitHub Actions - Sharing actions and reusable workflows from private repositories is now GA
GitHub Actions: SBOMs now attached to hosted runner image releases for Ubuntu & Windows GitHub Actions: SBOMs now attached to hosted runner image releases for Ubuntu & Windows
GitHub Actions: SBOMs now attached to hosted runner image releases for Ubuntu & Windows
@RB related to https://sweetops.slack.com/archives/CQCDCLA1M/p1671645194194069 I am thinking to continue the discussion here for other wider discussion
I tried both
v3.x but auto-fix and commit didn’t work for me. My current configuration with
2.x and action error,
• I was hoping that with auto-fix and commit that it will fix the failed checks fixes them and commit back to PR. Please feel free to correct me.
I didn’t see commit for
end-of-file-fixer pre-commit hook fixed the file as well.
Perhaps the 3.x is broken then. I have only used 2.x with success.
Did you try 2.x and see if it works for you?
The github user and email does not have to be an actual user. The previous pre-commit action did not support overriding the user and email so that was why we forked it.
It looks like pre-commit is not found on the github action server ?
Thanks for the response, from the output it has
pre-commit CLI. Above output was based of v2.x
I’m unsure what the error is from the output. It just says that it failed. Could you try it with a smaller pre commit config?
Then can you confirm if pre-commit works locally as expected?
Sure, I am in PST, is it possible to share references of following that can help me further in the exercise of troubleshooting,
• one of CloudPosse terraform module repo that is using this action
• reference to sample PR that has this action fixed
• Screenshot of action log of what to except as end result from the action log, like when it fixes and submits as commit. Thanks for all your time @RB
@RB - is it possible to share before EOD based on your bandwidth today
Sorry unsure if i can help so soon. It might be good to create an issue on the upstream github project or try to debug the issue on your gha run. The gha seems to be working for us for our clients
Thanks for your time in looking in to my request. Can you share a tip on how you can test gha run locally without committing the changes. You might be having some workflow so curious to learn.
I mean run precommit locally
Ran pre-commit locally and it works in auto-fixing end-of-line-fixer but not tflint, with tflint it’s showing warnings and not doing anything
That points to a tflint issue
Id run the gha with the fewest precommit config as possible to get it to work and then incrementally add more hooks
I bet the tflint or one of the other hooks is failing and masking the issue
I am on leave till Jan 2nd 2023, will give a try if else I touch work in between. Thank you so much for your time and attention to detail to help me.
I wish you Warm(Weather this year has been horiable so far), Safe and Happy Holidays with family and friends. MARRY Christmas, Happy New Year my friend.
You’re welcome. Happy holidays!
@RB I have disabled
tflint and able to see commit from
auto-fixes by other hooks.
BTW: I also found this https://github.com/terraform-linters/tflint/issues/266, which I have learned that
tflint don’t auto-fix so job keeps failing the action.
For example, we could fix
• unused variables
• convert aws service roles into data sources
• convert iam policy json into data source
• this golang project can be used https://github.com/flosell/iam-policy-json-to-terraform
• convert JSON into a local variable and use
jsonencode() to dump
// comments with
• im sure there are many other cases
Any suggestion how you might be handling these for your community modules, I didn’t find any references to use of
github-action-pre-commit in your community module repos.
Any suggestion on how you are doing Linting from contributions to your modules? What I found from one of open PR in one of your OSS module was following,