#helmfile (2024-05)

The pull request in question is https://github.com/helmfile/helmfile/pull/1494

You’ve asked me to write some tests. As stated in my early comment on the pull request, I am not a golang programmer. I’ve spend half of the day today (Sat) trying to learn enough go to be able to perform your request, but I still don’t have enough knowledge to know how to proceed.

Do I just add something like this to the TestTemplate function in pkg/app/app_template_test.go

OR am I supposed to do something in test/e2e/template/helmfile/tmpl_test.go instead? (or as well?)

OR am I supposed to do something under test/integration/test-cases/ ?

Also a question on my change itself. Did I need to add the showOnly stuff to the HelmSpec and ReleaseSpec structs in pkg/state/state.go? The HelmSpec struct is for the helmDefault values right? And the --show-only option for helmfile template wouldn’t be something you’d likely want to set in the helmDefault section I suspect. And the ReleaseSpec struct if for the release: section of helmfile.yaml right? So probably also an area where you wouldn’t set the new parameter. I suspect I should remove it from those places?

I also don’t know if the changes I did in pkg/app/app_test.go were necessary or not?

And if I don’t need those vars in the structs, then I guess my change to pkg/state/helmx.go simply becomes the following instead?

I will help you. Waiting for my commit. Study with each other. Thanks so much.

Thanks.

I’d like to attempt to work on this again tomorrow. To help me get started, can you please let me know where I should create my tests? I’m thinking it is in one of the following 3 locations? • In pkg/app/app_template_test.go ? • In test/e2e/template/helmfile/tmpl_test.go ? • Or in the test/integration/test-cases/ area?

I’ve made changes to remove showOnly from the HelmSpec and ReleaseSpec structs in pkg/state/state.go that I had previously added as it doesn’t make sense to specify this flag against helmDefaults: nor releases: in helmfile.yaml. And likewise I’ve adjusted the change in pkg/state/helmx.go to cater for the above.

And I’ve added a test to pkg/app/app_template_test.go

Finally I rebased it against your upstream changes to the main branch, and squashed my changes together.

How’s that looking?

I’ve installed golangci-lint on my system and fixed the lint error as well now.

Hmm. The integration tests failed whereas last time they passed fine. Seems more like a pipeline issue this time rather than my change?

I’ve pushed the change adding the other test that you asked for.

It sounds like the directory might be being used the way environments are intended to be used. The exec could work, but I think it may be relative to the current working directory where helmfile is being executed and not the path of the helmfile. Also, since helmfiles can import other helmfiles, the knowing the path is a bit ambiguous.

We usually use things in the built-in object to determine the namespace

https://helmfile.readthedocs.io/en/latest/builtin-objects/

And have environments define the namespace

This is pretty much exactly what I was thinking. Thank you for the input!

The environment was what I was trying to use as the folder name. I have since looked at doing a helmfile per service as per the docs.