#help (2020-09)
Where to get help about getting help!
2020-09-16
Hello there, I don’t know where to ask a github related question. I did some PR on a repo and just want to know if there is something wrong with it or if I just need to wait someone have some time to review it.
First time I try to PR your modules, so I’m not sure to do things correctly
Ok… I think I found out why hmm
@Iouns Thanks for the contribution. We are trying to move all modules over to use terraform-null-label’s new context approach. You can see an example here: https://github.com/cloudposse/terraform-aws-eks-cluster/pull/75
Yeah, I did realized that digging through the k8s module
It’s a much more complex work, I’ll try to make another PR with this implementation
Thank you for your guidance
@Iouns what is your PR? I can take a look and we’ll fix it
Unfortunatly, I need to rework it a little bit. I’ll get back to you as soon as I can
ok, for [contxt.tf](http://contxt.tf) related PR (also to update Terratest to go modules and other stuff), see these examples
great ty
ok great, this sounds not so hard to PR, I’ll try to do that by the end the end of the week
when you download the repo to your computer, cd to it and then run these commands (besides making changes to the code):
One last thing, do you have some github issue/discussion which explain the rationale for moving to context.tf ?
- to standardize on the common fields like namespace, stage, environment, name, attributes, tags, enabled
- make modules invocation simpler by just providing the context instead of (inconsistently) repeating all the variables
Okok. ty
here are almost complete steps to convert to context and go modules:
make init
make github/init
cd test/src/
go mod init github.com/cloudposse/$(cd ../../ && basename `pwd`)
go mod tidy
git rm Gopkg.*
git add go.*
<copy context.tf into the module and into the examples/complete>
<remove redundant variables (namespace, stage, environment, name, attributes, tags, enabled) from variables.tf in the module and examples/complete>
<remove redundant `terraform-null-label` modules from the module, use the label from context.tf whenever possible. If you need to add attributes, use a new label invocation and provide the context>
<update the module code and the example code to use context, update the Terratest `go` code to use random attributes for testing>
make readme
Perfect, I’ll try that then. thank you very much
I think I have it working, just hit https://discuss.hashicorp.com/t/computed-attribute-cannot-be-set-for-aws-s3-bucket-region/13309/4, I’ll push what I have soon
yes, aws provider v3 does not support region attribute
we have updated terraform-aws-s3-bucket module for that
Yes I saw that PR
Here the first one: https://github.com/cloudposse/terraform-aws-iam-s3-user/pull/22
Once reviwed, merged and tagged I’ll finish the terraform-aws-s3-bucket
looks good, thanks, left a comment
Yeah I’m on it
done