#pr-reviews (2020-06)
Pull Request Reviews for Cloud Posse Projects
2020-06-01
Hello! Could someone take a look? https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/82
2020-06-05
Good morning, Could I get a review on https://github.com/cloudposse/terraform-aws-s3-bucket/pull/27 when someone has a moment? This replaces pr#23 in the same repo with an alternate/more flexible implementation.
I created 2 more PR’s for the above project that close out a couple of tickets. I would love a review of those also. Thank you!
so sorry everyone - @Andriy Knysh (Cloud Posse) has been out of town this week
np
you’re most patient @jose.amengual
slow and steady you are bound to succeed
2020-06-12
https://github.com/cloudposse/terraform-aws-vpc/pulls could some PRs be reviewed for this module? These are open since march 26th.
We are working on increasing our collaborators for Pr reviews
We have started a group with about 7 now. Still writing up the documentation they need to get started. Sorry we have over 270 open PRs
On a semi-related note: do you guys know about https://github.com/renovatebot/renovate?
I see sometimes the PRs are just module reference updates that you guys created yourself. I use Renovate to update walk over our Terraform code and raise a PR whenever there’s an update for a module.
We have dependabot available for that too - have avoided mostly because concern about ensuring stability. We do have terratest on most modules these days, but automated PRs do increase the code reviews since they are mandatory on all repos for security. For example one change to null label module will cause 150 PRs!
We are dealing with a unique scale and problem few organizations deal with :-)
Wow, okay never mind then That’s not the amount PRs we generate no.
2020-06-16
i was going to start using https://github.com/cloudposse/slack-notifier but i want buttons https://api.slack.com/legacy/message-buttons .. i wonder if you could do something like?
SLACK_BUTTON_COUNT=2
SLACK_BUTTON_1_TEXT=approve
SLACK_BUTTON_1_URL=<https://codefresh/${CF_BUILD_ID}/approve>
SLACK_BUTOTN_2_TEXT=deny
SLACK_BUTTON_2_URL=<https://codefresh/${CF_BUILD_ID}/deny>
but erik suggested i might just be better off using gomplate and i think he’s right
That could work. I think the count might not even be necessary.
I’d just enumerate the ENVs until not defined.
What about button color?
i ended up using gomplate
2020-06-17
Good morning! Could someone please take a look at my PR? https://github.com/cloudposse/terraform-aws-ses/pull/2 Thanks!
Merged. Thanks!
thanks @Matt Gowie!!
