#pr-reviews (2020-08)
Pull Request Reviews for Cloud Posse Projects
2020-08-03
@OliverS asks:
About https://github.com/cloudposse/terraform-aws-eks-fargate-profile/pull/3 where do you want to have that conversation, here in DM or in a group channel?
Ok, to fix the EKS tests we need to upgrade to go modules.
eshhh I should have documented this process So here is an example where we fixed it recently: https://github.com/cloudposse/terraform-aws-eks-cluster/pull/66/files
follow these steps
- Copy the
Makefilefrom this PR 2.go mod init [github.com/cloudposse/terraform-aws-eks-node-group](http://github.com/cloudposse/terraform-aws-eks-node-group)3.go mod tidy4.git add go.* - rebuild readme:
make initthenmake readme - Remove any
Gopkg.*files 7.
@OliverS has joined the channel
2020-08-06
https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/34 Can someone please take a look at this one? It’s not mine but it would definitly be nice to get this module supported past Terraform 0.11 :)
@Frank The CP policy has been to require terratests before merging 0.12 upgrades as the contributor team needs them to support future maintainability. So we’ll need to address that bit before we can merge. It typically holds things up as it’s painful to add, but it is important when dealing with 200+ open source modules.
I’ll surface with the contributor team and try to push this further. Thanks for bringing it up!
Understandable, thanks!
2020-08-10
Minor modification to this module in preparation of 0.13: https://github.com/cloudposse/terraform-github-repository-webhooks/pull/22
@Frank Shipped as 0.9.0 — Thanks!
Thanks!
2020-08-14
https://github.com/cloudposse/terraform-opsgenie-incident-management/pull/3
Just added support for ignore_members in the team module. I added it as part of the team map and as a variable, in two commits, for reference. not sure which approach you guys prefer.
2020-08-20
https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/68
I’ve been working on adding support for Terraform 0.13 for this module. I think I’m there for 99% but the test is currently failing on some Go error and I’m not sure why
@Andriy Knysh (Cloud Posse)
will check, thanks
2020-08-25
https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/37 More prep work for TF 0.13 (this needs to be able to work with 0.12 first).
@Andriy Knysh (Cloud Posse)