#pr-reviews (2020-08)

Pull Request Reviews for Cloud Posse Projects

2020-08-26

2020-08-25

Frank avatar
Frank

https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/37 More prep work for TF 0.13 (this needs to be able to work with 0.12 first).

feat: Upgrade to Terraform 0.12 by syphernl · Pull Request #37 · cloudposse/terraform-aws-cloudfront-cdn

what Synced up repo config with that of other CP repos (chatops, releasing, go, actions etc) Update any version pinning Added a type to all variables Modified ordered_cache_behavior to match that …

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@Andriy Knysh (Cloud Posse)

feat: Upgrade to Terraform 0.12 by syphernl · Pull Request #37 · cloudposse/terraform-aws-cloudfront-cdn

what Synced up repo config with that of other CP repos (chatops, releasing, go, actions etc) Update any version pinning Added a type to all variables Modified ordered_cache_behavior to match that …

2020-08-20

Frank avatar
Frank

https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/68

I’ve been working on adding support for Terraform 0.13 for this module. I think I’m there for 99% but the test is currently failing on some Go error and I’m not sure why

Upgrade modules and examples to support Terraform 0.13 by syphernl · Pull Request #68 · cloudposse/terraform-aws-ecs-web-app

what Update any version pinning Updated examples (locally verified) no terraform init errors using cli in main module & examples (locally verified) no terraform validate errors using cli in ma…

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@Andriy Knysh (Cloud Posse)

Upgrade modules and examples to support Terraform 0.13 by syphernl · Pull Request #68 · cloudposse/terraform-aws-ecs-web-app

what Update any version pinning Updated examples (locally verified) no terraform init errors using cli in main module & examples (locally verified) no terraform validate errors using cli in ma…

Andriy Knysh (Cloud Posse) avatar
Andriy Knysh (Cloud Posse)

will check, thanks

2020-08-14

Eric Berg avatar
Eric Berg

https://github.com/cloudposse/terraform-opsgenie-incident-management/pull/3 Just added support for ignore_members in the team module. I added it as part of the team map and as a variable, in two commits, for reference. not sure which approach you guys prefer.

Added ignore_members variable and use it in opsgenie_team resource by bergbrains · Pull Request #3 · cloudposse/terraform-opsgenie-incident-management

what adds a variable ignore_members to the team module that is passed to the opsgenie_team resource. Defaults to false. why Ignoring changes to team membership, allows you to manage that in the…

1

2020-08-10

Frank avatar
Frank

Minor modification to this module in preparation of 0.13: https://github.com/cloudposse/terraform-github-repository-webhooks/pull/22

Only use a single list of required_providers by syphernl · Pull Request #22 · cloudposse/terraform-github-repository-webhooks
what De-duplicated the required_providers list why Previously it would have a github provider version defined in both [main.tf> and <http://versions.tf versions.tf](http://main.tf) In Terraform 0.13 this would no longer work (in this…
Matt Gowie avatar
Matt Gowie

@ Shipped as 0.9.0 — Thanks!

Only use a single list of required_providers by syphernl · Pull Request #22 · cloudposse/terraform-github-repository-webhooks
what De-duplicated the required_providers list why Previously it would have a github provider version defined in both [main.tf> and <http://versions.tf versions.tf](http://main.tf) In Terraform 0.13 this would no longer work (in this…
Frank avatar
Frank

Thanks!

2020-08-06

Frank avatar
Frank

https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/34 Can someone please take a look at this one? It’s not mine but it would definitly be nice to get this module supported past Terraform 0.11 :)

UPGRADE: Support for Terraform 0.12 by mattclegg · Pull Request #34 · cloudposse/terraform-aws-cloudfront-cdn

what This is an upgrade to support Terraform 0.12. why Terraform v0.12 is a major release but most of the changes are syntax related. I have imported the changes suggested by @rverma-nikiai &amp…

1
Matt Gowie avatar
Matt Gowie

@ The CP policy has been to require terratests before merging 0.12 upgrades as the contributor team needs them to support future maintainability. So we’ll need to address that bit before we can merge. It typically holds things up as it’s painful to add, but it is important when dealing with 200+ open source modules.

I’ll surface with the contributor team and try to push this further. Thanks for bringing it up!

UPGRADE: Support for Terraform 0.12 by mattclegg · Pull Request #34 · cloudposse/terraform-aws-cloudfront-cdn

what This is an upgrade to support Terraform 0.12. why Terraform v0.12 is a major release but most of the changes are syntax related. I have imported the changes suggested by @rverma-nikiai &amp…

Frank avatar
Frank

Understandable, thanks!

2020-08-03

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@ asks:
About https://github.com/cloudposse/terraform-aws-eks-fargate-profile/pull/3 where do you want to have that conversation, here in DM or in a group channel?

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

Ok, to fix the EKS tests we need to upgrade to go modules.

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

eshhh I should have documented this process So here is an example where we fixed it recently: https://github.com/cloudposse/terraform-aws-eks-cluster/pull/66/files

follow these steps

  1. Copy the Makefile from this PR 2. go mod init [github.com/cloudposse/terraform-aws-eks-node-group](http://github\.com/cloudposse/terraform\-aws\-eks\-node\-group)  3. go mod tidy 4. git add go.*
  2. rebuild readme: make init then make readme
  3. Remove any Gopkg.* files 7. 
:--1:1
OliverS avatar
OliverS
04:45:23 PM

@ has joined the channel

    keyboard_arrow_up