#pr-reviews (2020-08)
Pull Request Reviews for Cloud Posse Projects
2020-08-03
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
@OliverS asks:
About https://github.com/cloudposse/terraform-aws-eks-fargate-profile/pull/3 where do you want to have that conversation, here in DM or in a group channel?
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
Ok, to fix the EKS tests we need to upgrade to go modules.
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
eshhh I should have documented this process So here is an example where we fixed it recently: https://github.com/cloudposse/terraform-aws-eks-cluster/pull/66/files
follow these steps
- Copy the
Makefile
from this PR 2.go mod init [github.com/cloudposse/terraform-aws-eks-node-group](http://github.com/cloudposse/terraform-aws-eks-node-group)
3.go mod tidy
4.git add go.*
- rebuild readme:
make init
thenmake readme
- Remove any
Gopkg.*
files 7.
what restore init target why
![OliverS avatar](https://avatars.slack-edge.com/2020-04-30/1107989667377_3841766be8721753183c_72.jpg)
@OliverS has joined the channel
2020-08-06
![Frank avatar](https://secure.gravatar.com/avatar/1b4b7744d083431522fb3e1b49206492.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/34 Can someone please take a look at this one? It’s not mine but it would definitly be nice to get this module supported past Terraform 0.11 :)
what This is an upgrade to support Terraform 0.12. why Terraform v0.12 is a major release but most of the changes are syntax related. I have imported the changes suggested by @rverma-nikiai &…
![Matt Gowie avatar](https://avatars.slack-edge.com/2023-02-06/4762019351860_44dadfaff89f62cba646_72.jpg)
@Frank The CP policy has been to require terratests before merging 0.12 upgrades as the contributor team needs them to support future maintainability. So we’ll need to address that bit before we can merge. It typically holds things up as it’s painful to add, but it is important when dealing with 200+ open source modules.
I’ll surface with the contributor team and try to push this further. Thanks for bringing it up!
what This is an upgrade to support Terraform 0.12. why Terraform v0.12 is a major release but most of the changes are syntax related. I have imported the changes suggested by @rverma-nikiai &…
![Frank avatar](https://secure.gravatar.com/avatar/1b4b7744d083431522fb3e1b49206492.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
Understandable, thanks!
2020-08-10
![Frank avatar](https://secure.gravatar.com/avatar/1b4b7744d083431522fb3e1b49206492.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
Minor modification to this module in preparation of 0.13: https://github.com/cloudposse/terraform-github-repository-webhooks/pull/22
what De-duplicated the required_providers list why Previously it would have a github provider version defined in both main.tf and versions.tf In Terraform 0.13 this would no longer work (in this…
![Matt Gowie avatar](https://avatars.slack-edge.com/2023-02-06/4762019351860_44dadfaff89f62cba646_72.jpg)
@Frank Shipped as 0.9.0 — Thanks!
what De-duplicated the required_providers list why Previously it would have a github provider version defined in both main.tf and versions.tf In Terraform 0.13 this would no longer work (in this…
![Frank avatar](https://secure.gravatar.com/avatar/1b4b7744d083431522fb3e1b49206492.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
Thanks!
2020-08-14
![Eric Berg avatar](https://avatars.slack-edge.com/2022-02-23/3149638965779_b5a77c77548365fff07f_72.jpg)
https://github.com/cloudposse/terraform-opsgenie-incident-management/pull/3
Just added support for ignore_members
in the team module. I added it as part of the team
map and as a variable, in two commits, for reference. not sure which approach you guys prefer.
what adds a variable ignore_members to the team module that is passed to the opsgenie_team resource. Defaults to false. why Ignoring changes to team membership, allows you to manage that in the…
2020-08-20
![Frank avatar](https://secure.gravatar.com/avatar/1b4b7744d083431522fb3e1b49206492.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/68
I’ve been working on adding support for Terraform 0.13 for this module. I think I’m there for 99% but the test is currently failing on some Go error and I’m not sure why
what Update any version pinning Updated examples (locally verified) no terraform init errors using cli in main module & examples (locally verified) no terraform validate errors using cli in ma…
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
@Andriy Knysh (Cloud Posse)
what Update any version pinning Updated examples (locally verified) no terraform init errors using cli in main module & examples (locally verified) no terraform validate errors using cli in ma…
![Andriy Knysh (Cloud Posse) avatar](https://avatars.slack-edge.com/2018-06-13/382332470551_54ed1a5d986e2068fd9c_72.jpg)
will check, thanks
2020-08-25
![Frank avatar](https://secure.gravatar.com/avatar/1b4b7744d083431522fb3e1b49206492.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/37 More prep work for TF 0.13 (this needs to be able to work with 0.12 first).
what Synced up repo config with that of other CP repos (chatops, releasing, go, actions etc) Update any version pinning Added a type to all variables Modified ordered_cache_behavior to match that …
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
@Andriy Knysh (Cloud Posse)
what Synced up repo config with that of other CP repos (chatops, releasing, go, actions etc) Update any version pinning Added a type to all variables Modified ordered_cache_behavior to match that …