#pr-reviews (2020-10)

Pull Request Reviews for Cloud Posse Projects


Alex S avatar

Hi, I’ve just upgraded a module for TF 0.12 + 0.13 (mainly via the automated update commands) + updated dependency null-label https://github.com/cloudposse/terraform-aws-cloudwatch-flow-logs/pull/14

Matt Gowie avatar
Matt Gowie

Hey Alex, thanks! This is a great start. We’ve been requiring that 0.11 to 0.12 upgrades include tests as it’s the only way to properly maintain this number of modules. So to get this merged, we’ll need to get an examples/complete example in place and our test harness / simple terratests in place.

As an example of this — here is a recent upgrade that I carried over the line yesterday: https://github.com/cloudposse/terraform-aws-iam-user/pull/9

Would you mind updating your PR to include similar updates?

Bring this module into the new world by Gowiem · Pull Request #9 · cloudposse/terraform-aws-iam-user

what This builds off of the work from @chess-seventh and @ivanmartos to bring this module up-to-date with the latest and greatest Cloud Posse practices: Adds 0.12+ support Updates tests to use new…

Alex S avatar

Cool, let me give it a go! Cheers