#pr-reviews (2020-11)
Pull Request Reviews for Cloud Posse Projects
2020-11-12
Hi! I’d like to user 3.x aws provider with ecs module https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/77
2020-11-16
Can someone take a look at these please?
• https://github.com/cloudposse/terraform-aws-ec2-bastion-server/pull/38
• https://github.com/cloudposse/terraform-aws-ec2-bastion-server/pull/40
• https://github.com/cloudposse/terraform-aws-key-pair/pull/52
• https://github.com/cloudposse/terraform-aws-ec2-bastion-server/pull/39
2020-11-17
2020-11-21
Could somebody take a look? https://github.com/cloudposse/terraform-aws-ecs-cloudwatch-autoscaling/pull/9
2020-11-23
Heey, it’s me again
https://github.com/cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms/pull/25
Hey there
So this still needs the new test/src/Makefile
which is why the terratest is failing
Here’s what the new one looks like: https://github.com/cloudposse/terraform-null-label/blob/master/test/src/Makefile
That’s my mistake. I asked @Mikhail Naletov to change the tests but forgot about the Makefile!
Yes
@Vladimir S. want to discuss https://github.com/cloudposse/terraform-null-label/pull/107
hey @Erik Osterman (Cloud Posse), sorry I’m currently overloaded on my work… and I looking for new opportunities in career… so interviews eats the rest of time… I hope that I’ll find a couple of hours on this week, I started to work on this on past Friday, but mb 15 mins. I thinking this to implement in style similar to @nuru suggestion.
tag_format = "default:titlecase" where default is tags formatting style which is CP style(titlecased keys and lowercased values)
and also others snake case,camelcase, kebab, etc
when I’ll have a PoC than we can discuss
@Erik Osterman (Cloud Posse) I’ve made some PoC and pushed it to same branch(PR) so you can take a look or play with new functionality
great! we’ll take a look at this
@Vladimir S. has joined the channel
2020-11-24
2020-11-30
