#pr-reviews (2021-03)
Pull Request Reviews for Cloud Posse Projects
2021-03-01
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
what Added 3 variable defaults. The ecs cluster name is only required if codepipeline is enabled. The region variables don't need to be specified when the current aws region could be provided …
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
what Set the priority variables to null by default why If you do not set the priority, the listener rule will automatically set an unused priority for you which is a very nice default. We can ta…
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
Still says it needs to validate code owners. I saw the other day that someone was able to retrigger that check and it worked. Is there a gitops command for that?
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
Basically anytime the auto-format formats code, it causes the validate code owners to not run. We can fix it but it will require another mass update. We are trying to queue up some updates for that
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
In the meantime just make sure to auto format locally to avoid any issues
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
Thanks. I pushed an empty commit for now https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/127
what Added 3 variable defaults. The ecs cluster name is only required if codepipeline is enabled. The region variables don't need to be specified when the current aws region could be provided …
2021-03-02
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
review plz https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/126
Run make init
make init
shell: bash -e -o pipefail {0}
env:
MAKE_INCLUDES: Makefile
BUILD_HARNESS_BRANCH: master
curl: (6) Could not resolve host: git.io
make: *** No rule to make target ‘init’. Stop.
Error: Process completed with exit code 2.
what Fixes an issue in a previous PR #123 where value was used instead of valueFrom for the secrets key why This fixes a bug in which the secrets key will break the module due to the incorrect k…
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
the readme
what Fixes an issue in a previous PR #123 where value was used instead of valueFrom for the secrets key why This fixes a bug in which the secrets key will break the module due to the incorrect k…
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
is not working for some reason
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
Terraform module to generate well-formed JSON documents (container definitions) that are passed to the aws_ecs_task_definition Terraform resource - cloudposse/terraform-aws-ecs-container-definition
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
nothing is returned from https://git.io/build-harness
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
DNS_PROBE_FINISHED_NXDOMAIN
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
$ curl -vvv <https://git.io/build-harness>
* Could not resolve host: git.io
* Closing connection 0
curl: (6) Could not resolve host: git.io
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
so this is what happens when git.io is down
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
well I guess we will have to wait
![Alex Jurkiewicz avatar](https://avatars.slack-edge.com/2020-09-08/1346106958085_9b44ddacd6267cc803c8_72.jpg)
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
looks like it’s back @jose.amengual
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
i did a /rebuild-readme
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
but it doesnt look like it’s running. last fail was from an hour ago
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
the emojis are on my comment…
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
weird
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
i just ran a /test all
and i got a thumbs up emoji but tests aren’t rerunning
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
I’m running it manually to see
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
the tests look like they kicked off!
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
what Add additional outputs which are marked sensitive which can be used when passing on secrets (secrets) or secret maps (map_secrets). why When using secrets (or map_secrets) and without sensi…
![Frank avatar](https://secure.gravatar.com/avatar/1b4b7744d083431522fb3e1b49206492.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
https://github.com/cloudposse/terraform-aws-rds/pull/109 Not sure why the do not merge
label was added without any comments
what Make parameter groups create_before_destroy Make the name for parameter & option groups unique to ensure we can create new one's Add explicit dependencies why You cannot delete a pa…
2021-03-08
![Frank avatar](https://secure.gravatar.com/avatar/1b4b7744d083431522fb3e1b49206492.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/124 Can someone please take a look at this one? Thanks!
what Add additional outputs which are marked sensitive which can be used when passing on secrets (secrets) or secret maps (map_secrets). why When using secrets (or map_secrets) and without sensi…
![Matt Gowie avatar](https://avatars.slack-edge.com/2023-02-06/4762019351860_44dadfaff89f62cba646_72.jpg)
@Frank merged
what Add additional outputs which are marked sensitive which can be used when passing on secrets (secrets) or secret maps (map_secrets). why When using secrets (or map_secrets) and without sensi…
![Frank avatar](https://secure.gravatar.com/avatar/1b4b7744d083431522fb3e1b49206492.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
Thanks!
2021-03-09
![Frank avatar](https://secure.gravatar.com/avatar/1b4b7744d083431522fb3e1b49206492.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/115 <– the 0.35.0 version causes quite a few problems in existing setups. This PR should provide a way to work around that.
what Made the security group description configurable why Since v0.35.0 a description will be set which replaces the default "Managed by Terraform". Unfortunately, a change in security…
![marcuz avatar](https://avatars.slack-edge.com/2021-03-10/1847676970516_73c23ade1c0039231721_72.jpg)
hello! looking for a review pretty please https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/93
what Allow empty egress_cidr_blocks (no egress rules in default security group) why Not mandatory to have an egress rule references #90
2021-03-12
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
hey all, I am a bit confused what is needed for this pull request:
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
what I am adding dynamic object to support secindary sources why You are not supporting it right now and we need it.
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
comment on the PR to get more details
what I am adding dynamic object to support secindary sources why You are not supporting it right now and we need it.
![mihai.plesa avatar](https://secure.gravatar.com/avatar/663277330091d41f09410afd2b1606e1.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
hello again, here’s one adding more utility to the CDN by passing cache policy ID https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/57
what Adding cache_policy_id to the aws_cloudfront_distribution resource. why We want to provide a cloudfront_cache_policy resource to the module. references aws_cloudfront_distribution Terraf…
![mihai.plesa avatar](https://secure.gravatar.com/avatar/663277330091d41f09410afd2b1606e1.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
this is similar, needs tests started https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/140
what AWS has a relatively new CloudFront feature named Cache Policies: https://aws.amazon.com/blogs/networking-and-content-delivery/amazon-cloudfront-announces-cache-and-origin-request-policies/ T…
2021-03-15
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
hey all, to proceed pull request 73, I rebased:
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
what Our codebuild environment needs double sources as input to build why We use code that is based on gitlab , gitlab is not supported by codebuild so we need to upload zip files to support our…
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
could you have a look ?
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
looks like is still behind master
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
ran a fmt through all the terraform code in the branch
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
and pushed
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
should I allow the cloudpossebot write access to my repo ?
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
yes
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
you can pull from origin/master and fix the conflicts
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
the cloudposse master ?
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
no the master branch
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
your code is behind so you need to rebase
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
ok, let me check
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
thx for the help, I don’t do this often
2021-03-16
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
Hi all, found the time to do this properly. This is a rebase of pull request 73:
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
What Our codebuild environment needs double sources as input to build Why We use code that is based on gitlab , gitlab is not supported by codebuild so we need to upload zip files to support our co…
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
I left a comment
What Our codebuild environment needs double sources as input to build Why We use code that is based on gitlab , gitlab is not supported by codebuild so we need to upload zip files to support our co…
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
let me check, thanks
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
pushed a change, is this what you mean ?
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
left another comment but basically you can do : for_each = var.secondary_sources
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
yeah that’s clear, thx
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
pushed
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
have you look at this ? https://github.com/cloudposse/terraform-aws-codebuild/pull/78
Fixes #77. what Adds an optional secondary artifact deployment to S3 why Allow the https://github.com/cloudposse/terraform-aws-ecs-web-app module to use the changes for a lightweight deployment …
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
yeah I saw this as well
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
it could go hand in hand indeed
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
let me check
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
secondary_sources is missing a description
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
the tests are failing on that
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
let me check
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
where should that go ?
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
you need a description in every variable
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
ha correct, let me fix it
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
pushed, I am not a native English speaker, so feel free to correct
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
me neither
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
what do you mean by (Optional) secondary source for the built next to the primary location defined in variable source_location
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
built or build?
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
to build
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
I will rephrase, second
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
ok
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
rephrased and pushed
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
so it is an additional source for the build
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
?
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
yes correct
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
so you can use two s3 buckets for example, sepparate from each other
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
we do use it as such
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
(Optional) secondary source for the codebuild project in addition to the primary location
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
agreed
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
that is more concise
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
agreed
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
please change it
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
done
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
merged
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
excellent !
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
thx man !
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
np
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
Could you have a look ?
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
A very big thank you to @jose.amengual for helping me with merging code ! You are one of kind !
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
here goes the other one:
![Bart Coddens avatar](https://secure.gravatar.com/avatar/2172a7ffce39295e04ea825a5bc9b0b6.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0025-72.png)
Fixes #77. what Adds an optional secondary artifact deployment to S3 why Allow the https://github.com/cloudposse/terraform-aws-ecs-web-app module to use the changes for a lightweight deployment of …
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
make sure to run make init
Fixes #77. what Adds an optional secondary artifact deployment to S3 why Allow the https://github.com/cloudposse/terraform-aws-ecs-web-app module to use the changes for a lightweight deployment of …
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
make readme
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
closed in favour of #77
![Joe Hosteny avatar](https://secure.gravatar.com/avatar/851f2d21e357fbb172c3abfc9860d9c5.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0015-72.png)
Hi all, since there have been a few changes on this module lately, can I get a final review of this one too? https://github.com/cloudposse/terraform-aws-codebuild/pull/78
Fixes #77. what Adds an optional secondary artifact deployment to S3 why Allow the https://github.com/cloudposse/terraform-aws-ecs-web-app module to use the changes for a lightweight deployment …
![Joe Hosteny avatar](https://secure.gravatar.com/avatar/851f2d21e357fbb172c3abfc9860d9c5.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0015-72.png)
Thanks @jose.amengual!
Fixes #77. what Adds an optional secondary artifact deployment to S3 why Allow the https://github.com/cloudposse/terraform-aws-ecs-web-app module to use the changes for a lightweight deployment …
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
np
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
@Joe Hosteny have you seen this :
resource/aws_codebuild_project: The source and secondary_sources configuration block auth attributes have been deprecated to match the CodeBuild API documentation. Use the aws_codebuild_source_credential resource instead. (#17465)
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
NOTES: data-source/aws_vpc_endpoint_service: The service_type argument filtering has been switched from client-side to new EC2 API functionality (#17641) provider: New default_tags argument as a p…
![Joe Hosteny avatar](https://secure.gravatar.com/avatar/851f2d21e357fbb172c3abfc9860d9c5.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0015-72.png)
I have not. We are only using the secondary artifact config, which I don’t think this applies to?
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
ohh I think it was @Bart Coddens
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
you both have PRs for the repo
![Joe Hosteny avatar](https://secure.gravatar.com/avatar/851f2d21e357fbb172c3abfc9860d9c5.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0015-72.png)
I could help look into this one, but I will be on vacation this week
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
np
2021-03-17
2021-03-18
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
what Adds a null check for secrets and environment why For backwards compatibility cloudposse/terraform-aws-ecs-web-app#134 (comment) references N/A
2021-03-19
2021-03-21
2021-03-23
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
what Toggles between name and name_prefix asg arguments why To backport existing resources to use this module without recreating resources references Closes #28
2021-03-24
![Frank avatar](https://secure.gravatar.com/avatar/1b4b7744d083431522fb3e1b49206492.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
Can someone please take a look at this one: https://github.com/cloudposse/terraform-aws-ecs-alb-service-task/pull/112 ?
what Added the force_new_deployment flag to force new task deployment of the service Updated github configs why To make it possible to force a new deployment
![Frank avatar](https://secure.gravatar.com/avatar/1b4b7744d083431522fb3e1b49206492.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
what Added optional variables key_usage and customer_master_key_spec Updated GitHub configs why To be able to use the created KMS key with DNSSEC in Route53. The defaults remain unchanged. refe…
![Matt Gowie avatar](https://avatars.slack-edge.com/2023-02-06/4762019351860_44dadfaff89f62cba646_72.jpg)
Have to get a core team member to review this one. Will start that process.
what Added optional variables key_usage and customer_master_key_spec Updated GitHub configs why To be able to use the created KMS key with DNSSEC in Route53. The defaults remain unchanged. refe…
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
what Toggles between name and name_prefix asg arguments Affects aws_autoscaling_group and not the aws_launch_template Followed similar https://github.com/cloudposse/terraform-aws-security-group/b…
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
Could i please get a review for this ^
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
All 5 of the open PRs for the asg module are also ready for review
https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/pulls
Terraform module to provision Auto Scaling Group and Launch Template on AWS - cloudposse/terraform-aws-ec2-autoscale-group
2021-03-25
2021-03-26
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
could I get a review on this https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/131
what Cleaner multiple definition example using json_map why Best practices and readability references N/A
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
![Matt Gowie avatar](https://avatars.slack-edge.com/2023-02-06/4762019351860_44dadfaff89f62cba646_72.jpg)
I got some quota left — particularly for small changes like that one
![Matt Gowie avatar](https://avatars.slack-edge.com/2023-02-06/4762019351860_44dadfaff89f62cba646_72.jpg)
Though you need to post an empty commit to re-trigger some failed CI @RB
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
i think i messed it up
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
but now it’s running all the tests again lol
![Matt Gowie avatar](https://avatars.slack-edge.com/2023-02-06/4762019351860_44dadfaff89f62cba646_72.jpg)
Haha as long as it runs that one test then you’re good.
![Matt Gowie avatar](https://avatars.slack-edge.com/2023-02-06/4762019351860_44dadfaff89f62cba646_72.jpg)
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
what The example provided in the README.md gave an error when trying to run it since it set the attribute environment when it was probably trying set the attribute container_environment.
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
this guy AGAIN!!!!!!
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
lol
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
i saw your comment here https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/131#issuecomment-808486904
what The example provided in the README.md gave an error when trying to run it since it set the attribute environment when it was probably trying set the attribute container_environment.
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
the last update on the readme was in line with the automation, no ?
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
he updated the yaml
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
mmm no, he needs to only update the yaml
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
the then run make readme
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
wouldn’t it be the same result ?
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
if i ran /rebuild-readme
wouldnt it be enough ?
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
it will fail I think
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
but the reason behind running the make command is that the readme itself gets updated with the latest too
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
that makes sense!
2021-03-27
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
what Removed the old data.template_file source why Use more recent providers so M1 can be used references Closes #139
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
this was even more of a rabbit hole! which lead to this PR #143
Describe the Bug I am getting the following error when using this module: Error: Failed getting S3 bucket: BucketRegionError: incorrect region, the bucket is not in 'eu-central-1' region at…
This is for comments to ensure this PR doesn't break backwards compatibility. what This simplifies calculating the correct bucket regional domain name using the s3 bucket's bucket_regional…
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
Could i get another review on the removal of the static s3 bucket hack?
Describe the Bug I am getting the following error when using this module: Error: Failed getting S3 bucket: BucketRegionError: incorrect region, the bucket is not in 'eu-central-1' region at…
This is for comments to ensure this PR doesn't break backwards compatibility. what This simplifies calculating the correct bucket regional domain name using the s3 bucket's bucket_regional…
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
OMG that is confusing
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
the workaround of the data sources is interesting
2021-03-28
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
Fully removes the template provider from versions.tf. i forgot about this file in my last pr
https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/146
what Removes the unused template provider why Forgot to remove the provider in this PR #141 references Fully closes #139
2021-03-29
2021-03-30
![Frank avatar](https://secure.gravatar.com/avatar/1b4b7744d083431522fb3e1b49206492.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
Can someone please take a look at this one? Thanks! https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/147
what Replaced the enabled flag with distribution_enabled Corrected behavior for actual enabled flag to prevent from creating any resources why The enabled input was being used to manage the dist…
![mihai.plesa avatar](https://secure.gravatar.com/avatar/663277330091d41f09410afd2b1606e1.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
another good one from Harry https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/60 thanks in advance!
what Adds the Origin Request Policy attribute to the CloudFront distribution cache behaviours Nullifies any cache forwarded values if non-legacy cache behaviours are set. Taken from @dmattia PR. …
![mihai.plesa avatar](https://secure.gravatar.com/avatar/663277330091d41f09410afd2b1606e1.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
thank you @jose.amengual
what Adds the Origin Request Policy attribute to the CloudFront distribution cache behaviours Nullifies any cache forwarded values if non-legacy cache behaviours are set. Taken from @dmattia PR. …
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
can i get a review on https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/143
This is for comments to ensure this PR doesn't break backwards compatibility. what This simplifies calculating the correct bucket regional domain name using the s3 bucket's bucket_regional…
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
cc: @Andriy Knysh (Cloud Posse) if time permits since you left a comment on it last
This is for comments to ensure this PR doesn't break backwards compatibility. what This simplifies calculating the correct bucket regional domain name using the s3 bucket's bucket_regional…
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
what Set minimum protocol version to TLSv1.2_2019 why This is the most secure option as it only supports tls 1.2 and 1.3 references https://aws.amazon.com/about-aws/whats-new/2020/07/cloudfron…
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
Very small pr
what Set minimum protocol version to TLSv1.2_2019 why This is the most secure option as it only supports tls 1.2 and 1.3 references https://aws.amazon.com/about-aws/whats-new/2020/07/cloudfron…
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
One more small pr https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/142
what Provide better description for var.origin_bucket Provide an example of reusing an s3 bucket in the README why There's some confusion whether to define this value as the bucket to be cre…
2021-03-31
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
You folks are probably getting tired of me. Almost done with all the prs in cloudfront cdn!
https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/149
what Uses the bucket website_endpoint instead of the bucket_regional_domain_name The bucket_regional_domain_name is incorrectly documented in the hashicorp aws_cloudfront_distribution docs why F…
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
what Use acm module instead of awscli Kept original awscli command for posterity why Why use the CLI when you can use terraform ? references Closes #26
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
test failing
what Use acm module instead of awscli Kept original awscli command for posterity why Why use the CLI when you can use terraform ? references Closes #26