SweetOps #pr-reviews for October, 2021

Pull Request Reviews for Cloud Posse Projects

2021-10-04

Florian SILVA

Hello guys, I recently refreshed my previous PR above according to suggestions and recent rebase. Is it possible to have another review on it for merging ?

mihai.plesa

02:05:44 AM

https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/72 but also another PR there

Add support for realtime log config by linhkikuchi · Pull Request #72 · cloudposse/terraform-aws-cloudfront-cdn attachment image

what To add support for realtime log config on cloudfront for cloudfront-cdn module

2021-10-26

Frank

10:16:49 AM

https://github.com/cloudposse/terraform-aws-ses/pull/51 Can someone take a look at this (very small) PR? Thanks

feat: output the iam group name by syphernl · Pull Request #51 · cloudposse/terraform-aws-ses attachment image

what Added the ses_group_name output why The IAM Group can be created based on input or based on context (default). In the latter case it would be helpful to have the output of the group for doi…

Brian Ojeda

11:54:04 AM

https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/190

ignore origin bucket mfa delete by sgtoj · Pull Request #190 · cloudposse/terraform-aws-cloudfront-s3-cdn attachment image

what ignore mfa_delete property for origin s3 bucket why mfa_delete is not controlled by this module references #189

2021-10-27

Brian Ojeda

06:08:13 PM

bumping this ^