#pr-reviews (2022-08)
Pull Request Reviews for Cloud Posse Projects
2022-08-01

Hey crew, a buddy and I are working on some EKS changes, would love a review on this whenever someone gets a chance: https://github.com/cloudposse/terraform-aws-eks-node-group/pull/126 (needs another reviewer besides me )
What did I do
• Add detailed monitoring flag to the launch template of EC2 nodes
Why did I do this
• Some compliance tools will flag nodes used by this module because they don’t have detailed monitoring. This also allows metrics to be reported every minute as opposed to five minute intervals
Helpful references

If I can get a team member approval from @cloudposse-team that would be appreciated
What did I do
• Add detailed monitoring flag to the launch template of EC2 nodes
Why did I do this
• Some compliance tools will flag nodes used by this module because they don’t have detailed monitoring. This also allows metrics to be reported every minute as opposed to five minute intervals
Helpful references

2022-08-02

Useful for deploying to GovCloud since their partition there is “aws-us-gov” instead of just “aws”
what
Support other AWS partitions by templatizing ARNs that are currently hard coded
why
So the module can be used in other AWS partitions like GovCloud
references
Closes #92
2022-08-04

https://github.com/cloudposse/terraform-aws-ssm-tls-self-signed-cert/pull/14 If possible This breaks a number of other modules right now which are dependent on this
what
• Remove key_algorithm from tls_cert_request
why
• Deprecated
references
• Closes #13 • https://registry.terraform.io/providers/hashicorp/tls/latest/docs • https://registry.terraform.io/providers/hashicorp/tls/latest/docs/resources/cert_request#key_algorithm

Cc @Andriy Knysh (Cloud Posse) @Jeremy G (Cloud Posse)
what
• Remove key_algorithm from tls_cert_request
why
• Deprecated
references
• Closes #13 • https://registry.terraform.io/providers/hashicorp/tls/latest/docs • https://registry.terraform.io/providers/hashicorp/tls/latest/docs/resources/cert_request#key_algorithm

Released as v1.0.0

thank you so much for the quick reply

I think vpn module will still fail because version for ssm-tls module is pinned to 0.5 : https://github.com/cloudposse/terraform-aws-ec2-client-vpn/blob/master/main.tf#L25
version = "0.5.0"



this release may take about 20 min or so to be added to the registry

excellent, thank you very much !
2022-08-08

Hi all. I think I found a bug in the terraform-aws-ecs-web-app module. EFS volumes are not being correctly set in the resulting task definition by the the terraform-aws-ecs-alb-service-task Draft PR here. Who can I discuss this with? Thanks!
what
Creates a separated variable for EFS volumes.
why
• The way terraform-aws-ecs-web-app defines and uses the EFS volumes with the terraform-aws-ecs-alb-service-task module is not working correctly and the EFS volume is not being set in the resulting task definition. • By separating EFS volumes and Docker volumes they can be assigned to the docker_volumes and efs_volumes as expected by the module.

looking forward to this
what
Creates a separated variable for EFS volumes.
why
• The way terraform-aws-ecs-web-app defines and uses the EFS volumes with the terraform-aws-ecs-alb-service-task module is not working correctly and the EFS volume is not being set in the resulting task definition. • By separating EFS volumes and Docker volumes they can be assigned to the docker_volumes and efs_volumes as expected by the module.