#pr-reviews (2022-08)
Pull Request Reviews for Cloud Posse Projects
2022-08-01
Hey crew, a buddy and I are working on some EKS changes, would love a review on this whenever someone gets a chance: https://github.com/cloudposse/terraform-aws-eks-node-group/pull/126 (needs another reviewer besides me )
If I can get a team member approval from @cloudposse-team that would be appreciated
2022-08-02
2022-08-04
https://github.com/cloudposse/terraform-aws-ssm-tls-self-signed-cert/pull/14 If possible This breaks a number of other modules right now which are dependent on this
Released as v1.0.0
thank you so much for the quick reply
I think vpn module will still fail because version for ssm-tls module is pinned to 0.5 : https://github.com/cloudposse/terraform-aws-ec2-client-vpn/blob/master/main.tf#L25
this release may take about 20 min or so to be added to the registry
excellent, thank you very much !
2022-08-08
Hi all. I think I found a bug in the terraform-aws-ecs-web-app module. EFS volumes are not being correctly set in the resulting task definition by the the terraform-aws-ecs-alb-service-task Draft PR here. Who can I discuss this with? Thanks!
looking forward to this
This PR is ready for review now
I joined this slack to mention that I also encountered this issue, and the PR would be helpful!
thanks for that. and for review?
2022-08-09
2022-08-10
2022-08-16
Hi, can i please get this merged https://github.com/cloudposse/terraform-aws-rds-cluster/pull/149, the required changes have been made and tests have passed. Thanks
2022-08-18
Did I something wrong? I forgot to squash the PR, it’s just added an output…
another PR needs some progress, someone can help? https://github.com/cloudposse/terraform-aws-ec2-instance/pull/117
I can say I see the iops issue with using gp3 and this module all the time in our environment… presents a constant change whenever applied because of it
yes same here, and the suggestions for the pr are not really important, because it will work like this aswell
I fixed the conflicts: https://github.com/cloudposse/terraform-aws-ec2-instance/pull/136
2022-08-19
Could somebody take a look? Cloudflare removed two fields from healthcheck in 3.20. I already commented about bump supported version in required providers
https://github.com/cloudposse/terraform-cloudflare-zone/pull/7
I don’t believe this will work
this is the example from
runtime_platform {
operating_system_family = "WINDOWS_SERVER_2019_CORE"
cpu_architecture = "X86_64"
}
but you added it as a straight input.
it would require a dynamic iirc
and I do not believe you can add multiple runtime platforms, can you ?
2022-08-22
copy of PR with fixed conflicts: https://github.com/cloudposse/terraform-aws-ec2-instance/pull/136
2022-08-26
This does revert the < 4 pin in versions.tf from https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/71
thoughts @Jeremy G (Cloud Posse)?
Yeah, I assumed that was because of the breaking changes in hashicorp/aws v4 that have since been undone
@RB @Andriy Knysh (Cloud Posse) This PR also removes support for provider version 2.x, 3.x, and < 4.27.0. I would like us to be more conservative about dropping support for older version, particularly older 4.x versions. We shall see who complains about this, but I would have allowed the old version 3.x versions and >= 4.9.0 and made a note that http3 support requires >= 4.27.0
@kevcube do you mind making the changes Jeremy is suggesting ?
The PR has already been merged, let’s just wait and see what the community reaction is to it.
2022-08-30
2022-08-31
Hello guys, i have a PR for terraform aws rds cluster @ https://github.com/cloudposse/terraform-aws-rds-cluster/pull/149 .. its approved. Can i please get a ETA when this can be merged? Its a blocker for us. Thank you :)
I can merge this in now @matharoo but this PR isn’t really changing anything other than improving the tests and raising the pin in [versions.tf](http://versions.tf)
Are you sure the PR contains all the changes you expect it to?
yes the main one we are concerned with is the AWS provider, because i fixed the provider to have a rebooting state
You mean the raising of the aws provider version pin in versions.tf ?
Could someone take a look pr pls