#pr-reviews (2022-11)

Pull Request Reviews for Cloud Posse Projects

2022-11-03

Quentin BERTRAND avatar
Quentin BERTRAND

what

• If bucket is encrypted, the user need to have access to KMS key to Get en Put objects into bucket.

why

• Permission needed to put and get objects into encrypted bucket.

2022-11-04

jose.amengual avatar
jose.amengual

what

• Adding instance_metadata_tags • Deleting invalid invalid metadata ipv6 option

why

• To allow the instance to grab its own tags

references

https://registry.terraform.io/providers/hashicorp/aws/4.37.0/docs/resources/instance#instance_metadata_tags

1
1
RB avatar

Commented

what

• Adding instance_metadata_tags • Deleting invalid invalid metadata ipv6 option

why

• To allow the instance to grab its own tags

references

https://registry.terraform.io/providers/hashicorp/aws/4.37.0/docs/resources/instance#instance_metadata_tags

jose.amengual avatar
jose.amengual

commented back

jose.amengual avatar
jose.amengual

lol

RB avatar

what

• Deprecated tags

why

• Use non deprecated tag keys

references

• Closes #85

1
1

2022-11-09

Tommy avatar

what

adding the preserve host header option of the alb like documented here: Terraform registry

why

option was missing

references

• close #123

1
1
David Spedzia avatar
David Spedzia

what

• added timeouts variable (object) to the variables.tf file • added timeouts code block that references the var.timeouts.x variable with default values to the aws_db_instance resource in main.tf • added variable description in the README.md

why

I ran into an issue where using the module in TF Cloud during creation the run times out.
The instance get’s created but due to the run timing out the TF Cloud state does not get updated and each subsequent run would tear down an instance and recreate it, timing out once again.
I added a timeouts variabel with default terraform values, which a user can change if they desire in order to accommodate a longer run.

1
1
1
David Spedzia avatar
David Spedzia

Hi @Matt Gowie I know you’re probably busy, but I was wondering if you could have a look at me PR. It’s a very small change however it is blocking me at the moment. I would really appreciate your help, if not if you could point me in someones direction that could that would be awesome. Again, thanks for all you guys do.

what

• added timeouts variable (object) to the variables.tf file • added timeouts code block that references the var.timeouts.x variable with default values to the aws_db_instance resource in main.tf • added variable description in the README.md

why

I ran into an issue where using the module in TF Cloud during creation the run times out.
The instance get’s created but due to the run timing out the TF Cloud state does not get updated and each subsequent run would tear down an instance and recreate it, timing out once again.
I added a timeouts variabel with default terraform values, which a user can change if they desire in order to accommodate a longer run.

1
Matt Gowie avatar
Matt Gowie

Will check it out @David Spedzia

David Spedzia avatar
David Spedzia

Thanks Matt.

2022-11-10

2022-11-17

Paula avatar
#101 adding force_delete

Hi! im adding “force_delete” parameter, is implemented in aws 4.22.0 for an easier delete of the ecr

references

https://registry.terraform.io/providers/hashicorp/aws/4.22.0/docs/resources/ecr_repository

1
1
    keyboard_arrow_up