SweetOps #pr-reviews for December, 2022

Pull Request Reviews for Cloud Posse Projects

2022-12-08

Frank

08:03:01 AM

Not my PR but can someone review this one https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/238 ?

#238 Add http_version variable

2022-12-13

Nitin

02:28:31 AM

https://github.com/cloudposse/terraform-aws-ecr/pull/98

#98 add optional policy allowing push access

what

• adds the ability to give push-only access to the repository

why

• full access was more than we wanted in our situation (CI pushing images to the repo) so we added a principals_push_access to give push-only access.

references

• policy is based on this AWS doc

Erik Osterman (Cloud Posse)

07:14:22 PM

seems reasonable

#98 add optional policy allowing push access

what

• adds the ability to give push-only access to the repository

why

• full access was more than we wanted in our situation (CI pushing images to the repo) so we added a principals_push_access to give push-only access.

references

• policy is based on this AWS doc

Erik Osterman (Cloud Posse)

07:14:35 PM

@Andriy Knysh (Cloud Posse) or @RB thoughts on this one?

Nitin

02:29:48 AM

https://github.com/cloudposse/terraform-aws-vpc-peering-multi-account/pull/67

#67 IPv6 communication over VPC peering

what

• Allow IPv6 communication b/w VPCs over VPC peering

why