#pr-reviews (2023-06)

what

add xff_header_processing_mode option to alb

why

option is missing

what

Add the ability to add external ENIs to the instance

why

For ec2 instances deployments clusters where the IPs are required to be unique and not change it is necessary to create ENIs outside of this module so that the instance termination does not change the ENI and IP attached.

references

what

Adds a valid key of type string for sns subscriber handler

why

A recent commit adds defaults to subscriber input but also breaks any input on map key type:
image

Proposed fix tested with following input, pulled from cloudposse/terraform-aws-sns-topic:

locals {
  subscribers = {
    opsgenie = {
      protocol = "https"
      endpoint = "<https://api.example.com/v1/>"
      endpoint_auto_confirms = true
    }
  }
}

module "test" {
  source = "../terraform-aws-config"
  # Cloud Posse recommends pinning every module to a specific version
  # version     = "x.x.x"

  create_sns_topic = true
  create_iam_role  = true

  subscribers = local.subscribers
}

thanks

Thank you for these modules!

what

• Introduces using cloudposse s3-bucket module for creating ALB logging bucket • Introducing new variable which defines if s3 logs for ALB is enabled or disabled (default is still true) • Adding random suffix to the name of logging bucket (since names of S3 must be globally unique - very often name provided in module is in collision with some already existed) • If created, S3 bucket for storing ALB access logs is encrypted by default

why

• This module not usable anymore due to deprecation message by terraform about s3 bucket (see #227 ) • Users of this module don’t always need access logs from Load Balancer n S3 bucket

references

• closes #227 • closes #226 • closes #206 • close #152