#pr-reviews (2023-07)
Pull Request Reviews for Cloud Posse Projects
2023-07-01
![Aleksandar Knezevic avatar](https://avatars.slack-edge.com/2021-07-29/2338445254929_ae0580e50070ef9c79b0_72.jpg)
Could someone review this PR please? Thanks
what
• Introduces creation of IAM role for application version cleanup. • Adds support for max_age_in_days
why
• Users should have an option to create an IAM role • Users should have an option to do cleanup based on time
references
2023-07-04
![John Shortland avatar](https://avatars.slack-edge.com/2023-07-02/5541525200528_85246992deb9176a8dd6_72.png)
Can I get a review on this when possible - https://github.com/cloudposse/terraform-aws-s3-website/pull/88
what
• Removes bucket ACL from s3_bucket resource • Adds public access block resource • Adds object ownership control resource
why
• Module no longer works
references
closes #84
![John Shortland avatar](https://avatars.slack-edge.com/2023-07-02/5541525200528_85246992deb9176a8dd6_72.png)
Ran fmt and the readme generation, can some trigger the tests again please?
what
• Removes bucket ACL from s3_bucket resource • Adds public access block resource • Adds object ownership control resource
why
• Module no longer works
references
closes #84
2023-07-09
2023-07-19
![Rin Shoys avatar](https://avatars.slack-edge.com/2023-07-22/5608089366295_f94e98fab4909b88681e_72.jpg)
https://github.com/cloudposse/docs/issues/300
Hi Everyone! I would like to contribute by solving this issue, is there any change in what an onboarding document should contain?
what
• Describe everything a new hire should review
why
• to get started quickly • to get acquainted with tools and techniques needed to perform job
![Gabriela Campana (Cloud Posse) avatar](https://avatars.slack-edge.com/2023-05-17/5281506983315_fbbf3b358313efef4647_72.jpg)
@Erik Osterman (Cloud Posse) is this still relevant?
what
• Describe everything a new hire should review
why
• to get started quickly • to get acquainted with tools and techniques needed to perform job
2023-07-21
![Rin Shoys avatar](https://avatars.slack-edge.com/2023-07-22/5608089366295_f94e98fab4909b88681e_72.jpg)
https://github.com/cloudposse/atmos/issues/412
Submitted an issue about cloudposse/tutorials image (does not support ARM64 architecture)
![attachment image](https://user-images.githubusercontent.com/112838514/255226773-93ec31c3-93ae-4b98-85fd-445800efdd3f.png)
Describe the Bug
I’ve been following this tutorial and the command that’s supposed to pull tutorials image is not working, but instead, gives me an error no matching manifest for linux/arm64/v8 in the manifest list entries
I tried building the image myself with a sudo docker build .
command since I have cloned the repo, and it still gives me an error.
I am using a Mac with M1 chip.
Correct me if I’m wrong here.
Expected Behavior
Image pulls and starts successfully AND image builds and starts successfully
Steps to Reproduce
Go to the atmos getting started tutorial and run this command on M1 chip:
docker run -it \ --rm \ --volume "$HOME":/localhost \ --volume "$PWD":/tutorials \ --name sweetops-tutorials \ cloudposse/tutorials:latest;
Screenshots
Pulling an image ERROR:
image
Building an image locally from a dockerfile ERROR:
image
Environment
No response
Additional Context
This is my first issue ever submitted in an open source community. I treat feedback as a gift and am willing to learn, so don’t hold back and feel free to ask me for help.
A possible solution would be to upload an image that supports both architectures (arm64 and x86) to docker hub.
Thank you!
![Gabriela Campana (Cloud Posse) avatar](https://avatars.slack-edge.com/2023-05-17/5281506983315_fbbf3b358313efef4647_72.jpg)
@Andriy Knysh (Cloud Posse)
![attachment image](https://user-images.githubusercontent.com/112838514/255226773-93ec31c3-93ae-4b98-85fd-445800efdd3f.png)
Describe the Bug
I’ve been following this tutorial and the command that’s supposed to pull tutorials image is not working, but instead, gives me an error no matching manifest for linux/arm64/v8 in the manifest list entries
I tried building the image myself with a sudo docker build .
command since I have cloned the repo, and it still gives me an error.
I am using a Mac with M1 chip.
Correct me if I’m wrong here.
Expected Behavior
Image pulls and starts successfully AND image builds and starts successfully
Steps to Reproduce
Go to the atmos getting started tutorial and run this command on M1 chip:
docker run -it \ --rm \ --volume "$HOME":/localhost \ --volume "$PWD":/tutorials \ --name sweetops-tutorials \ cloudposse/tutorials:latest;
Screenshots
Pulling an image ERROR:
image
Building an image locally from a dockerfile ERROR:
image
Environment
No response
Additional Context
This is my first issue ever submitted in an open source community. I treat feedback as a gift and am willing to learn, so don’t hold back and feel free to ask me for help.
A possible solution would be to upload an image that supports both architectures (arm64 and x86) to docker hub.
Thank you!
2023-07-24
![Dominique Dumont avatar](https://secure.gravatar.com/avatar/9e38bdc03b92a7452e7115356908c752.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0005-72.png)
Hi. Could someone review this PR ? https://github.com/cloudposse/terraform-aws-tfstate-backend/pull/142
what
This parameter allows the user to specify policies that are applied to the S3 bucket with the policies defined by this module.
why
We want to add policies that forbid non admin users to access the bucket containing tfstates.
This commit allow us to specify a policy that implement these restriction without clobbering the policies put in place by this module.
Note that I have no problem to change the name of this new parameter if you want another.
references
Closes: #115
![Jeremy G (Cloud Posse) avatar](https://avatars.slack-edge.com/2020-07-04/1229022582372_22757dbc9ef96d371614_72.jpg)
We were hoping to overhaul this module by now, which would have included this feature and more, but obviously we have not gotten to it yet.
I requested changes via the PR.
what
This parameter allows the user to specify policies that are applied to the S3 bucket with the policies defined by this module.
why
We want to add policies that forbid non admin users to access the bucket containing tfstates.
This commit allow us to specify a policy that implement these restriction without clobbering the policies put in place by this module.
Note that I have no problem to change the name of this new parameter if you want another.
references
Closes: #115
![Dominique Dumont avatar](https://secure.gravatar.com/avatar/9e38bdc03b92a7452e7115356908c752.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0005-72.png)
Hi, I’ve pushed the requested changes. Could you resume the review ?
![Paula avatar](https://avatars.slack-edge.com/2022-09-13/4070142320726_24f91e7b54e97b142967_72.jpg)
Hi! im sending a PR not sure if it’s aligned with the essence of the module https://github.com/cloudposse/terraform-aws-ecs-codepipeline/pull/116
![Rin Shoys avatar](https://avatars.slack-edge.com/2023-07-22/5608089366295_f94e98fab4909b88681e_72.jpg)
Hi! A PR regarding the cloudposse/tutorials image bug: https://github.com/cloudposse/tutorials/pull/22#partial-pull-merging
![Gabriela Campana (Cloud Posse) avatar](https://avatars.slack-edge.com/2023-05-17/5281506983315_fbbf3b358313efef4647_72.jpg)
@Max Lobur (Cloud Posse)