#pr-reviews (2023-07)

what

• Introduces creation of IAM role for application version cleanup. • Adds support for max_age_in_days

why

• Users should have an option to create an IAM role • Users should have an option to do cleanup based on time

references

• closes #43 • closes #34

what

• Removes bucket ACL from s3_bucket resource • Adds public access block resource • Adds object ownership control resource

why

• Module no longer works

references

closes #84

what

• Describe everything a new hire should review

why

• to get started quickly • to get acquainted with tools and techniques needed to perform job

Describe the Bug

I’ve been following this tutorial and the command that’s supposed to pull tutorials image is not working, but instead, gives me an error no matching manifest for linux/arm64/v8 in the manifest list entries

I tried building the image myself with a sudo docker build . command since I have cloned the repo, and it still gives me an error.

I am using a Mac with M1 chip.

Correct me if I’m wrong here.

Expected Behavior

Image pulls and starts successfully AND image builds and starts successfully

Steps to Reproduce

Go to the atmos getting started tutorial and run this command on M1 chip:

docker run -it \ --rm \ --volume "$HOME":/localhost \ --volume "$PWD":/tutorials \ --name sweetops-tutorials \ cloudposse/tutorials:latest;

Screenshots

Pulling an image ERROR:
image

Building an image locally from a dockerfile ERROR:
image

Environment

No response

Additional Context

This is my first issue ever submitted in an open source community. I treat feedback as a gift and am willing to learn, so don’t hold back and feel free to ask me for help.

A possible solution would be to upload an image that supports both architectures (arm64 and x86) to docker hub.

Thank you!

what

This parameter allows the user to specify policies that are applied to the S3 bucket with the policies defined by this module.

why

We want to add policies that forbid non admin users to access the bucket containing tfstates.

This commit allow us to specify a policy that implement these restriction without clobbering the policies put in place by this module.

Note that I have no problem to change the name of this new parameter if you want another.

references

Closes: #115