Pull Request Reviews for Cloud Posse Projects
Hi, can someone review this PR please? https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/166
please rebuild the readme, but otherwise looks good
permission restrications for lambda only
what why references
• When you’re using external sg with setting
create_security_group = false and don’t want to create default one which is included in module you get response with nullable element and can’t concatenate null values.
│ Error: Invalid function argument │ │ on .terraform/modules/elasticache_memcached/outputs.tf line 12, in output "security_group_arn": │ 12: value = join("", module.aws_security_group[*].arn) │ ├──────────────── │ │ while calling join(separator, lists...) │ │ module.aws_security_group is object with 4 attributes │ │ Invalid value for "lists" parameter: element 0 is null; cannot concatenate null values.
Going to re-request a review on https://sweetops.slack.com/archives/CUJPCP1K6/p1690182346767379, my org needs this too.
Hi. Could someone review this PR ? https://github.com/cloudposse/terraform-aws-tfstate-backend/pull/142
We were hoping to overhaul this module by now, which would have included this feature and more, but obviously we have not gotten to it yet.
I requested changes via the PR.
I’ve updated this PR to address all the comments. I hope it will be reviewed soon.
Hello there, I’ve (finally) fixed that PR; https://github.com/cloudposse/terraform-aws-nlb/pull/33
@Igor Rodionov @Dan Miller (Cloud Posse)