SweetOps #pr-reviews for August, 2023

• When you’re using external sg with setting create_security_group = false and don’t want to create default one which is included in module you get response with nullable element and can’t concatenate null values.

│ Error: Invalid function argument
│ 
│   on .terraform/modules/elasticache_memcached/outputs.tf line 12, in output "security_group_arn":
│   12:   value       = join("", module.aws_security_group[*].arn)
│     ├────────────────
│     │ while calling join(separator, lists...)
│     │ module.aws_security_group is object with 4 attributes
│ 
│ Invalid value for "lists" parameter: element 0 is null; cannot concatenate null values.

mbarrien

04:54:51 PM

Going to re-request a review on https://sweetops.slack.com/archives/CUJPCP1K6/p1690182346767379, my org needs this too.

Hi. Could someone review this PR ? https://github.com/cloudposse/terraform-aws-tfstate-backend/pull/142

Jeremy G (Cloud Posse)

06:53:52 PM

https://sweetops.slack.com/archives/CUJPCP1K6/p1692903125317489?thread_ts=1690182346.767379&cid=CUJPCP1K6

We were hoping to overhaul this module by now, which would have included this feature and more, but obviously we have not gotten to it yet.

I requested changes via the PR.

Dominique Dumont

10:42:19 AM

I’ve updated this PR to address all the comments. I hope it will be reviewed soon.

Jeremy G (Cloud Posse)

07:57:49 PM

@Dominique Dumont This is failing the Terratest. I’m not sure why, something to do with order of operations or waiting. You can compare with our s3-bucket module. It might be a while before I get to look into this further.

│ Error: creating S3 Bucket (<bucket name>) Versioning: operation error S3: PutBucketVersioning, https response error StatusCode: 409, RequestID: 05DHXWG91G2TNQ1Z, HostID: 68w0sDw58YSsDXCrVGYO9VYCJf3laQ0qZevy8seqI0vLOhF/96W+6jstaTFTBqusmEKVd0vul5FUDFQHR1FpdQ==, api error OperationAborted: A conflicting conditional operation is currently in progress against this resource. Please try again.
│ 
│   with module.tfstate_backend.aws_s3_bucket_versioning.default[0],
│   on ../../main.tf line 190, in resource "aws_s3_bucket_versioning" "default":
│  190: resource "aws_s3_bucket_versioning" "default" {

cloudposse/terraform-aws-s3-bucket

Terraform module that creates an S3 bucket with an optional IAM user for external CI/CD systems

Dominique Dumont

06:44:10 AM

Thanks for the notice. I’ll look into this next week.

Dominique Dumont

07:05:13 AM

@Jeremy G (Cloud Posse) This test is now marked as successful. I guess this was a temporary failure. Could you approve this PR ?