#pr-reviews (2023-08)

what

• Add optional variable name to portMappings to allow Service Discovery registration

why

• Unable to allow ECS container definitions to register with Service Discovery

references

• closes #162

what

• Add the ability to have organizations as trustees (read-only) for the ECR repository

why

• As described in #82 , it’s sometimes useful to allow an entire organization to consume images from a centralized repository

references

• closes #82

permission restrications for lambda only

what why references

what

• When you’re using external sg with setting create_security_group = false and don’t want to create default one which is included in module you get response with nullable element and can’t concatenate null values.

│ Error: Invalid function argument
│ 
│   on .terraform/modules/elasticache_memcached/outputs.tf line 12, in output "security_group_arn":
│   12:   value       = join("", module.aws_security_group[*].arn)
│     ├────────────────
│     │ while calling join(separator, lists...)
│     │ module.aws_security_group is object with 4 attributes
│ 
│ Invalid value for "lists" parameter: element 0 is null; cannot concatenate null values.

Hi. Could someone review this PR ? https://github.com/cloudposse/terraform-aws-tfstate-backend/pull/142

what

Add option to not create default target group

why

Default target group can be useless.

references

#22

I guess it will need a procedure migration of state is this PR is accepted.