#pr-reviews (2023-11)

what

Add support for Child OUs

why

AWS well-architected framework recommends the creation of at least one level of Child OUs.

references

https://docs.aws.amazon.com/whitepapers/latest/organizing-your-aws-environment/workloads-ou.html

what

• add new provider features to datadog monitors

why

• we needed to use some of these, so while reviewing the datadog_monitor documentation I decided to make all of them available.

references

• https://registry.terraform.io/providers/DataDog/datadog/3.21.0/docs/resources/monitor

what

• Add redis family suffix to parameter group name • Add new variable parameter_group_name

why

This module doesn’t currently support major version upgrades of Redis (eg, 6.x to. 7.x) because:

• Parameter groups are major-version specific, so when a user changes var.family from redis6 to redis7, Terraform needs to create a new parameter group. Without create_before_destroy, Terraform tries to first destroy the old Param group which fails because it’s currently in use • Parameter groups must have unique names across families. When Terraform tries to create a new param group for redis7, it fails because it tries to do so using the same name as the old param group.

I have decided to add “redis cluster family” as a suffix. AWS follows a similar convention for default parameter groups, using names such as:

• default.redis6.x • default.redis7

Since using . is not possible, I have opted to use - instead.

To prevent any breaking changes, I have introduced a new variable called parameter_group_name. By setting this variable to the current parameter group name, you can prevent any terraform configuration drift.

references

Resolves #178

I see that other people tried to solve this problem before (see references), but the pull requests were not merged yet:

• #159 • #189 • #201