#pr-reviews (2024-01)

Pull Request Reviews for Cloud Posse Projects

2024-01-29

Quentin BERTRAND avatar
Quentin BERTRAND
04:20:48 PM

Hello, Here is a PR to add security groups options to NLB module https://github.com/cloudposse/terraform-aws-nlb/pull/53

#53 Feat: add security groups options

what

Add security groups options

why

We can associate NLB with security groups (only at NLB creation)

references

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb#security_groups

1
Quentin BERTRAND avatar
Quentin BERTRAND
02:48:12 PM

#53 Feat: add security groups options

what

Add security groups options

why

We can associate NLB with security groups (only at NLB creation)

references

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb#security_groups

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)
03:17:44 PM

@Gabriela Campana (Cloud Posse)

1
Gabriela Campana (Cloud Posse) avatar
Gabriela Campana (Cloud Posse)
04:51:10 PM

@Quentin BERTRAND Andriy just merged https://github.com/cloudposse/terraform-aws-nlb/pull/53

#53 Feat: add security groups options

what

Add security groups options

why

We can associate NLB with security groups (only at NLB creation)

references

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb#security_groups

Quentin BERTRAND avatar
Quentin BERTRAND
08:23:19 PM

Thank you

np1
    keyboard_arrow_up