#pr-reviews (2024-01)
Pull Request Reviews for Cloud Posse Projects
2024-01-29
![Quentin BERTRAND avatar](https://avatars.slack-edge.com/2022-08-29/4028696878592_774493d7ba3d4c45009e_72.jpg)
Hello, Here is a PR to add security groups options to NLB module https://github.com/cloudposse/terraform-aws-nlb/pull/53
what
Add security groups options
why
We can associate NLB with security groups (only at NLB creation)
references
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb#security_groups
![Quentin BERTRAND avatar](https://avatars.slack-edge.com/2022-08-29/4028696878592_774493d7ba3d4c45009e_72.jpg)
what
Add security groups options
why
We can associate NLB with security groups (only at NLB creation)
references
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb#security_groups
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
![Gabriela Campana (Cloud Posse) avatar](https://avatars.slack-edge.com/2023-05-17/5281506983315_fbbf3b358313efef4647_72.jpg)
@Quentin BERTRAND Andriy just merged https://github.com/cloudposse/terraform-aws-nlb/pull/53
what
Add security groups options
why
We can associate NLB with security groups (only at NLB creation)
references
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb#security_groups
![Quentin BERTRAND avatar](https://avatars.slack-edge.com/2022-08-29/4028696878592_774493d7ba3d4c45009e_72.jpg)