#pr-reviews (2024-03)

Pull Request Reviews for Cloud Posse Projects

2024-03-01

Hamza avatar
#156 feature: Add support for deletion_protection_enabled attribute for DynamoDB

what

This PR add support for the attribute deletion_protection_enabled in the DynamoDB ressource

why

To address an issue #143
To present or force DynamoDB table deletion

references

To address an issue #143
https://aws.amazon.com/about-aws/whats-new/2023/03/amazon-dynamodb-table-deletion-protection/

1
1
Hamza avatar

make init works but when I run make readme it gives: make: *** No rule to make target readme. Stop any idea ?

#156 feature: Add support for deletion_protection_enabled attribute for DynamoDB

what

This PR add support for the attribute deletion_protection_enabled in the DynamoDB ressource

why

To address an issue #143
To present or force DynamoDB table deletion

references

To address an issue #143
https://aws.amazon.com/about-aws/whats-new/2023/03/amazon-dynamodb-table-deletion-protection/

Hans D avatar

just encountered this myself in a different repo. just do make and make readme

Hans D avatar

(needs some further investiagtion)

Hamza avatar

again make works but make readme doesn’t , same issue, just to confirm I’m not doing something wrong, I’m running these commands in a terminal in the same level as Makefile

Hans D avatar

working on this bit - it annoys us bigtime as well

1

2024-03-02

Hans D avatar

As some might have notices, some cleanup re very stale PRs have been done - PRs with outstanding merge conflicts for quite some time have been closed. At the same time, some PRs that were passing the final tests and were easy to review have been processed. If there are PRs you would like to see get merged, feel free to re-open them - but be sure to give them the tlc needed (make them mergeable / pass all tests etc.)

2
Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

Thanks @Hans D for that relentless effort!

10002
Hans D avatar
Hans D
01:09:08 AM

cleaning

1

2024-03-03

2024-03-04

2024-03-18

Alexander Pankratiev avatar
Alexander Pankratiev
#300 Do not create ACL resource if Bucket Owner Enforced

what

Do not create acl resource when s3_object_ownership=BucketOwnerEnforced

why

ACL is not allowed when object ownership is BucketOwnerEnforced

https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html

references

closes #299

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@Gabriela Campana (Cloud Posse)

#300 Do not create ACL resource if Bucket Owner Enforced

what

Do not create acl resource when s3_object_ownership=BucketOwnerEnforced

why

ACL is not allowed when object ownership is BucketOwnerEnforced

https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html

references

closes #299

1
Gabriela Campana (Cloud Posse) avatar
Gabriela Campana (Cloud Posse)

@Erik Osterman (Cloud Posse) The bug is already fixed within #301

1
Gabriela Campana (Cloud Posse) avatar
Gabriela Campana (Cloud Posse)

And #300 is already closed

2024-03-22

Moritz avatar

Simple PR to extend custom origins with realtime_log_config_arn : https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/295

#295 Add support for realtime log config to ordered_cache

what

This PR adds realtime log config support for additional cache behaviours (Similar to #162 which added default cache behaviour)

references

#162 - Added realtime_log_config_arn for default cache behaviour

1
Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@Gabriela Campana (Cloud Posse)

#295 Add support for realtime log config to ordered_cache

what

This PR adds realtime log config support for additional cache behaviours (Similar to #162 which added default cache behaviour)

references

#162 - Added realtime_log_config_arn for default cache behaviour

1
Gabriela Campana (Cloud Posse) avatar
Gabriela Campana (Cloud Posse)

@Moritz approved

Moritz avatar

thx

Moritz avatar

can you merge it?

Moritz avatar

rebased/updated docs as requested

Gabriela Campana (Cloud Posse) avatar
Gabriela Campana (Cloud Posse)

@Ben Smith (Cloud Posse)

Ben Smith (Cloud Posse) avatar
Ben Smith (Cloud Posse)

Merged!

2

2024-03-24

2024-03-25

2024-03-26

2024-03-27

Quentin BERTRAND avatar
Quentin BERTRAND

Hello! fix: enabled input for NLB resource https://github.com/cloudposse/terraform-aws-nlb/pull/59

#59 fix: enabled input for NLB resource

• Add a conditional check for module enabling in the aws_lb resource count

what

#52
enabled input not set on nlb resource. Adding it.

~~it will be a breaking change. Resource aws_lb.default will become aws_lb.default[0] in state.~~erraform will rename the resource in state;

Terraform will perform the following actions:

  # aws_lb.default has moved to aws_lb.default[0]
    resource "aws_lb" "default" {
        id                               = "arn:aws:elasticloadbalancing:ap-southeast-2:123456789012:loadbalancer/net/nlb/1234567890123456"
        name                             = "nlb"
        tags                             = {
            "Name" = "nlb"
        }
        # (14 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 0 to change, 0 to destroy.

why

Usefull feature.

references

#52

1
Dan Miller (Cloud Posse) avatar
Dan Miller (Cloud Posse)

approved and merged. thanks for the contribution!

#59 fix: enabled input for NLB resource

• Add a conditional check for module enabling in the aws_lb resource count

what

#52
enabled input not set on nlb resource. Adding it.

~~~it will be a breaking change. Resource aws_lb.default will become aws_lb.default[0] in state.~~~rraform will rename the resource in state;

Terraform will perform the following actions:

  # aws_lb.default has moved to aws_lb.default[0]
    resource "aws_lb" "default" {
        id                               = "arn:aws:elasticloadbalancing:ap-southeast-2:123456789012:loadbalancer/net/nlb/1234567890123456"
        name                             = "nlb"
        tags                             = {
            "Name" = "nlb"
        }
        # (14 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 0 to change, 0 to destroy.

why

Usefull feature.

references

#52

1
sweetops1
    keyboard_arrow_up