SweetOps #pr-reviews for March, 2024

again make works but make readme doesn’t , same issue, just to confirm I’m not doing something wrong, I’m running these commands in a terminal in the same level as Makefile

Hans D

08:53:56 AM

working on this bit - it annoys us bigtime as well

2024-03-02

Hans D

10:24:10 PM

As some might have notices, some cleanup re very stale PRs have been done - PRs with outstanding merge conflicts for quite some time have been closed. At the same time, some PRs that were passing the final tests and were easy to review have been processed. If there are PRs you would like to see get merged, feel free to re-open them - but be sure to give them the tlc needed (make them mergeable / pass all tests etc.)

Erik Osterman (Cloud Posse)

12:46:52 AM

Thanks @Hans D for that relentless effort!

Hans D

01:09:08 AM

cleaning

2024-03-03

2024-03-04

2024-03-18

Alexander Pankratiev

01:51:07 PM

https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/300

#300 Do not create ACL resource if Bucket Owner Enforced

what

Do not create acl resource when s3_object_ownership=BucketOwnerEnforced

why

ACL is not allowed when object ownership is BucketOwnerEnforced

https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html

references

closes #299

Erik Osterman (Cloud Posse)

06:55:04 AM

@Gabriela Campana (Cloud Posse)

#300 Do not create ACL resource if Bucket Owner Enforced

what

Do not create acl resource when s3_object_ownership=BucketOwnerEnforced

why

ACL is not allowed when object ownership is BucketOwnerEnforced

https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html

references

closes #299

Gabriela Campana (Cloud Posse)

04:16:57 PM

@Erik Osterman (Cloud Posse) The bug is already fixed within #301

Gabriela Campana (Cloud Posse)

04:17:22 PM

And #300 is already closed

2024-03-22

Moritz

11:30:53 AM

Simple PR to extend custom origins with realtime_log_config_arn : https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/295

#295 Add support for realtime log config to ordered_cache

what

This PR adds realtime log config support for additional cache behaviours (Similar to #162 which added default cache behaviour)

references

#162 - Added realtime_log_config_arn for default cache behaviour

Erik Osterman (Cloud Posse)

06:54:50 AM

@Gabriela Campana (Cloud Posse)

#295 Add support for realtime log config to ordered_cache

what

This PR adds realtime log config support for additional cache behaviours (Similar to #162 which added default cache behaviour)

references

#162 - Added realtime_log_config_arn for default cache behaviour

Gabriela Campana (Cloud Posse)

05:29:19 PM

@Moritz approved

Moritz

06:35:32 PM

thx

Moritz

06:36:20 PM

can you merge it?

Moritz

03:59:52 PM

rebased/updated docs as requested

Gabriela Campana (Cloud Posse)

05:36:08 PM

@Ben Smith (Cloud Posse)

Ben Smith (Cloud Posse)

05:48:12 PM

Merged!

2024-03-24

2024-03-25

2024-03-26

2024-03-27

Quentin BERTRAND

02:28:14 PM

Hello! fix: enabled input for NLB resource https://github.com/cloudposse/terraform-aws-nlb/pull/59

#59 fix: enabled input for NLB resource

• Add a conditional check for module enabling in the aws_lb resource count

what

#52
enabled input not set on nlb resource. Adding it.

~~~~it will be a breaking change. Resource aws_lb.default will become aws_lb.default[0] in state.~~~~erraform will rename the resource in state;

Terraform will perform the following actions:

  # aws_lb.default has moved to aws_lb.default[0]
    resource "aws_lb" "default" {
        id                               = "arn:aws:elasticloadbalancing:ap-southeast-2:123456789012:loadbalancer/net/nlb/1234567890123456"
        name                             = "nlb"
        tags                             = {
            "Name" = "nlb"
        }
        # (14 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 0 to change, 0 to destroy.

why

Usefull feature.

references

#52

Dan Miller (Cloud Posse)

06:04:08 PM

approved and merged. thanks for the contribution!

#59 fix: enabled input for NLB resource

• Add a conditional check for module enabling in the aws_lb resource count

what

#52
enabled input not set on nlb resource. Adding it.

~~~~~it will be a breaking change. Resource aws_lb.default will become aws_lb.default[0] in state.~~~~~rraform will rename the resource in state;

Terraform will perform the following actions:

  # aws_lb.default has moved to aws_lb.default[0]
    resource "aws_lb" "default" {
        id                               = "arn:aws:elasticloadbalancing:ap-southeast-2:123456789012:loadbalancer/net/nlb/1234567890123456"
        name                             = "nlb"
        tags                             = {
            "Name" = "nlb"
        }
        # (14 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 0 to change, 0 to destroy.

why

Usefull feature.

references

#52