SweetOps #pr-reviews for September, 2024

Support to tune the throughput of the ebs volumes was added to the autoscaling group module in version 0.37.1. As it is not defined in the option block here its not passed through during an execution.

references

Release notes for 0.37.1 of cloudposse/terraform-aws-ec2-autoscale-group

Closes #52

Gabriela Campana (Cloud Posse)

04:10:26 PM

@Ben Smith (Cloud Posse)

#53 feat: add throughput option to block_device_mappings

what

This change adds the through put option to the ebs block_device_mappints object in the capacity_providers_fargate_ec2 variable

why

references

Release notes for 0.37.1 of cloudposse/terraform-aws-ec2-autoscale-group

Closes #52

Gabriela Campana (Cloud Posse)

02:05:30 PM

@Igor Rodionov

Callum

02:30:13 PM

I guess these got pulled in during the merge from main, I’ve updated them regardless as its a trivial update

Gabriela Campana (Cloud Posse)

04:24:33 PM

@Ben Smith (Cloud Posse) @Igor Rodionov bumping this up

Callum

08:09:07 AM

Is there a step I have missed here? Looks like the terratest has not completed but I am not sure why

Gabriela Campana (Cloud Posse)

02:28:38 PM

Merged. These changes were released in v0.7.0.

Callum

02:29:25 PM

Amazing thanks

2024-09-08

Nitin

04:44:08 AM

https://github.com/cloudposse/terraform-aws-rds-cluster/pull/231

#231 Dual stack support

what

RDS cluster can be run in two network modes - IPV4 or DUAL.
Underlying module already supports this parameter

why

It can be mandatory to enable it to be able to connect from ipv6 only runtimes

references

Closes #175

2024-09-09

2024-09-10

2024-09-11

Nitin

01:24:22 PM

https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/245

#245 Allow config endpoint as reader endpoint output

what

This avoids a situation where the reader endpoint tries to use coalesce(null, null, null) when in cluster mode and instead uses the configuration endpoint.

why

When using cluster mode there is no reader endpoint so the output tries to use coalesce(null, null, null) which results in a plan error. As outlined in the AWS docs the config endpoint should be used instead when in cluster mode.

references

Closes #236

Gabriela Campana (Cloud Posse)

07:00:03 PM

@Ben Smith (Cloud Posse) @Igor Rodionov

#245 Allow config endpoint as reader endpoint output

what

This avoids a situation where the reader endpoint tries to use coalesce(null, null, null) when in cluster mode and instead uses the configuration endpoint.

why

references

Closes #236

Nitin

03:30:17 AM

Can someone run the terratest again on following PR

Nitin

03:31:41 AM

Error: reading Route 53 Hosted Zone (Z04545531TH4B1BZM9PY8): couldn’t find resource https://github.com/cloudposse/terraform-aws-elasticache-redis/actions/runs/10830359174/job/30049986131#step<i class="em em-12"1099 │ https://github.com/cloudposse/terraform-aws-elasticache-redis/actions/runs/10830359174/job/30049986131#step<i class="em em-12"1100 │ with module.redis.module.dns.aws_route53_record.default[0], https://github.com/cloudposse/terraform-aws-elasticache-redis/actions/runs/10830359174/job/30049986131#step<i class="em em-12"1101 │ on .terraform/modules/redis.dns/main.tf line 15, in resource “aws_route53_record” “default”: https://github.com/cloudposse/terraform-aws-elasticache-redis/actions/runs/10830359174/job/30049986131#step<i class="em em-12"1102 │ 15: resource “aws_route53_record” “default” { https://github.com/cloudposse/terraform-aws-elasticache-redis/actions/runs/10830359174/job/30049986131#step<i class="em em-12"1103 │ https://github.com/cloudposse/terraform-aws-elasticache-redis/actions/runs/10830359174/job/30049986131#step<i class="em em-12"1104 ╵}