#pr-reviews (2024-09)
Pull Request Reviews for Cloud Posse Projects
2024-09-03
2024-09-05
PR to enable the dualstack support in the RDS
https://github.com/cloudposse/terraform-aws-rds-cluster/pull/231
@Ben Smith (Cloud Posse)
@Ben Smith (Cloud Posse) PR is passed. can you please check now
Merged
2024-09-06
PR to add the throughput variable for block device tuning on ecs clusters https://github.com/cloudposse/terraform-aws-ecs-cluster/pull/53
@Ben Smith (Cloud Posse)
@Igor Rodionov
I guess these got pulled in during the merge from main, I’ve updated them regardless as its a trivial update
@Ben Smith (Cloud Posse) @Igor Rodionov bumping this up
Is there a step I have missed here? Looks like the terratest has not completed but I am not sure why
Merged. These changes were released in v0.7.0.
2024-09-09
2024-09-10
2024-09-11
@Ben Smith (Cloud Posse) @Igor Rodionov
Can someone run the terratest again on following PR
Error: reading Route 53 Hosted Zone (Z04545531TH4B1BZM9PY8): couldn’t find resource https://github.com/cloudposse/terraform-aws-elasticache-redis/actions/runs/10830359174/job/30049986131#step<i class="em em-12"1099 │ https://github.com/cloudposse/terraform-aws-elasticache-redis/actions/runs/10830359174/job/30049986131#step<i class="em em-12"1100 │ with module.redis.module.dns.aws_route53_record.default[0], https://github.com/cloudposse/terraform-aws-elasticache-redis/actions/runs/10830359174/job/30049986131#step<i class="em em-12"1101 │ on .terraform/modules/redis.dns/main.tf line 15, in resource “aws_route53_record” “default”: https://github.com/cloudposse/terraform-aws-elasticache-redis/actions/runs/10830359174/job/30049986131#step<i class="em em-12"1102 │ 15: resource “aws_route53_record” “default” { https://github.com/cloudposse/terraform-aws-elasticache-redis/actions/runs/10830359174/job/30049986131#step<i class="em em-12"1103 │ https://github.com/cloudposse/terraform-aws-elasticache-redis/actions/runs/10830359174/job/30049986131#step<i class="em em-12"1104 ╵}
@Ben Smith (Cloud Posse) @Igor Rodionov
@Igor Rodionov is this due to a missing zone in the new test account maybe?
Nitin, we are chasing this internally and will get back to you asap
@Nitinthat merged. The problem was because we had to update the PR base branch.
2024-09-12
2024-09-13
2024-09-14
@Nitin it seems to be failing Terratest
@Gabriela Campana (Cloud Posse) i checked. but this error not with the changes of my code.. can you help me with it.?
@Igor Rodionov is this a test failing due to opentofu / terraform concurrency?
Nitin, we are chasing this internally and will get back to you asap
@Igor Rodionov bumping this up
2024-09-16
2024-09-17
2024-09-18
@Erik Osterman (Cloud Posse) terratest is passed.
@Gabriela Campana (Cloud Posse) can you please assign someone for approval and merge
@Andriy Knysh (Cloud Posse)
@Igor Rodionov
Merged
These changes were released in v0.19.4.
@Gabriela Campana (Cloud Posse) https://github.com/cloudposse/terraform-aws-elasticache-memcached/issues/55
@Igor Rodionov
@Igor Rodionov @Ben Smith (Cloud Posse)