#pr-reviews (2024-12)

Pull Request Reviews for Cloud Posse Projects

2024-12-02

Bob Berg avatar
Bob Berg
03:11:48 PM

https://github.com/cloudposse/terraform-datadog-platform/pull/109

An update to Terraform Datadog Platform. Adding a field that was previously excluded, resulting in only the default value being used.

1
Dan Miller (Cloud Posse) avatar
Dan Miller (Cloud Posse)
04:32:32 PM

merged. thanks for the contribution!

Dan Miller (Cloud Posse) avatar
Dan Miller (Cloud Posse)
04:36:29 PM

released with version v1.5.0 https://github.com/cloudposse/terraform-datadog-platform/releases/tag/v1.5.0

Bob Berg avatar
Bob Berg
07:54:48 PM

Terrific! I was able to successfully use elementsoperator while provisioning Multi-Step Synthetics Tests. Thanks a bunch!

np1

2024-12-04

2024-12-05

2024-12-06

2024-12-07

Jeremy G (Cloud Posse) avatar
Jeremy G (Cloud Posse)
11:49:04 PM

@Ray Finch @Yangci Ou @mihai.plesa As I am working on the RDS cluster module (see previous thread), I’m looking over other open PRs. Does PR 230 look correct to you? In my understanding, db_cluster_instance_class would never be relevant.

#230 Only set db_cluster_instance_class on the secondary cluster when local.is_serverless is false

what

Only set db_cluster_instance_class to non-null on the secondary cluster when local.is_serverless=false.

why

The missing serverlessv2_scaling_configuration on the secondary cluster was added in #181. The argument db_cluster_instance_class should also be aligned with the primary cluster.

Yangci Ou avatar
Yangci Ou
04:54:14 AM

I haven’t worked with serverless RDS but it looks correct because the instance class isn’t relevant when using serverless

#230 Only set db_cluster_instance_class on the secondary cluster when local.is_serverless is false

what

Only set db_cluster_instance_class to non-null on the secondary cluster when local.is_serverless=false.

why

The missing serverlessv2_scaling_configuration on the secondary cluster was added in #181. The argument db_cluster_instance_class should also be aligned with the primary cluster.

Jeremy G (Cloud Posse) avatar
Jeremy G (Cloud Posse)
05:49:27 AM

I decided to allow it, because it gives control to the user. They can set it if they want, or leave it empty (the default).

1
1
1
1

2024-12-09

Josh Simmonds avatar
Josh Simmonds
06:44:53 PM

wave We have a small bug fix for the aws-dynamic-subnets module (cc @John Seekins) we’d love to get merged in to unblock some work we’re doing: https://github.com/cloudposse/terraform-aws-dynamic-subnets/pull/217

#217 Allow for selectively disabling IPv6 addresses

what

Allow for selectively disabling IPv6 addresses

why

We don’t want IPv6 addresses in our private subnets, only public subnets. This PR lets that happen.

references

2024-12-10

2024-12-11

2024-12-12

Josh Simmonds avatar
Josh Simmonds
08:18:12 PM

https://github.com/cloudposse/atmos/pull/849 – Minor change to the json being written to have greater support with existing end-of-file linters/pre-commit hooks (eg https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/end_of_file_fixer.py)

1

2024-12-13

2024-12-18

Michael avatar
Michael
10:35:58 PM

Some of our TFLint workflows and pre-commit hooks throw an error because of the Terraform 0.12 legacy dot index syntax (splat operator). This is a minor PR that cleans up the legacy splat operator in the eks/reloader component (https://github.com/cloudposse-terraform-components/aws-eks-reloader/pull/10)

#10 fix: update legacy splat operator

what

• Replace the legacy “attribute-only” splat expressions which use the sequence .* with the newer expression[*]

why

Earlier versions of the Terraform language had a slightly different version of splat expressions, which Terraform continues to support for backward compatibility. This older variant is less useful than the modern form described above, and so Hashicorp recommends against using it in new configurations.

references

• Splat Expressions

Summary by CodeRabbit

• Bug Fixes
• Updated the configuration for accessing Kubernetes namespace IDs to improve accuracy.

Gabriela Campana (Cloud Posse) avatar
Gabriela Campana (Cloud Posse)
04:48:03 PM

@Igor Rodionov

#10 fix: update legacy splat operator

what

• Replace the legacy “attribute-only” splat expressions which use the sequence .* with the newer expression[*]

why

Earlier versions of the Terraform language had a slightly different version of splat expressions, which Terraform continues to support for backward compatibility. This older variant is less useful than the modern form described above, and so Hashicorp recommends against using it in new configurations.

references

• Splat Expressions

Summary by CodeRabbit

• Bug Fixes
• Updated the configuration for accessing Kubernetes namespace IDs to improve accuracy.

2024-12-19

Sushmitha Kumar avatar
Sushmitha Kumar
12:20:43 PM

Hi #pr-reviews, I’ve updated our Terraform code to replace deprecated splat expressions used in version 0.12.0, aligning it with the 0.12.0+ format. Could someone please review the PR and share feedback? Your input will ensure we maintain compatibility and best practices. here is the PR : https://github.com/cloudposse-terraform-components/aws-aurora-postgres/pull/12 . Thanks in advance !

#12 MSSCI-5439 fix: Replace deprecated splat expression with [*] for Terr…

Terraform 0.12.0+ Splat Operator Updates

What

Updated Terraform configuration to replace legacy splat syntax

(resource.*.attribute)

with modern bracket-based expressions (resource[*].attribute).
Incorporated for expressions where applicable to improve flexibility and readability.
No functional changes to infrastructure; these updates are syntax improvements.

Why

Aligns with Terraform 0.12.0+ enhancements and first-class expression support.
Improves readability and maintainability of Terraform code.
Prevents potential deprecation warnings by replacing outdated syntax.

References

Terraform v0.12.0 Upgrade Guide

Summary by CodeRabbit

• Bug Fixes
• Updated the syntax for accessing the IAM policy document, improving clarity and correctness.

Gabriela Campana (Cloud Posse) avatar
Gabriela Campana (Cloud Posse)
04:48:40 PM

@Igor Rodionov

#12 MSSCI-5439 fix: Replace deprecated splat expression with [*] for Terr…

Terraform 0.12.0+ Splat Operator Updates

What

Updated Terraform configuration to replace legacy splat syntax

(resource.*.attribute)

with modern bracket-based expressions (resource[*].attribute).
Incorporated for expressions where applicable to improve flexibility and readability.
No functional changes to infrastructure; these updates are syntax improvements.

Why

Aligns with Terraform 0.12.0+ enhancements and first-class expression support.
Improves readability and maintainability of Terraform code.
Prevents potential deprecation warnings by replacing outdated syntax.

References

Terraform v0.12.0 Upgrade Guide

Summary by CodeRabbit

• Bug Fixes
• Updated the syntax for accessing the IAM policy document, improving clarity and correctness.

Sushmitha Kumar avatar
Sushmitha Kumar
07:25:08 AM

Hi #pr-reviews, Please review this PR for the aws-account-quotas repository. It includes a minor correction to align the splat expression with the Terraform 0.12.0+ format.https://github.com/cloudposse-terraform-components/aws-account-quotas/pull/7

#7 fix: Replace deprecated splat expression with [*] for Terraform 1.5.…

Terraform 0.12.0+ Splat Operator Updates

What

Updated Terraform configuration to replace legacy splat syntax

(resource.*.attribute)

with modern bracket-based expressions (resource[*].attribute).
Incorporated for expressions where applicable to improve flexibility and readability.
No functional changes to infrastructure; these updates are syntax improvements.

Why

Aligns with Terraform 0.12.0+ enhancements and first-class expression support.
Improves readability and maintainability of Terraform code.
Prevents potential deprecation warnings by replacing outdated syntax.

References

Terraform v0.12.0 Upgrade Guide

Summary by CodeRabbit

• Chores
• Updated the method of constructing service_name_set in the configuration for improved clarity.

Gabriela Campana (Cloud Posse) avatar
Gabriela Campana (Cloud Posse)
03:22:36 PM

@Igor Rodionov

#7 fix: Replace deprecated splat expression with [*] for Terraform 1.5.…

Terraform 0.12.0+ Splat Operator Updates

What

Updated Terraform configuration to replace legacy splat syntax

(resource.*.attribute)

with modern bracket-based expressions (resource[*].attribute).
Incorporated for expressions where applicable to improve flexibility and readability.
No functional changes to infrastructure; these updates are syntax improvements.

Why

Aligns with Terraform 0.12.0+ enhancements and first-class expression support.
Improves readability and maintainability of Terraform code.
Prevents potential deprecation warnings by replacing outdated syntax.

References

Terraform v0.12.0 Upgrade Guide

Summary by CodeRabbit

• Chores
• Updated the method of constructing service_name_set in the configuration for improved clarity.

2024-12-30

2024-12-31

    keyboard_arrow_up