#release-engineering (2021-05)

jenkins_ci All things CI/CD. Specific emphasis on Codefresh and CodeBuild with CodePipeline.

CI/CD Discussions

Archive: https://archive.sweetops.com/release-engineering/

2021-05-26

loren avatar
loren

kinda relevant to this channel, what would you expect this Makefile to output:

BAR ?= bar

bar: RECURSIVE = recursive
bar: SIMPLE := simple
bar: CONDITIONAL ?= conditional
bar: ;

foo: FOO ?= foo
foo:
	@echo [make vars]: FOO = $(FOO), BAR = $(BAR), RECURSIVE = $(RECURSIVE), SIMPLE = $(SIMPLE), CONDITIONAL = $(CONDITIONAL)
	@echo [env vars]: FOO = $$FOO, BAR = $$BAR, RECURSIVE = $$RECURSIVE, SIMPLE = $$SIMPLE, CONDITIONAL = $$CONDITIONAL

when running FOO=fee BAR=fi CONDITIONAL=fo make foo?

loren avatar
loren

(it’s a bug in at least the last few versions of make…)

loren avatar
loren

the target-specific, conditional vars are removed from the environment, even when the var is not set on the target being called…

$ FOO=fee BAR=fi CONDITIONAL=fo make foo
[make vars]: FOO = fee, BAR = fi, RECURSIVE = , SIMPLE = , CONDITIONAL = fo
[env vars]: FOO = , BAR = fi, RECURSIVE = , SIMPLE = , CONDITIONAL =
loren avatar
loren

if you build make from the current HEAD, it actually works as expected, and the env vars are all still available in the shell env

$ FOO=fee BAR=fi CONDITIONAL=fo ../make/make foo
[make vars]: FOO = fee, BAR = fi, RECURSIVE = , SIMPLE = , CONDITIONAL = fo
[env vars]: FOO = fee, BAR = fi, RECURSIVE = , SIMPLE = , CONDITIONAL = fo
loren avatar
loren

the impact is particularly noticeable when you use the conditional assignment operator on vars like AWS_DEFAULT_REGION, if you happen to expect any tools to get the value from the env…

2021-05-14

Maycon Santos avatar
Maycon Santos

anybody else facing issues with Github actions today?

I am getting some errors and my jobs won’t start:

GitHub Actions has encountered an internal error when running your job.
    keyboard_arrow_up