#terraform-0_12 (2019-02)

terraform

Discuss upgrading to terraform 0.12

Archive: https://archive.sweetops.com/terraform-0_12/

2019-02-28

stobiewankenobi avatar
stobiewankenobi

Woooooooooooooooooooooo

stobiewankenobi avatar
stobiewankenobi
Announcing Terraform 0.12 Beta 1

We’d like to invite the community to try the first Terraform 0.12 Beta release. This release includes major Terraform language improvements and a tool for automatically upgrading m…

fiesta_parrot2

2019-02-20

maarten avatar
maarten

Was actually looking for a pre-0.12 module . Nice to see some have done some 0.12 effort already. Have to backport unfortunately

https://github.com/innovationnorway/terraform-github-repository/blob/master/main.tf

innovationnorway/terraform-github-repository

Create GitHub repository. Contribute to innovationnorway/terraform-github-repository development by creating an account on GitHub.

antonbabenko avatar
antonbabenko

one day you will discover my Azure module in that org too - https://github.com/innovationnorway/terraform-azurerm-network . Not for 0.12 though.

innovationnorway/terraform-azurerm-network

Terraform module which creates networking resources on Azure - innovationnorway/terraform-azurerm-network

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

a lot of interesting things going on in innocationnorway

2019-02-14

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)
05:22:41 AM

@Erik Osterman (Cloud Posse) set the channel purpose: Discuss upgrading to terraform 0.12

Archive: https://archive.sweetops.com/terraform-0_12/

2019-02-10

bamaral avatar
bamaral
03:43:53 PM

@joshmyers I think that the module on the repo is more specific and I evaluate that the part related to the autoscaling group resource is compatible with the tf-0_12 version. I created a general purpose module where for example I don’t set tags and these values should be passed through an upper module. Or should I create a PR with the generic approach? https://github.com/bamaralf/terraform-aws-autoscaling/blob/tf-0_12/main.tf

bamaralf/terraform-aws-autoscaling

Terraform module which creates Auto Scaling resources on AWS - bamaralf/terraform-aws-autoscaling

joshmyers avatar
joshmyers

@bamaral pretty big change in a single commit (239 additions and 1,210 deletions), looks good but I’m not quite sure what to be looking at. Any chance you can open a PR with info how it has been tested etc?

bamaral avatar
bamaral

@joshmyers On my repository, I decouple the autoscaling_group resource and this is the reason you found so many deletions. I don’t think it is mergeable. On your repository you create a launch_template, a autoscaling_group and “attach” the launch template to this asg. I don’t know if it’s interesting to add the launch_template “attachment” as a dynamic block since the behavior of the module is to create the launch_template and attach it. But I think we can use a dynamic block here: https://github.com/cloudposse/terraform-aws-ec2-autoscale-group/blob/7af452e82effc45c0fb776a54cb594d7a27784d7/main.tf#L63

cloudposse/terraform-aws-ec2-autoscale-group

Terraform module to provision Auto Scaling Group and Launch Template on AWS - cloudposse/terraform-aws-ec2-autoscale-group

bamaral avatar
bamaral

I will create a PR with this change

bamaral avatar
bamaral

in fact, we can use one of these arguments on the aws_autoscaling_resource “tags” (map) or “tag” (config block). Since you are using the “tags” argument, that is fine.

bamaral avatar
bamaral

I’ll just check tha compatibility of the module with the terraform alpha version

2019-02-09

kritonas.prod avatar
kritonas.prod

What are your takes on the points that he raises, as prolific module creators?

2019-02-08

bamaral avatar
bamaral

Hi @antonbabenko

bamaral avatar
bamaral
terraform-aws-modules/terraform-aws-autoscaling

Terraform module which creates Auto Scaling resources on AWS - terraform-aws-modules/terraform-aws-autoscaling

bamaral avatar
bamaral

I created modules terraform-aws-autoscaling and terraform-aws-launch-config for terraform_0.12

bamaral avatar
bamaral

Could you please create a branch in the terraform-aws-autoscaling repository where I can send a PR?

bamaral avatar
bamaral

perhaps, it could be a good idea to have a terraform-aws-launch-config module

joshmyers avatar
joshmyers

@bamaral can you fork it, add whatever and then open a PR against ours?

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

Yes, this opens up an interesting question

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

Should we start (temporary) yet longer lived branches for 0.12

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

So that we can front load some of the work

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

@joshmyers any strategic advice on how we should handle this across all repos?

joshmyers avatar
joshmyers

Painfully?

joshmyers avatar
joshmyers

Take the most used modules first or the ones which do could really require 0.12 features

joshmyers avatar
joshmyers

Folks spend an hour a day moving things over?

joshmyers avatar
joshmyers

longer lived branches are the only way to do it

bamaral avatar
bamaral
03:43:12 PM

Hi @joshmyers, I’ll check yours

@bamaral can you fork it, add whatever and then open a PR against ours?

bamaral avatar
bamaral
cloudposse/terraform-aws-ec2-autoscale-group

Terraform module to provision Auto Scaling Group and Launch Template on AWS - cloudposse/terraform-aws-ec2-autoscale-group

bamaral avatar
bamaral
03:54:49 PM

I think it is a good idea

Should we start (temporary) yet longer lived branches for 0.12

antonbabenko avatar
antonbabenko

@bamaral I am away for a few days, and then will take a look at your PR. As always, fork and send a pr to the origin repo. Thanks!

:--1:1
Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

Cool we will also get some 0.12 branches ready

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

Wonder what the implications will be on versioning

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

How should we version our releases if we have long lived branches?

2019-02-06

antonbabenko avatar
antonbabenko

Trying 0.12 while at CfgMgmtCamp hackathon - it works for the majority of cases for people around me who is trying it on more or less real resources and works well enough for me and some small modules - no panics, no bugs which can’t be fixed.

antonbabenko avatar
antonbabenko

I think it is time to dedicate more efforts on updating modules.

3
:100:2
bamaral avatar
bamaral

I agree

bamaral avatar
bamaral

@antonbabenko I created some AWS modules for tf0.12

bamaral avatar
bamaral

I just created a PR on https://github.com/terraform-aws-modules/terraform-aws-s3-bucket, but I think it’s better we create a specific branch for it.

terraform-aws-modules/terraform-aws-s3-bucket

Terraform module which creates S3 bucket resources on AWS - terraform-aws-modules/terraform-aws-s3-bucket

antonbabenko avatar
antonbabenko

Cool. I will check it out tomorrow. I also started writing the same module today after several attempts of making it for 0.11 :) exciting!

1
    keyboard_arrow_up