#terraform-aws-modules (2020-2)

terraform https://github.com/terraform-aws-modules/ (not cloudposse modules)

Discussions related to https://github.com/terraform-aws-modules Archive: https://archive.sweetops.com/terraform-aws-modules/

2020-02-12

David avatar
David
add instance profile to iam-assumable-role by alemairebe · Pull Request #46 · terraform-aws-modules/terraform-aws-iam

Description I added the possibility to create an IAM instance profile to “iam-assumable-role” As it only takes 1 extra parameter, and is whitin the scope of this module (IAM)

Erik Osterman avatar
Erik Osterman

@maxim

maxim avatar
maxim

@Erik Osterman @David this is not a Cloudposse repo, sorry

Erik Osterman avatar
Erik Osterman

Ah yes, @David this channel is unmonitored by the folks in the “terraform-aws-modules” organization

Erik Osterman avatar
Erik Osterman

It’s been confusing that this channel is related to that organization, so I have given up and just conceded we can have conversations related to general terraform modules for AWS. :-)

David avatar
David

ah gotcha, apologies!

2020-02-11

Jim Park avatar
Jim Park

@aknysh i’m not able to reproduce the failing test in https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/59, advice for how to proceed?

make cluster-enabled mode a bit more automated by jim80net · Pull Request #59 · cloudposse/terraform-aws-elasticache-redis

This PR adds the following functionality when setting cluster_mode_enabled == true: Automatically set number of nodes in cluster_size, enabling scale-out with a single parameter change. Automatica…

Erik Osterman avatar
Erik Osterman

@maxim is now helping as well review some PRs

Erik Osterman avatar
Erik Osterman

he can take a look at this tomorrow

maxim avatar
maxim
11:56:48 PM

@maxim has joined the channel

maxim avatar
maxim

@Jim Park looks like there was no issues with code, just test gets broken. will make a release shortly. stay tuned

Jim Park avatar
Jim Park

thanks @maxim!

Jim Park avatar
Jim Park

and thanks to all y’all

maxim avatar
maxim

@Jim Park here it is: <https://github.com/cloudposse/terraform-aws-elasticache-redis/releases/tag/0.15.0>

Jim Park avatar
Jim Park

woot!

2020-02-05

Jim Park avatar
Jim Park
make cluster-enabled mode a bit more automated by jim80net · Pull Request #59 · cloudposse/terraform-aws-elasticache-redis

This PR adds the following functionality when setting cluster_mode_enabled == true: Automatically set number of nodes in cluster_size, enabling scale-out with a single parameter change. Automatica…

Erik Osterman avatar
Erik Osterman

@aknysh

Jim Park avatar
Jim Park

looks like test failed with a formatting error (I’m bad at those). commit coming with fix.

Adam Crews avatar
Adam Crews

I’d love eyes on this PR too when there is time: https://github.com/cloudposse/terraform-aws-rds-cluster/pull/59

    keyboard_arrow_up