#terraform-aws-modules (2022-10)
Terraform Modules
Discussions related to https://github.com/terraform-aws-modules
Archive: https://archive.sweetops.com/terraform-aws-modules/
2022-10-17
2022-10-20
Hey guys, does anyone here some experience using spotinst.com with Terraform over EKS?
2022-10-21
hey, i have a small PR to allow importing resources without the -cluster suffix in this repo, could anyone take a quick glance when they get a chance?
https://github.com/cloudposse/terraform-aws-eks-cluster/pull/172
thanks!
sorry to bump this but it’s a small review
Ah this has bothered me too. I added a comment and cc’ed Jeremy in the pr for his thoughts
2022-10-23
Wanted to propose some work on the CloudFront CDN module. There are several updates for this module that are best done as breaking changes:
• AWS provider v4
• Origin Access Controls
• Removing a lot of legacy variables I’m interested in doing all this work over several PRs and bundling the release into a single major version bump. Question is, would CloudPosse accept it? I don’t want to do the work unless there’s interest in accepting to upstream. cc @Jeremy G (Cloud Posse) @Erik Osterman (Cloud Posse)
The motivation was that I wanted to add Origin Shield which is a breaking change. I submitted a PR, but just noticed someone already did so in January….
This module needs some love
@Alex Jurkiewicz While I appreciate the effort, I have a lot on my plate and no good way to test your changes or the migration path from old to new, so I cannot encourage you to move forward with this. Maybe @Erik Osterman (Cloud Posse) can.
I believe the work needs to be done, but as @Jeremy G (Cloud Posse) mentions he won’t have time to invest in the review. Maybe @Andriy Knysh (Cloud Posse) can do it?
@Alex Jurkiewicz yes we’ll review your PRs, appreciate all the help, thanks
ok! Thanks. I’ll submit several as per above
@Alex Jurkiewicz this one is approved https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/247