#terraform-aws-modules (2022-10)
Terraform Modules
Discussions related to https://github.com/terraform-aws-modules
Archive: https://archive.sweetops.com/terraform-aws-modules/
2022-10-17
2022-10-20
![Sagi avatar](https://secure.gravatar.com/avatar/d5f32252e481689d86045d7b46acf513.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0016-72.png)
Hey guys, does anyone here some experience using spotinst.com with Terraform over EKS?
2022-10-21
![Alex S avatar](https://avatars.slack-edge.com/2020-06-25/1206943293011_0e3aa4bfe14bcb0561f8_72.jpg)
hey, i have a small PR to allow importing resources without the -cluster
suffix in this repo, could anyone take a quick glance when they get a chance?
https://github.com/cloudposse/terraform-aws-eks-cluster/pull/172
thanks!
what
• Added cluster_name
variable to allow naming without -cluster
suffix
why
• If migrating to this module the cluster name may not end with -cluster
and it’s neccessary to override the name of the resource.
references
• Closes #171
![Alex S avatar](https://avatars.slack-edge.com/2020-06-25/1206943293011_0e3aa4bfe14bcb0561f8_72.jpg)
sorry to bump this but it’s a small review
what
• Added cluster_name
variable to allow naming without -cluster
suffix
why
• If migrating to this module the cluster name may not end with -cluster
and it’s neccessary to override the name of the resource.
references
• Closes #171
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
Ah this has bothered me too. I added a comment and cc’ed Jeremy in the pr for his thoughts
2022-10-23
![Alex Jurkiewicz avatar](https://avatars.slack-edge.com/2020-09-08/1346106958085_9b44ddacd6267cc803c8_72.jpg)
Wanted to propose some work on the CloudFront CDN module. There are several updates for this module that are best done as breaking changes:
• AWS provider v4
• Origin Access Controls
• Removing a lot of legacy variables I’m interested in doing all this work over several PRs and bundling the release into a single major version bump. Question is, would CloudPosse accept it? I don’t want to do the work unless there’s interest in accepting to upstream. cc @Jeremy G (Cloud Posse) @Erik Osterman (Cloud Posse)
Terraform module to easily provision CloudFront CDN backed by an S3 origin
![Alex Jurkiewicz avatar](https://avatars.slack-edge.com/2020-09-08/1346106958085_9b44ddacd6267cc803c8_72.jpg)
The motivation was that I wanted to add Origin Shield which is a breaking change. I submitted a PR, but just noticed someone already did so in January….
This module needs some love
![Jeremy G (Cloud Posse) avatar](https://avatars.slack-edge.com/2020-07-04/1229022582372_22757dbc9ef96d371614_72.jpg)
@Alex Jurkiewicz While I appreciate the effort, I have a lot on my plate and no good way to test your changes or the migration path from old to new, so I cannot encourage you to move forward with this. Maybe @Erik Osterman (Cloud Posse) can.
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
I believe the work needs to be done, but as @Jeremy G (Cloud Posse) mentions he won’t have time to invest in the review. Maybe @Andriy Knysh (Cloud Posse) can do it?
![Andriy Knysh (Cloud Posse) avatar](https://avatars.slack-edge.com/2018-06-13/382332470551_54ed1a5d986e2068fd9c_72.jpg)
@Alex Jurkiewicz yes we’ll review your PRs, appreciate all the help, thanks
![Alex Jurkiewicz avatar](https://avatars.slack-edge.com/2020-09-08/1346106958085_9b44ddacd6267cc803c8_72.jpg)
ok! Thanks. I’ll submit several as per above
![Andriy Knysh (Cloud Posse) avatar](https://avatars.slack-edge.com/2018-06-13/382332470551_54ed1a5d986e2068fd9c_72.jpg)
@Alex Jurkiewicz this one is approved https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/247
For default origin only.