Discussions related to https://github.com/terraform-aws-modules
hey, i have a small PR to allow importing resources without the
-cluster suffix in this repo, could anyone take a quick glance when they get a chance?
cluster_name variable to allow naming without
• If migrating to this module the cluster name may not end with
-cluster and it’s neccessary to override the name of the resource.
• Closes #171
Ah this has bothered me too. I added a comment and cc’ed Jeremy in the pr for his thoughts
Wanted to propose some work on the CloudFront CDN module. There are several updates for this module that are best done as breaking changes:
• AWS provider v4
• Origin Access Controls
• Removing a lot of legacy variables I’m interested in doing all this work over several PRs and bundling the release into a single major version bump. Question is, would CloudPosse accept it? I don’t want to do the work unless there’s interest in accepting to upstream. cc @Jeremy G (Cloud Posse) @Erik Osterman (Cloud Posse)
Terraform module to easily provision CloudFront CDN backed by an S3 origin
@Alex Jurkiewicz While I appreciate the effort, I have a lot on my plate and no good way to test your changes or the migration path from old to new, so I cannot encourage you to move forward with this. Maybe @Erik Osterman (Cloud Posse) can.
I believe the work needs to be done, but as @Jeremy G (Cloud Posse) mentions he won’t have time to invest in the review. Maybe @Andriy Knysh (Cloud Posse) can do it?
@Alex Jurkiewicz yes we’ll review your PRs, appreciate all the help, thanks
ok! Thanks. I’ll submit several as per above
@Alex Jurkiewicz this one is approved https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/247
For default origin only.