Discussions related to https://github.com/terraform-aws-modules
Is it possible to get the PR in this message looked at as its a blocker on upgrading the Elasticbeanstalk module across over 20 projects. https://sweetops.slack.com/archives/CB6GHNLG0/p1686127285090189
https://github.com/cloudposse/terraform-aws-ec2-instance/pull/159/files forces a dependency on the 5.0 aws provider
the external ENI?
The aws_eip resource
the vpc/domain option?
Yes. Domain isn’t assignable. https://github.com/cloudposse/terraform-aws-ec2-instance/issues/161
Describe the Bug
The recent changes to
aws_eip force a dependency on the 5.0
aws provider. Using 4.x throws errors with
on .terraform/modules/data_host.box/main.tf line 175, in resource "aws_eip" "default":
domain = "vpc"
Can't configure a value for "domain": its value will be decided automatically based on the result of applying this configuration.
Caused by #159, if this is intended behavior, documentation and version requirements should be updated to not say the dependency is against
Resources deploy fine
Steps to Reproduce
Try to use module with 4.x
we could roll that back, but I will defer to @Andriy Knysh (Cloud Posse) when he has some time
Doesnt necessarily need rolled back, just
[versions.tf](http://versions.tf) updated to track so it’d be more apparent on breaking changes on new releases
We are supposed to cutting a new major version for breaking changes by adding the
major label to breaking PRs.
If this depends on v5 fuctionality, it shouldn’t have been merged before https://github.com/cloudposse/terraform-aws-ec2-instance/pull/160
@Max Lobur (Cloud Posse) can you sort this one out?
using the major label, we can support v4 and v5 concurrently, since we’ll automatically cut a release branch for the previous release, in this case release/v0
@Linda Pham (Cloud Posse) @Gabriela Campana (Cloud Posse)
I missed the fact that one change from @jose.amengual PR works only with the aws provider v5
we need to make the release a pre-release, and cut a new major one with the same code
will do now
and that fix I added because tflint was complaining in the checks
no the breaking fix is the vpc iface change
they changed boolean to string
the vpc = domain on the eip?
- released 1.0.0
- branch relase/v0 auto-created
- I will revert the vpc change there now, pin provider to 4, and test
AWS provider V4 compatibility
Keeping V4 up
approved and added label
minor (if it’s what you wanted to release)
0.50.0 - supports V4 1.0.0 - supports V5
thanks guys and sorry for the mess I made
np, I will keep this in mind for other updates too
specially if tflint says deprecated or it fails etc since tflint I guess check the latest only
@jose.amengual no problem. This is all new, so it will become more common. It’s a good heads up!
@Linda Pham (Cloud Posse) has joined the channel
@Gabriela Campana (Cloud Posse) has joined the channel
Hi there, I can’t find any reference to one but is there a Cloudposse module for Cloudwatch dashboard?
We’re using mostly datadog
(would love to have one though!)
Thanks Erik! i’ve resorted to raw TF and playing with trying to create widgets dynamically based on resource count. if i get it working il submit it for a module for the community
i did find a solution to this but it gets complex messing with json objects, looks like you could with some thought make a module around it