#terraform-aws-modules (2023-06)
Terraform Modules
Discussions related to https://github.com/terraform-aws-modules
Archive: https://archive.sweetops.com/terraform-aws-modules/
2023-06-07
![Samuel Crudge avatar](https://secure.gravatar.com/avatar/ebb5c8d23f7971dd34ca78d13f1b6b5b.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0008-72.png)
Hello!
Is it possible to get the PR in this message looked at as its a blocker on upgrading the Elasticbeanstalk module across over 20 projects. https://sweetops.slack.com/archives/CB6GHNLG0/p1686127285090189
![Brent Garber avatar](https://avatars.slack-edge.com/2021-08-04/2372755651008_f0024ce2395959ee12de_72.jpg)
https://github.com/cloudposse/terraform-aws-ec2-instance/pull/159/files forces a dependency on the 5.0 aws provider
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
which part?
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
the external ENI?
![Brent Garber avatar](https://avatars.slack-edge.com/2021-08-04/2372755651008_f0024ce2395959ee12de_72.jpg)
The aws_eip resource
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
the vpc/domain option?
![Brent Garber avatar](https://avatars.slack-edge.com/2021-08-04/2372755651008_f0024ce2395959ee12de_72.jpg)
Yes. Domain isn’t assignable. https://github.com/cloudposse/terraform-aws-ec2-instance/issues/161
Describe the Bug
The recent changes to aws_eip
force a dependency on the 5.0 aws
provider. Using 4.x throws errors with
on .terraform/modules/data_host.box/main.tf line 175, in resource "aws_eip" "default":
domain = "vpc"
Can't configure a value for "domain": its value will be decided automatically based on the result of applying this configuration.
Caused by #159, if this is intended behavior, documentation and version requirements should be updated to not say the dependency is against >= 2.0
Expected Behavior
Resources deploy fine
Steps to Reproduce
Try to use module with 4.x aws
provider
Screenshots
No response
Environment
No response
Additional Context
No response
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
we could roll that back, but I will defer to @Andriy Knysh (Cloud Posse) when he has some time
![Brent Garber avatar](https://avatars.slack-edge.com/2021-08-04/2372755651008_f0024ce2395959ee12de_72.jpg)
Doesnt necessarily need rolled back, just [versions.tf](http://versions.tf)
updated to track so it’d be more apparent on breaking changes on new releases
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
We are supposed to cutting a new major version for breaking changes by adding the major
label to breaking PRs.
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
If this depends on v5 fuctionality, it shouldn’t have been merged before https://github.com/cloudposse/terraform-aws-ec2-instance/pull/160
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
@Max Lobur (Cloud Posse) can you sort this one out?
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
using the major label, we can support v4 and v5 concurrently, since we’ll automatically cut a release branch for the previous release, in this case release/v0
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
@Linda Pham (Cloud Posse) @Gabriela Campana (Cloud Posse)
![Andriy Knysh (Cloud Posse) avatar](https://avatars.slack-edge.com/2018-06-13/382332470551_54ed1a5d986e2068fd9c_72.jpg)
I missed the fact that one change from @jose.amengual PR works only with the aws provider v5
![Andriy Knysh (Cloud Posse) avatar](https://avatars.slack-edge.com/2018-06-13/382332470551_54ed1a5d986e2068fd9c_72.jpg)
we need to make the release a pre-release, and cut a new major one with the same code
![Max Lobur (Cloud Posse) avatar](https://avatars.slack-edge.com/2021-07-20/2316891735296_3098d8d2760936592f52_72.jpg)
correct
![Max Lobur (Cloud Posse) avatar](https://avatars.slack-edge.com/2021-07-20/2316891735296_3098d8d2760936592f52_72.jpg)
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
and that fix I added because tflint was complaining in the checks
![Max Lobur (Cloud Posse) avatar](https://avatars.slack-edge.com/2021-07-20/2316891735296_3098d8d2760936592f52_72.jpg)
no the breaking fix is the vpc iface change
![Max Lobur (Cloud Posse) avatar](https://avatars.slack-edge.com/2021-07-20/2316891735296_3098d8d2760936592f52_72.jpg)
they changed boolean to string
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
![Max Lobur (Cloud Posse) avatar](https://avatars.slack-edge.com/2021-07-20/2316891735296_3098d8d2760936592f52_72.jpg)
- released 1.0.0
- branch relase/v0 auto-created
- I will revert the vpc change there now, pin provider to 4, and test
![Max Lobur (Cloud Posse) avatar](https://avatars.slack-edge.com/2021-07-20/2316891735296_3098d8d2760936592f52_72.jpg)
what
AWS provider V4 compatibility
why
Keeping V4 up
![Max Lobur (Cloud Posse) avatar](https://avatars.slack-edge.com/2021-07-20/2316891735296_3098d8d2760936592f52_72.jpg)
let’s merge^
![Andriy Knysh (Cloud Posse) avatar](https://avatars.slack-edge.com/2018-06-13/382332470551_54ed1a5d986e2068fd9c_72.jpg)
approved and added label minor
(if it’s what you wanted to release)
![Max Lobur (Cloud Posse) avatar](https://avatars.slack-edge.com/2021-07-20/2316891735296_3098d8d2760936592f52_72.jpg)
0.50.0 - supports V4 1.0.0 - supports V5
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
thanks guys and sorry for the mess I made
![Max Lobur (Cloud Posse) avatar](https://avatars.slack-edge.com/2021-07-20/2316891735296_3098d8d2760936592f52_72.jpg)
np, I will keep this in mind for other updates too
![jose.amengual avatar](https://secure.gravatar.com/avatar/32f267b819eac9e0ea6a8324b53064a0.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0024-72.png)
specially if tflint says deprecated or it fails etc since tflint I guess check the latest only
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
@jose.amengual no problem. This is all new, so it will become more common. It’s a good heads up!
2023-06-08
![Linda Pham (Cloud Posse) avatar](https://avatars.slack-edge.com/2022-04-13/3374321180711_438a91ddd259ebac3590_72.jpg)
@Linda Pham (Cloud Posse) has joined the channel
![Gabriela Campana (Cloud Posse) avatar](https://avatars.slack-edge.com/2023-05-17/5281506983315_fbbf3b358313efef4647_72.jpg)
@Gabriela Campana (Cloud Posse) has joined the channel
2023-06-19
![Samuel Crudge avatar](https://secure.gravatar.com/avatar/ebb5c8d23f7971dd34ca78d13f1b6b5b.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0008-72.png)
Hi there, I can’t find any reference to one but is there a Cloudposse module for Cloudwatch dashboard?
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
No…
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
We’re using mostly datadog
![Erik Osterman (Cloud Posse) avatar](https://secure.gravatar.com/avatar/88c480d4f73b813904e00a5695a454cb.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0023-72.png)
(would love to have one though!)
![Samuel Crudge avatar](https://secure.gravatar.com/avatar/ebb5c8d23f7971dd34ca78d13f1b6b5b.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0008-72.png)
Thanks Erik! i’ve resorted to raw TF and playing with trying to create widgets dynamically based on resource count. if i get it working il submit it for a module for the community
![Samuel Crudge avatar](https://secure.gravatar.com/avatar/ebb5c8d23f7971dd34ca78d13f1b6b5b.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0008-72.png)
i did find a solution to this but it gets complex messing with json objects, looks like you could with some thought make a module around it