#terraform-aws-modules (2024-01)
Terraform Modules
Discussions related to https://github.com/terraform-aws-modules
Archive: https://archive.sweetops.com/terraform-aws-modules/
2024-01-04
hey there.
I created a PR in terraform-aws-vpc-peering-multi-account (https://github.com/cloudposse/terraform-aws-vpc-peering-multi-account/pull/82) - december 4’th, with a proposed fix for https://github.com/cloudposse/terraform-aws-vpc-peering-multi-account/issues/81 - teardown/enabled = false - not working because of an enabled check on the provider config, specifically for assumerole usage.
not sure if the codeowners are swamped, or no longer there, but it seems other PR’s are also stranded. I couldn’t find guidelines regarding where/what/who to poke to try and alleviate the issue. currently we have to use the proposed fix PR as module, or we cannot do cross account vpc peering teardown. I don’t mind if it’s not deemed an acceptable fix, but some feedback would be good
pointers? ( was directed here from #terraform )
@Tommi Jensen thanks for the PR, it’s approved, but please run the commands in the comment to update README and GH actions
done! and thanks.
@Andriy Knysh (Cloud Posse) just a friendly bump to notify you that the requested changes has been made.
@Andriy Knysh (Cloud Posse) bump.
i’ll review it again in a few. Need to understand the comment @RB made about the PR reverting a previous PR
@Tommi Jensen please address one comment and we’ll approve the PR, thank you
will do!
done. fwiw, I did that earlier, it just drifted meanwhile
2024-01-08
Hi all, I submitted a PR against terraform-aws-utils. Any chance someone could take a look at it? Thanks! https://github.com/cloudposse/terraform-aws-utils/pull/31
the PR looks good, can you please address the comments
Done
thanks, please also format all TF code
Was just doing that now
I usually have that as a pre-commit hook. Never think to run it manually. It’s done now
@Jason Kusar one more thing please, see comments
Do I need to re-run make or anything after making that change?
no, thanks
@Jason Kusar i have to ask you to add all the config for ca-west-1 region as well (it was added after the module was last tested), same as you did for the Israel region Please see comments. Thanks a lot
Done
thanks a lot @Jason Kusar for all the updates
2024-01-09
I encountered an issue with the AWS Terraform state backend module, and fortunately, someone has already created a fix for it. It just requires reviewers; could anyone please take a look? https://github.com/cloudposse/terraform-aws-tfstate-backend/pull/151
2024-01-12
2024-01-23
Hello all we’re using cloudposse terraform module terraform-aws-rds module which is using terraform-null-label v.0.25.0 & terraform-aws-route53-cluster-hostname v0.13.0 modules under-hood. Suddenly, terraform fails downloading the modules saying the branch not exist as below:
│ Error: Failed to download module
│ Could not download module "this" (context.tf:23) source code from
│ "git::<https://github.com/cloudposse/terraform-null-label?ref=488ab91e34a24a86957e397d9f7262ec5925586a>":
│ error downloading
│ '<https://github.com/cloudposse/terraform-null-label?ref=488ab91e34a24a86957e397d9f7262ec5925586a>':
│ /opt/homebrew/bin/git exited with 128: Cloning into
│ '.terraform/modules/this'...
│ fatal: Remote branch 488ab91e34a24a86957e397d9f7262ec5925586a not found in
│ upstream origin
However the under-hood modules are referenced by their tags not commit hashes. Any insights what could be the reason?
tags dereference to commits. git rev-parse tagname (take one of your tagged versions e.g.)
2024-01-24
2024-01-25
2024-01-30
Hey folks, anyone able to review a small change for me? Just changes to variables (and readme update). Thank you https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/178
@Alex S thanks, the PR looks good, there is an issue with the terratest, please see comments