#pr-reviews (2024-05)
Pull Request Reviews for Cloud Posse Projects
2024-05-01
https://github.com/cloudposse/terraform-aws-elasticache-redis/pull/227
I added support for Serverless Redis to this module
what
• Add support for Serverless Redis instances
why
• Supporting Redis Serverless for demanding applications
notes
• This upgrades the required version of the AWS provider from “>= 4.18” to “>= 5.32” as this is the first release where aws_elasticache_serverless_cache
was introduced
2024-05-02
Hey there, can someone have a look at this PR discussion? https://github.com/cloudposse/terraform-aws-lb-s3-bucket/pull/82#issuecomment-2090913789 It’s about the correct use of the null label module to generate a default bucket name.
references
closes #81 Copy bucket_name logic from dependent module
Hi Team, Gret help if you guys can help to review this PR https://github.com/cloudposse/terraform-aws-waf/pull/57
what Fixed a typo in aws_wafv2_web_acl resource: changed content_type assignment. why Corrects content_type mapping to use the appropriate value. references Minor fix, no related GitHub issue.
Looks like the readme needs to be updated.
Try running
make init
make docs
make readme
and pushing up
what Fixed a typo in aws_wafv2_web_acl resource: changed content_type assignment. why Corrects content_type mapping to use the appropriate value. references Minor fix, no related GitHub issue.
Actually I am not the author of the PR. I wanted to get the attention for the PR because we are desperately waiting this fix as we depend on WAF module for prod workloads
2024-05-03
Very small PR (one-liner). Adding a try()
around a length()
function to stop it from throwing an error.
2024-05-05
2024-05-06
Could you please review this pull request: https://github.com/terraform-aws-modules/terraform-aws-acm/pull/149 It would be nice to have this feature merged
This is a follow up of #137
Credits to @amontalban for the work, I made requested changes and tested the feature.
Description
This PR allows creating one ACM certificate for multiple domains, which, is useful when using the certificate for CloudFront that only allows one certificate per distribution.
Motivation and Context
CloudFront does not support multiple ACM certificates, like ALB. Therefore, if you need to support multiple domains in a single CloudFront distribution you would have to create the certificate manually because this module does not support it.
Breaking Changes
This change should be backward compatible as I added a zones var containing a map with domains and their Route53 zone ID so the validation records are created in the correct Route53 zone.
Additionally, I have updated the tests in examples/complete-dns-validation to allow variables so it was easier for me (and others) to test with my test domains.
How Has This Been Tested?
☑︎ I have updated at least one of the examples/*
to demonstrate and validate my change(s)
☑︎ I have tested and validated these changes using one or more of the provided examples/*
projects
☑︎ I have executed pre-commit run -a
on my pull request
Fixes #136
2024-05-07
In PR https://github.com/cloudposse/terraform-aws-ec2-bastion-server/pull/230/files
• The tflint
step is failing here due to a github token issue
• The codeowners are set to admins
Is this repo out of date?
Hi, could I get the PR reviewed? https://github.com/cloudposse/terraform-aws-rds-cluster/pull/192
what
I implemented create_before_destroy on the aws_rds_cluster_instance default instances.
why
Making a change to any parameter that triggers a replace on a aws_rds_cluster_instance results in all instances being destroyed before attempting to create a new instance which causes an outage. This a faster (and safer) altenative to #191
references
Hello all. could you check my PR? ref: https://github.com/cloudposse/terraform-aws-elasticache-memcached/pull/79
2024-05-10
Hello, I need a PR review. Thanks ref: https://github.com/cloudposse/terraform-aws-ec2-instance/pull/197
2024-05-14
Could you take a look please? https://github.com/cloudposse/terraform-aws-eks-cluster/pull/227
what
Implements #226.
why
See linked issue.
references
See linked issue.
2024-05-15
Could i get some help with the failing checks in this pr ?
https://github.com/cloudposse/terraform-aws-components/pull/1032
what
• add named subnets to vpc component
why
• allow using named subnets for databases
references
Related thread
@RB we’d appreciate it if you opened a PR and add it
Thanks for surfacing this. I’m looking into it internally and will let you know once it’s resolved
This repo isn’t supposed to have those failing workflows. We’re removing them once Erik confirms this PR https://github.com/cloudposse/terraform-aws-components/pull/1038
what
• Deleted the feature-branch.yaml
workflow
why
• This repo should not have this workflow. It’s intended for module, not component, repos.
references
2024-05-16
hello all, new PR is here I’m eating https://github.com/cloudposse/terraform-aws-rds/pull/181 thank you for your time and effort! best!
what
Output values.
why
We need to pass in the rds.
references
n/a
@Ozan Gazi cc
what
Output values.
why
We need to pass in the rds.
references
n/a
thanks @Ercan Ermis the PR looks good, please address the comments and we’ll merge it
hello @Andriy Knysh (Cloud Posse), they are completed and ready to merge. thanks! ^^
Could I please get a review on https://github.com/cloudposse/terraform-aws-ecs-alb-service-task/pull/238 ?
what
• Update examples/complete to include ECS Service Connect config • bump AWS provider version to support latest ECS Service Connect config
why
• Fix issue when using older AWS provider • Increase test coverage
references
• Closes #236
2024-05-17
2024-05-18
Hi Team, help to review this https://github.com/cloudposse/terraform-aws-waf/pull/79 . While using the WAF module we noticed this part is missing and just thought to raise the PR. Thank you
what
Add a response body for the default blocked action by choosing from the existing custom response bodies.
why
Sometimes, users may want to display a custom response message for default blocked action.
references