#pr-reviews (2020-06)

Pull Request Reviews for Cloud Posse Projects

2020-06-17

Frank avatar
Frank

Good morning! Could someone please take a look at my PR? https://github.com/cloudposse/terraform-aws-ses/pull/2 Thanks!

Add configurable IAM policy for mail user by syphernl · Pull Request #2 · cloudposse/terraform-aws-ses

what Added an optional variable to configure the IAM Policy for the user. why Out of the box it only configures the user with ses:SendRawEmail permission but it might be desirable to use ses:Sen…

1
Gowiem avatar
Gowiem

Merged. Thanks!

cloudposse/terraform-aws-ses

Terraform module to provision Simple Email Service on AWS - cloudposse/terraform-aws-ses

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

thanks @Gowiem!!

2020-06-16

joey avatar

i was going to start using https://github.com/cloudposse/slack-notifier but i want buttons https://api.slack.com/legacy/message-buttons .. i wonder if you could do something like?

SLACK_BUTTON_COUNT=2
SLACK_BUTTON_1_TEXT=approve
SLACK_BUTTON_1_URL=<https://codefresh/${CF_BUILD_ID}/approve>
SLACK_BUTOTN_2_TEXT=deny
SLACK_BUTTON_2_URL=<https://codefresh/${CF_BUILD_ID}/deny>

but erik suggested i might just be better off using gomplate and i think he’s right

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

That could work. I think the count might not even be necessary.

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

I’d just enumerate the ENVs until not defined.

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

What about button color?

joey avatar

i ended up using gomplate

2020-06-12

Tyrone Meijn avatar
Tyrone Meijn

https://github.com/cloudposse/terraform-aws-vpc/pulls could some PRs be reviewed for this module? These are open since march 26th.

cloudposse/terraform-aws-vpc

Terraform Module that defines a VPC with public/private subnets across multiple AZs with Internet Gateways - cloudposse/terraform-aws-vpc

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

We are working on increasing our collaborators for Pr reviews

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

We have started a group with about 7 now. Still writing up the documentation they need to get started. Sorry we have over 270 open PRs

:--1:1
Tyrone Meijn avatar
Tyrone Meijn

No apologies needed, the modules are free and awesome!

1
Tyrone Meijn avatar
Tyrone Meijn

On a semi-related note: do you guys know about https://github.com/renovatebot/renovate?

I see sometimes the PRs are just module reference updates that you guys created yourself. I use Renovate to update walk over our Terraform code and raise a PR whenever there’s an update for a module.

renovatebot/renovate

Universal dependency update tool that fits into your workflows. - renovatebot/renovate

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

We have dependabot available for that too - have avoided mostly because concern about ensuring stability. We do have terratest on most modules these days, but automated PRs do increase the code reviews since they are mandatory on all repos for security. For example one change to null label module will cause 150 PRs!

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

We are dealing with a unique scale and problem few organizations deal with :-)

Tyrone Meijn avatar
Tyrone Meijn

Wow, okay never mind then That’s not the amount PRs we generate no.

2020-06-05

Adam Crews avatar
Adam Crews

Good morning, Could I get a review on https://github.com/cloudposse/terraform-aws-s3-bucket/pull/27 when someone has a moment? This replaces pr#23 in the same repo with an alternate/more flexible implementation.

Optionally allow public access to the bucket, default is now to block by adamcrews · Pull Request #27 · cloudposse/terraform-aws-s3-bucket

This will change the default behavior to now block public access to the bucket. All options can be configured. This mirrors a recent update to the https://github.com/cloudposse/terraform-aws-s3-lo

1
Adam Crews avatar
Adam Crews

I created 2 more PR’s for the above project that close out a couple of tickets. I would love a review of those also. Thank you!

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

so sorry everyone - @Andriy Knysh (Cloud Posse) has been out of town this week

PePe avatar

np

Erik Osterman (Cloud Posse) avatar
Erik Osterman (Cloud Posse)

you’re most patient @PePe

PePe avatar

slow and steady you are bound to succeed

2020-06-01

Mikhail Naletov avatar
Mikhail Naletov
Update bucket logging module version by okgolove · Pull Request #82 · cloudposse/terraform-aws-cloudfront-s3-cdn

Update to latest label module to support the environment attribute what Add compatibility with the latest label module&#39;s version why s3 bucket module has the same name in different environme…

    keyboard_arrow_up