Pull Request Reviews for Cloud Posse Projects
Hello! Could someone take a look? https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/pull/82
Update to latest label module to support the environment attribute what Add compatibility with the latest label module's version why s3 bucket module has the same name in different environme…
Good morning, Could I get a review on https://github.com/cloudposse/terraform-aws-s3-bucket/pull/27 when someone has a moment? This replaces pr#23 in the same repo with an alternate/more flexible implementation.
This will change the default behavior to now block public access to the bucket. All options can be configured. This mirrors a recent update to the https://github.com/cloudposse/terraform-aws-s3-lo…
I created 2 more PR’s for the above project that close out a couple of tickets. I would love a review of those also. Thank you!
so sorry everyone - @Andriy Knysh (Cloud Posse) has been out of town this week
you’re most patient @jose.amengual
slow and steady you are bound to succeed
https://github.com/cloudposse/terraform-aws-vpc/pulls could some PRs be reviewed for this module? These are open since march 26th.
Terraform Module that defines a VPC with public/private subnets across multiple AZs with Internet Gateways - cloudposse/terraform-aws-vpc
We are working on increasing our collaborators for Pr reviews
We have started a group with about 7 now. Still writing up the documentation they need to get started. Sorry we have over 270 open PRs
No apologies needed, the modules are free and awesome!
On a semi-related note: do you guys know about https://github.com/renovatebot/renovate?
I see sometimes the PRs are just module reference updates that you guys created yourself. I use Renovate to update walk over our Terraform code and raise a PR whenever there’s an update for a module.
Universal dependency update tool that fits into your workflows. - renovatebot/renovate
We have dependabot available for that too - have avoided mostly because concern about ensuring stability. We do have terratest on most modules these days, but automated PRs do increase the code reviews since they are mandatory on all repos for security. For example one change to null label module will cause 150 PRs!
We are dealing with a unique scale and problem few organizations deal with :-)
Wow, okay never mind then That’s not the amount PRs we generate no.
but erik suggested i might just be better off using gomplate and i think he’s right
Good morning! Could someone please take a look at my PR? https://github.com/cloudposse/terraform-aws-ses/pull/2 Thanks!
what Added an optional variable to configure the IAM Policy for the user. why Out of the box it only configures the user with ses:SendRawEmail permission but it might be desirable to use ses:Sen…
what Add GitHub Actions ChatOps according to the docs why Migration to GitHub actions from Codefresh references https://docs.cloudposse.com/community/automated-testing/ notes I'm not sur…