Please use #pr-reviews

pog ty

Please use #pr-reviews

Sounds like account-map needs to be updated

The aws-saml is the new name for the sso component

account-map/modules/team-assume-role-policy is the new name for account-map/modules/iam-assume-role-policy . Sorry we have not been keeping pace with upgrades to terraform-aws-components. @Erik Osterman (Cloud Posse) what can we say about timelines for that?

These should be published already, but if not @Dan Miller (Cloud Posse) will be publishing them soon.

All of the above, including SSM param store

data sources

A and SSM (when required by things like Serverless Framework)

Tell me more about your use of SSM.

Using a simple config store with outputs pushed to SSM?

a) tagging and using data sources

Org admin account is the master account in your AWS organisation. Typically used for managing other accounts, SSO and in the past has been used for the master in the master-member model for guardduty and security hub. You can delegate the guardduty admin to an account which is not the org master account to something like a infosec account

Okay, what worked was to comment out alb_ingress_unauthenticated_paths and deploy everything else (particularly the ALB) and then uncomment that parameter and deploy again.

Basically a targeted apply and then a full apply

We see this issue come up a lot. Its a limitation in terraform. There are some methods to get around it but they are tricky. Several functions will set it off like length(), distinct, sort. I think in this case, its length.

Yes, the error message tells you what to do, but it was hard for me to figure out what I needed to target in the apply.

Eh, I disagree. It doesn’t actually solve the root problem. The root problem is that the module cannot decipher how many arns are passed in before the dependent module is fully applied. There is a way to do it but I’m not the best at solving them.

cc: @Jeremy G (Cloud Posse) @Andriy Knysh (Cloud Posse) any ideas/guidance on how to fix the The "count" value depends on resource attributes that cannot be determined until apply error for terraform-aws-alb-ingress ?

this is a tough case. Sometimes count works (if it does not use the collection functions that can change the list items, like distinct()), sometimes for_each works

we “solved” the issue before in some of the modules by providing an explicit var e.g. arn_count and use it in count (if you know the number of ARNs, you can do it, but terraform does not know it)

we had the issue in even 2017-2018, and it’s not solved yet by TF b/c it’s not possible to solve for all cases even in theory

The fix:

Remove dynamic counts (provide explicit counts if possible)
Or remove maps from counts
Or try to remove the data source (could work in some cases)
apply in stages with -target (not a pretty solution)

https://github.com/cloudposse/docs/issues/131

The solution is to ensure that Terraform can compute the length of the variables at plan time:

length(var.unauthenticated_paths) > 0 && length(var.unauthenticated_hosts) == 0 ? length(var.unauthenticated_listener_arns)

All 3 are lists by design, so you do not need to know the values at plan time, but you need to know how many paths and hosts and listener ARNs there are. This means you need to create the lists without applying functions like compact, distinct, or (due to a design flaw) sort on the lists.

We’d have to make a change to the module it would seem

@Abdelaziz Besbes, this looks like the new “this has changed” plan output section that just shows state diffs, not the planned changes, right?

I find that output to be confusing sometimes, but potentially-useful for seeing changes in unmanaged resource params.

So, if there’s no proposed change, based on that change, suppressing the info message is just cosmetic.

The issue, btw, that forces an update of the module, is that lifecycle.ignore_changes entries must be static references. I ran into a case, where our app is handling some interaction with TF-managed resources, that required an entry in ignore_changes, but only for some instances of that resource type. That required duplicating the module and using the hacked version just for one instance.

Someone in an #office-hours session suggested updating the module to include both the standard resource invocation and the one with the ignore_changes entry hard-coded. Then use a boolean var with count to toggle between them. Not a solution for a public module, but much cleaner than some other options.

The error message looks clear. I’d open an issue on the provider github repo, or see if one already exists

Sometimes errors like this appear when the AWS API accepts multiple types of value for the field, but terraform expects just one format.

For example, you see this bug with some resources where you specify KMS key. Terraform usually expects a key ARN, but you can often use a key alias too, and the provider barfs

Easy way to do this is probably with a for_each, and have a vairable, which is a list(object({})) so you can define what params you want to generate (like subnet) vs things you care about, like naming

variable "cow_farms" {
  type = list(object({
     cow_name = string
}

Can then do a

for_each      = {for cow in var.cow_farms: cow.cow_name => cow }
source = "git::https://{SOURCE}.git"
name = ${each.value.cow_name}
subnet_ids = var.subnet

by calling

cow_farms = [
 {
  cow_name = "fred"
},
{
cow_name = "frida"
}
]

I see. Then I should be capable to do something like name = "var.name-${each.value.cow_name}"? Considering that I would like to not loose the entire content of the variable, but keep it and concat the cow_name. name = mr. name = "var.name-${each.value.cow_name}" would give me mr. fred or mr. frida

yeah

Wonderful. Let me try that and keep post it. Thanks mate for the enlightenment.

I will like to confirm that it did work flawless. Many thanks.

Just by curiosity, if I looking to create the rds with a snapshot, and there is 2 different snapshot to be used (one for auth, another for api), which modification would required the for_each? Considering that I have different variables for each snapshot_identifier arn.

You could add it to the object

I see… That’s awesome. Many thanks. It worked flawless… Also this gave me the picture about many other things. I own you a beer Thanks mate.

Code:

resource "aws_elastic_beanstalk_environment" "main" {
  name                = var.env_name
  application         = var.ebs_application_name
  solution_stack_name = "64bit Amazon Linux 2 v3.4.0 running PHP 8.1"

  setting {
    namespace = "aws:autoscaling:asg"
    name      = "Availability Zones"
    value     = var.availability_zones
  }

  setting {
    namespace = "aws:autoscaling:asg"
    name      = "MinSize"
    value     = var.asg_min_instances
  }

  setting {
    namespace = "aws:autoscaling:asg"
    name      = "MaxSize"
    value     = var.asg_max_instances
  }

  setting {
    name      = "aws:ec2:vpc"
    namespace = "VPCId"
    value     = var.vpc_id
  }

  setting {
    namespace = "aws:ec2:vpc"
    name      = "AssociatePublicIpAddress"
    value     = var.associate_public_ip_address
  }

  setting {
    namespace = "aws:ec2:vpc"
    name      = "Subnets"
    value     = var.public_subnets_join
  }

….. }

Output of plan: + setting { + name = “SecurityGroups” + namespace = “awslaunchconfiguration” + value = “sg-0dd7945fac577b9b2” } + setting { + name = “ServiceRole” + namespace = “awsenvironment” + value = “eb-service” } + setting { + name = “Subnets” + namespace = “awsvpc” + value = “subnet-059483d3fdb776d1c,subnet-033f1ae5c7fecf260,subnet-038522e3a8bd63b96” } + setting { + name = “awsvpc” + namespace = “VPCId” + value = “vpc-0ef5769a1eaeb4beb” }

There’s no force_delete setting so no. Someone would have to PR it in.

Is it possible that it had something to do with the terraform registry?

Did you try changing the source from the registry format to the git format to skip the registry?

That has been my thought as well. Some transient issue with the registry. We’re currently expanding our usage of JFrog Artifactory, so I will probably just configure pull-through caching of the registry. The part that worries me is this was a silent failure from the perspective of terraform init.

We had another client, very recently after the tf 1.2.7 update, had similar weird issues with the registry

I guess the best solution is to create some kind of pass thru private reg in nexus or jfrog so if the registry is experiencing issues, you wont notice them

“Good” to know we weren’t alone in that regard. And yes, it’s on our roadmap, but this may help re-prioritize it. Thank you!

https://status.hashicorp.com/history

Cc @Shawn Stout

Let’s use this thread

ok

im just creating the folders and code and such

I would follow that blog post by spacelift, create the necessary directories and then you can go through the workflow

the terraform code, whats the normal file extension?

You may not have a terraform backend setup so your terraform state may be saved locally

The extension is .tf

You may also want to run through the hashicorp terraform tutorial

Theres a decent amount to learn before it all makes sense

ok so with the blog you mentioned, where do i find it at?

ill start there

https://spacelift.io/blog/what-are-terraform-modules-and-how-do-they-work

Before that blog post, the basics would be good to look over too

https://learn.hashicorp.com/terraform

Just to make sure, this is a template to standardize and automate codebuild projects, correct?

i want to make sure at the end of this, it does what im looking for

A module is a directory of reusable terraform code that can be used to bulk create resources. Its akin to a function with a set of inputs and outputs

The codebuild module you referenced, im not super familiar with, but it seems like it might be at least 1 module you may need to bootstrap what youre trying to accomplish

You wont be able to solve the task at hand without understanding the underlying terraform cli tool and how it works tho..

ok

looks like i need to install terraform

Lol yes definitely

i was able to get it to build ok

but during plan, i received some errors

oh i think i know whats wrong

aws configure

my session ended

yep, gotta make sure your aws is logged in

aws sts get-caller-identity is the command i run most often

sso is a pain that way

yeah me too, find out what role i am under

ok, i think it built, going to check it out

i have to update quite a few things, but this is great

off to a good start

And it’s extra annoying when you’ve got multiple regions across hundreds of states.

I am not sure I follow

We do it because the aws provider doesn’t support what we are doing

the alternative is local exec

awsutils is so much more than expiring access keys

and we only use awsutils when it’s needed. if you can point me to some examples where it’s not needed, happy to take a look

Note, looks like we’ve just implemented a workaround for defaulting the region:

https://github.com/cloudposse/terraform-provider-awsutils/pull/30#pullrequestreview-1073422213

What I mean is, the feature which needs awsutils in the IAM system user module is not used by other cloudposse modules. But it still results in a new provider being added as a dependency to our configurations

From my perspective, it’s really poor DX that will slow down terraform init for any stack using cloudposse modules

From a user experience the extra functionality is almost never worthwhile except for a few niche cases. While the impact of implementing it is quite jarring. As Alex said it also results in a slower init. There’s also an impact to plans / applies.

People are going to be opinionated about it though. It’s also confusing for newbies since there’s also a aws utils module from cloudposse. It would be better if the niche cases were forked rather than implementing a required provider.

Per your guys’ feedback and some internal discussion, we’re going to rethink how/when we use awsutils provider in regular child modules and consider restricting our usage of it to our terraform root modules (https://github.com/cloudposse/terraform-aws-components)

@Jeremy G (Cloud Posse) will be deprecating the usage of this provider in terraform-aws-iam-system-user

Thanks for the update @Erik Osterman (Cloud Posse)

The original use-case for this rotation is lessened by the fact that platforms like GitHub Actions and CircleCI support OIDC authentication with AWS for short-lived credentials. Supporting this feature at the expense of all the confusion it has caused is not worth it.

Love the explanation and update! Thank you

@Alex Jurkiewicz @Erik Osterman (Cloud Posse) terraform-aws-iam-system-user v1.0.0 has been released, which removes the feature of expiring AWS IAM access keys so it can then remove the dependency on the cloudposse/awsutils Terraform provider. Also bug fixes and enahancements.

terraform-aws-iam-s3-user v1.0.0 has been released, upgrading to use iam-system-user v1.0.0 and related bug fixes and enhancements.

terraform-aws-s3-bucket v3.0.0 is ready to be reviewed. Besides dropping the cloudposse/awsutils requirement, is also implements the previously broken features for configuring the S3 bucket to act as a static website, and implements a feature request from Feb 2019: saving the AWS IAM key in SSM.

what a pile of work! Nice one mate

I wish you could publish pre-release versions to TF registries. It would make downstream user testing so much simpler

You can test by using a GitHub ref

  source = "github.com/cloudposse/terraform-aws-s3-bucket?ref=remove-awsutils"

You also can publish pre-release versions to the TF registry. We did it for terraform-aws-security-group so we can get experience with the new defaults.

@Alex Jurkiewicz

oh cool! I didn’t realise the registry supported non- x.y.z version formats. Thanks for the tip

terraform-aws-s3-bucket version 3.0.0 has been released.

Use a different provider? Use a different module? That does the right thing. The only guarantee us change the name of the TF resource

Right, this new Terraform 1.2 feature is what you want. You may need to use it in conjunction with a null_resource, if you want to replace when a variable changes value

yep - that’s what I ended up doing

I know cloudcraft

but I can’t use it due to sec restrictions

https://blog.cycloid.io/inframap-launch ?

https://github.com/cycloidio/inframap

does someone know if it support multiple tfstate?

I create a secret manager secret with a value of initial, the rotate it before first use. Depending on your confidence this can be done with a lambda and done periodically over time.

You can create secret Manager secrets and have AWS automatically generate the value and auto rotate it

Just be aware that what you use in the db_instance resource will be present in your terraform state. I highly recommend rotating before first use outside of terraform.

thanks sounds great. rotation won’t cause drift?

Hmm thats the way we used to do sg rule keys as well. We have since changed this model in the sg module to override the key of each sg rule just like we could for each cloudflare zone record.

https://github.com/cloudposse/terraform-aws-security-group/blob/a7ff89ba6103964d830b683b3c01985c70257307/normalize.tf#L62

cc: @Jeremy G (Cloud Posse) since you made the changes to the sg module, instead of generating the keys from the inputs and then md5ing them, do you think overriding the resource key in the cloudflare module is beter?

I’m ready to help with the module but would like to know what solution I should use here

seems firewall uses md5 approach https://github.com/cloudposse/terraform-cloudflare-zone/blob/master/firewall.tf#L4-L7

Right, the md5 approach and concatenating the inputs i believe are deprecated since in both cases if not all inputs are used to define the keys, then we have conflicting keys. I believe that may have been the reason to opt to override the key. I defer to Jeremy on that. He may also have some guidance here on the best way to move forward on the module

Great, thanks. Can I ask one more question? https://github.com/cloudposse/terraform-cloudflare-zone/blob/master/variables.tf#L95 here we have list(any) . In case of I don’t set products at all it fails because it has to be list of strings in resource argument. The same behaviour for null value. Of course I can’t set it [] because this is a list and all values should be the same type. Should we rework it to list(object{(... or this is a bug of cloudflare provider?

See the sg module. We would most likely follow the same approach and i believe that sg module has a similar interface to what you desire in the cloudflare module

Thanks!

@Mikhail Naletov Because we use the keys in local.records in for_each here, the keys must be completely known at terraform plan time. So we have to be careful about what inputs we use in generating keys.

Seems this pattern does not work for records pointing to multiple destinations Presumably the name is under full user control, so why doesn’t this work for multiple destination?

Regarding https://github.com/cloudposse/terraform-cloudflare-zone/blob/master/variables.tf#L95, firewall_rules is list(any) so that you do not have to supply values for optional inputs. Unless action = "bypass" you should be able to set products = null. If that does not work, I would report that as a bug in the Cloudflare provider.

@Jeremy G (Cloud Posse) hi there. Thank you for your answer.
Presumably the name is under full user control, so why doesn’t this work for multiple destination? Example: I want to delegate test.example.com to Google Cloud DNS/AWS Route53. I have to create 4 NS records:

test.example.com NS aws-resolver1.blabla
test.example.com NS aws-resolver2.blabla
test.example.com NS aws-resolver21.blabla
test.example.com NS aws-resolver88.blabla

Using the module I have 4 same resources in for_each loop:

test.example.comNS
test.example.comNS
test.example.comNS
test.example.comNS

Related to Cloudflare provider - I’ve already created an issue. That’s strange but it seems products argument not depends on action but on pause.

OK, if it normal to have records of the same name and type, the obvious options are

1. Switch from for_each to count so that the records do not need unique keys. This means that changes to the inputs may have a ripple effect, but it should not be significant issue to have all the record deleted and immediately recreated.
2. Add a user-defined unique key per record. We tried that with Security Group rules. It does not work terribly well, in that the user has to define keys that are valid at plan time, and often ends up simply creating the same kind of index that is automatically created with count. @Mikhail Naletov I’m in favor of option 1. What do you think?

Regarding Cloudflare, sounds like the solution is for you to provide a valid products value.

The issue with option 1, using count, would mean that if a record was added in the middle of the list, then it would cause a bunch of recreations.

I’d personally be more a fan of option 2 where a key is generated (which is currently the case but not all inputs are used in the key) and the key can be optionally overridden. This would at least prevent recreations of resources if a new record is added in the middle of the inputs

@RB (Ronak) (Cloud Posse) Yes, using count causes unnecessary recreation of resources, but it has fewer failure modes, so it is worth considering the impact of that recreation versions the complete failure that occurs in the current case or cases where the keys cannot be computed at plan time. We also need to consider the likelihood that someone will generate keys with something like

rmap = { for i, v in var.records : i => v }

which has exactly the same problem as using count, but requires extra effort on the part of the user.

What we are talking about deleting and recreating are DNS entries, which probably should have negligible impact.

err… deleting dns entries. I think that would cause a lot of impact, no?

I’d prefer not to use count. I’m agree with @RB (Ronak) (Cloud Posse) here, recreating records may cause serious downtime.

The other option would be to add an optional key to the records objects, and use the key if present (falling back to the current synthetic key if it is absent). I do not want to add value to they synthetic key because there is a good chance the value will not be known at plan time, in which case terraform plan will fail and there would be no way to fix it.

This would be backward compatible, and the key would only need to be specified in cases where either the name or type is not known at plan time or there are duplicates. Of course, this would require users to create keys that can be computed at plan time, which could be a problem. Do you think this will work for you, @Mikhail Naletov?

The current interface

  records = [
    {
      name  = "bastion"
      value = "192.168.1.11"
      type  = "A"
      ttl   = 3600
    },
    {
      name  = "api"
      value = "192.168.2.22"
      type  = "A"
      ttl   = 3600
    }
  ]

how about an interface like this where the keys are provided?

  records = {
    bastion = {
      name  = "bastion"
      value = "192.168.1.11"
      type  = "A"
      ttl   = 3600
    },
    api = {
      name  = "api"
      value = "192.168.2.22"
      type  = "A"
      ttl   = 3600
    }
  }

how about an interface like this where the keys are provided? That would

1. not be backward compatible
2. would make the keys required which is why I prefer my proposal, which would be backward compatible by making the keys optional, and with the keys being optional, would not impose the added burden of creating keys for users who do not need them.

the proposal you’re referring to is the count proposal, no?

No.
The other option would be to add an optional key to the records objects, and use the key if present (falling back to the current synthetic key if it is absent)

ok so to be clear, you’re proposing an interface like this where key is optional

  records = [
    {
      key   = "bastion_A"
      name  = "bastion"
      value = "192.168.1.11"
      type  = "A"
      ttl   = 3600
    },
    {
      key   = "api_A"
      name  = "api"
      value = "192.168.2.22"
      type  = "A"
      ttl   = 3600
    },
    {
      key   = "test.example.com_NS_1"
      name  = "test"
      value = "aws-resolver1.blabla"
      type  = "NS"
      ttl   = 3600
    },
    {
      key   = "test.example.com_NS_2"
      name  = "test"
      value = "aws-resolver2.blabla"
      type  = "NS"
      ttl   = 3600
    },
  ]

Key would be optional, but if present, must be present for all the records in the list. That is a Terraform requirement.

I created this ticket for now https://github.com/cloudposse/terraform-cloudflare-zone/issues/15

It looks like you have an exsting task def 29, presumably created by ECS deployments, whereas the TF state has 8. You can avoid TF seeing this as a change by setting the ignore_changes_task_definition var to true.

how do you usually manage changes to the task definition (env vars, cpu resources, etc.)?

It’s still managed by terraform but you will need to update your service to use the latest task def in another way

thanks, appreciate your help

No problem. I usually use CD tools such as GitHub Actions or CodeDeploy to update it. Or ecs-deploy for manual cli usage.

CodeDeploy in particular can be a pain when you update the task def in Terraform but CodeDeploy uses the last version it knew about to create a new task definition, effectively skipping the one that TF created.

does this get you what you want? internal_ranges_map[*].CIDR?

it does, thank you.

taking your advice above leads me onto my next question:

i have this:

ingress_db = concat(local.vpc_cidrs, var.internal_ranges_map[*].CIDR)

i want to reference those descriptions from the map in the below

resource "aws_security_group_rule" "rds" {
  for_each          = var.ingress_db
  from_port         = var.config["port"]
  protocol          = "tcp"
  security_group_id = aws_security_group.rds.id
  to_port           = var.config["port"]
  type              = "ingress"
  cidr_blocks       = [each.key]
  description = ""
}

but i’m struggling with how to get the description from the map

ahh well. in that case, you don’t. instead, you build up a list of objects with all the attributes you want. and then you use that in your for_each expression…

the easiest way is to change your local.vpc_cidrs to match the structure of var.internal_ranges_map… e.g.

locals {
  vpc_cidrs = [
    {
      CIDR = "..."
      description = "..."
    }
  ]
}

and then you can just do:

rules = { for item in concat(local.vpc_cidrs, var.internal_ranges_map) : item.CIDR => item }

and:

resource "aws_security_group_rule" "rds" {
  for_each          = local.rules
  from_port         = var.config["port"]
  protocol          = "tcp"
  security_group_id = aws_security_group.rds.id
  to_port           = var.config["port"]
  type              = "ingress"
  cidr_blocks       = [each.key]
  description = each.value.description
}

thanks for your reply @loren

is each.key correct?

for the cidr ?

here are my locals

  locals { 
vpc_cidrs = [
    {
      "CIDR"        = data.terraform_remote_state.vpc.outputs.vpc_cidr_block
      "description" = "Primary Self VPC",
    },
    {
      "CIDR"        = data.terraform_remote_state.vpc.outputs.secondary_cidr_block
      "description" = "Secondary Self VPC",
    }
  ]

  ingress_db = { for item in concat(local.vpc_cidrs, var.internal_ranges_map) : item.CIDR => item }
}

here is where i use the ingress_db

module "rds" {
  source      = "../modules/rds"
  config      = merge(local.rds, var.rds)
  environment = var.environment
  ingress_db  = local.ingress_db
  subnet_ids  = data.terraform_remote_state.vpc.outputs.private_subnets
  vpc_id      = data.terraform_remote_state.vpc.outputs.vpc_id
}

and here is the sg rule inside the module

resource "aws_security_group_rule" "rds" {
  for_each          = var.ingress_db
  from_port         = var.config["port"]
  protocol          = "tcp"
  security_group_id = aws_security_group.rds.id
  to_port           = var.config["port"]
  type              = "ingress"
  cidr_blocks       = [each.key]
  description = each.value.description
}

in this expression:

{ for item in concat(local.vpc_cidrs, var.internal_ranges_map) : item.CIDR => item }

when used as a for_each value, when you reference each.key you are getting the value of item.CIDR. (the value of the expression between the : and the => becomes the value of the map key)

what your error means, is that somewhere in your object, you have a CIDR that has a value of ""

hmmm

do maps have a ‘compact’ feature to remove potential empty values?

hmmm, well you can test for it in the for expression…

{ for item in concat(local.vpc_cidrs, var.internal_ranges_map) : item.CIDR => item if item.CIDR != "" }

@loren thanks, i’ll check this.

hi @loren the above worked great.

here’s my code:

  vpc_cidrs = [
    {
      "CIDR"        = data.terraform_remote_state.vpc.outputs.vpc_cidr_block
      "description" = "Primary Self VPC"
    },
    {
      "CIDR"        = data.terraform_remote_state.vpc.outputs.secondary_cidr_block
      "description" = "Secondary Self VPC"
    }
  ]

  ingress_db = {
  for item in concat(local.vpc_cidrs, var.ingress_db, var.internal_ranges_map) : item.CIDR => item if item.CIDR != ""
  }

where local.vpc_cidrs , var.ingress_db and var.internal_ranges_map are the same format.

sometimes these variables may have duplicate CIDRs which ends up resulting in this issue.

Error: Duplicate object key
│ 
│   on main.tf line 41, in locals:
│   40:   ingress_db = {
│   41:   for item in concat(local.vpc_cidrs, var.ingress_db, var.internal_ranges_map) : item.CIDR => item if item.CIDR != ""
│   42:   }
│     ├────────────────
│     │ item.CIDR is "10.1.xx.xx/32"

do you know of a way to remove duplicates after the concat ?

no, that means it is not an appropriate value for the key in the for_each expression, and you have to devise a new expression for the key

i’ll often have a “name” attribute in the data structure. and that attribute value, i require to be unique. that makes it appropriate for use as the for_each key

e.g.

  vpc_cidrs = [
    {
      name          = "primary"
      "CIDR"        = data.terraform_remote_state.vpc.outputs.vpc_cidr_block
      "description" = "Primary Self VPC"
    },
    {
      name          = "secondary"
      "CIDR"        = data.terraform_remote_state.vpc.outputs.secondary_cidr_block
      "description" = "Secondary Self VPC"
    }
  ]

and then

  ingress_db = {
  for item in concat(local.vpc_cidrs, var.ingress_db, var.internal_ranges_map) : item.name => item if item.CIDR != ""
  }

@loren when you say you require it to be unique, is that enforced somehow?

well, as you saw, when the key expression for for_each must be unique and plan will error if it is not…

so, that’s my enforcement. as far as how i create or manage the unique values, they’re typically a user input or hardcoded in a local value

we’re kinda starting to divert into some more general theory and practice on how to manage and structure data/config… i am somewhat particular about these things, particularly in light of how for_each works, and i go out of my way when writing modules to manage inputs in a way that i can be reasonably sure will work from a cold start (empty state). it’s not necessarily for everyone though, requires a fair bit from the user, rather than being an easy button

this is a very good section on for_each. well worth reading and re-reading. i often learn something new when re-reading the docs, after playing around a little bit… https://www.terraform.io/language/meta-arguments/for_each#limitations-on-values-used-in-for_each

check whether i have any prs open by dependabot/renovate?

@loren where?

you mean where are my pull requests? wherever the repo is hosted, typically github, or gitlab, or codecommit

Is there something specific you are trying to do?

I think Oliver isn’t aware of dependabot. If that’s the case, Oliver you can read about it here. Basically github actions are being run as you configure them and it can be set to create a PR that has the newer versions in it. It’s on you to fix any breaking changes as part of the newer versions, of course. But it will give you the insights of what’s behind the latest version, and encourages a better operational discipline.

I’ll rephrase my original question: given a root module, is there a way to get a list of third-party modules used, with the current version installed by terraform init, and the latest available version in registry?

Eg if my tf module is using cloudposse lambda module v1.0, and v1.1 is available, such command should show (something like) cloudposse/lambda current = v1.0 available = v1.1

I just saw @Denis answer about dependabot let me check this out

Yup, you should read through it, and terraform is supported. So it should fit your need. It’s a great tool.

Can I ask why, do you need to do this?

Just need to update dependencies, and it’s not something I want to automate, too risky atm. So I’m looking for a command to show me the list of modules that could be upgraded.

“too risky, always”

i like both dependabot and renovate, and only automate the creation of the pr. we don’t merge the pr until we’ve tested it separately

RIght. So the idea is that if dependabot is run regularly to check say daily, the module version updates will be minimal and frequent… and only accepted if manual verifications on the PR branch succeed…

We are using Renovate. And yes for us it just creates PRs/MRs which we double check and merge manually

honestly i’ve found too frequent checks to be more annoying than anything. most updates are minor things that impact no feature i’m using. i am usually proactively aware if something i am doing requires an updated module, so i just update it myself. as far as just staying current, i don’t need prs to update modules any more often than once a month

genius advice

Dependabot seems to require github? which my client is not using (they use bitbucket)

(still checking if that conclusion is correct)

my deepest condolences

pays the bills

Yikes

the dependabot service does require github. but you can run the dependabot container yourself, against several other hosts

and bitbucket is one of the other hosts… https://github.com/dependabot/dependabot-core/blob/main/common/lib/dependabot/clients/bitbucket.rb

yeah just saw a mention of dependabot core…

here’s a starting point for running dependabot yourself… https://github.com/dependabot/dependabot-script

Thanks I’ll check it out…

https://github.com/keilerkonzept/terraform-module-versions This one works from me in a project where I have not yet configured renovate.

Thanks @Tyrone Meijn, based on the docs it might be exactly what I was looking for, I’ll definitely try it out

I have to wait for https://github.com/keilerkonzept/terraform-module-versions/issues/89 to get fixed

Very cool you folks are setting this up yourselves

We probably just haven’t upstreamed the cluster-autoscaler component yet

The eks-iam component has been deprecated since the iam roles are now created within each specific helm chart component

One thing to be mindful of is the number of months it’s been since a component has been updated

Thank you. I should have read the code closer but that makes sense now that you mention it. We’ll start with those other 2 helm components and see how it goes.

you do not need to destroy the service

you need to make sure the task is using the available ram from the ec2 instance

which is NOT the total amount of ram of the instance type

you need to leave room for the ecs agent etc so if you tune the ram of each task plus task count, TF will stop the task and then start it again

The joy of inheriting code.. The project had a few issues, the main reasons it wouldn’t deploy the new service was because the desired amount of running containers was set to 1, the CPU request was 4vCPUs for all 3 containers so no room to spin up the new version parallel to the old one.

Thanks for the input

np

What do you mean by “different types” ? you can use those together, but I’m not sure to understand the “different types” part .

My bad I meant something like this

statement {
            or_statement {
                statement {
                    ip_set_reference_statement {
                        arn = 
                        }
                    }
                statement {
                    byte_match_statement {
                     }
                }
            }

oh alright, I think that in your case, the “and_statement” should encapsulate the statement {not_statement{}}.

oh , your message has been edited

yeah, made it smaller and something what I want to achieve

It should work like this

I don’t believe it’s possible with the cloudposse module. The WAF resources are hard to build a module around, it can be easier to use the resources directly for exactly this reason

Han, I was not aware if it was with or without the module ^^, I don’t use the cloudposse module for our WAF, so I don’t know .

The problem is clear in the error message. External data output is not a plain string. It’s a JSON map

It doesn’t seem possible but i could be mistaken

It’s gross but this may be a workaround but there may be a better way

module "label" {
  source  = "cloudposse/label/null"
 
  name        = "waf"
  attributes  = ["regional"]
}
 
module "label_cloudfront" {
  source  = "cloudposse/label/null"

  name       = "waf"
  attributes = ["cloudfront"]
}

@Andriy Knysh (Cloud Posse) @Jeremy G (Cloud Posse) thoughts?

I’ve seen the same behavior and I came to the conclusion that when passing the context from one label it isn’t possible to reset the values and they’re additive. Someone from Cloud Posse may know a way but I haven’t found one myself.

I think only the attributes are additive whereas the other arguments can be overridden

@rb possibly correct, I think attributes is the most common one so most obvious. If I need multiple labels with different base attributes I just set them up in the root module then pass the respective context . It gets messy/ugly but it works. To obtain the naming schema being requested by manager I’ve had to then tweak the label_order and label_as_tags.

@Alex Jurkiewicz I would suggest just making another “regional” label and remove the attributes from the existing module.label

By design, attributes and tags are additive, but the explicitly named labels can be overridden.

In the next version of null-label, the labels will be upgraded to a map so you can use any key/name, not just the pre-defined ones we have now. Until then, you might prefer to use environment = "regional" and environment = "cloudfront" instead, or create a base label to inherit from:

module "label_base" {
  source = "cloudposse/label/null"
  name   = "waf"
}

module "label" {
  source      = "cloudposse/label/null"
  context     = module.label_base.context
  attributes  = ["regional"]
}

module "label_cloudfront" {
  source     = "cloudposse/label/null"
  context    = module.label_base.context
  attributes = ["cloudfront"]
}

you asked a very similar question yesterday. The CloudPosse module doesn’t support what you want to do

https://sweetops.slack.com/archives/CB6GHNLG0/p1661548027374669?thread_ts=1661513869.962159&cid=CB6GHNLG0

my last question was different, it was about having and_statement. Today I am aksing about https://github.com/cloudposse/terraform-aws-waf/blob/master/rules.tf#L172-L178 which is mentioned in the module and giving error

can you use a tag policy in aws organizations?

or terratag? https://www.env0.com/blog/were-opensourcing-terratag-to-make-multicloud-resource-tagging-easier

or if you go the brute force approach, there is git-xargs by the gruntwork team… https://github.com/gruntwork-io/git-xargs

in the end, for enforcement, i’d strongly consider a CI test that fails a pull request if the tag standard is not met

How many configurations are you talking? It’s not a very sexy answer but if the answer is under 100, it will take you less than an hour to update them all by hand

I recently did a few hundred by hand. It’s not something you’ll do frequently enough to bother investing in automation. Elbow grease

@loren Tbh I don’t know the answer to any of those questions, but I sure do appreciate the input and I’m looking into all three now, actually, thanks.

@Alex Jurkiewicz I appreciate the pragmatism of your input, thank you, and that may be a viable approach, as yes it’s probably less than 100 repos. Maybe. It could be 200, I’m not totally sure. I think the bigger concern is what we do after which would be using something like rapid7’s CloudInsightSec tool to then crawl across our AWS accounts and enforce compliance on AWS resources.

Do you have a centralised deployment system for your Terraform? That’s where to introduce compliance gates

@Alex Jurkiewicz Yep – Terraform Cloud (and CircleCI does a lot as well).

@loren question, do you know how terratag compares to using default_tags in the aws provider?

not really. they feel like very different mechanisms. default_tags currently has a number of issues that make it appropriate for only a very limited use case.

default_tags, as currently implemented, are only “default” at the provider level. at the resource level, they’re effectively “mandatory” tags and tag-values. if you try to override a tag-key with a different value at the resource level, you’ll either get an error or a persistent diff. very annoying

default_tags seems like a both specific and painfully limited use case.

fwiw it’s worth it turns out that AWS Organizations, combined with AWS Resource Groups, actually has evolved to offer a fair amount of functionality today. For anyone considering broad tag-based controls it’s definitely at least worth reading up on.

@Jonas Steinberg if you have any questions about Terratag let us know (Disclaimer - I am the co-founder and CTO of env0 who owns and maintain Terratag). We have quite a lot of customers using it to create a standard in terms of tagging resources.

#office-hours

@Jonas Steinberg we discussed this yesterday on office hours. Make sure to check out the recording.

https://www.youtube.com/watch?v=rOs1had-oO4

@Erik Osterman (Cloud Posse) very nice as usual

You can check the underlying terraform resources for msk serverless, then see if the required resources/attributes are set in the module’s code

@Jeremy G (Cloud Posse) @Andriy Knysh (Cloud Posse)

My apologies. This was held up for what was supposed to be a short time due to expected changes on the roadmap, and when the roadmap priorities were changed, I failed to release the hold. It has now been updated and released as v0.28.2. (An update using s3-bucket 2.0.0 was accidentally released as v0.28.1.)

Thank you for taking a second look and prompt executing!

Thank you for bringing this delay to our attention.