#pr-reviews (2022-03)

Ty for the contribution but we do not pin modules to major versions.

@RB I updated the PR to instead lock to less-than-4 because the module breaks when used with AWS Provider v4. Sorry that I didn’t include more context in the original. PR

https://github.com/cloudposse/terraform-aws-ecs-web-app/pull/186

Once aws-ecs-codepipeline is merged, I will also be asking for aws-ecs-web-app to be updated to point to that new version

@kevcube, we make it a point to not pin major aws versions

the way forward would be to move the s3 bucket in the ecs code pipeline to use the s3 bucket module

https://github.com/cloudposse/terraform-aws-ecs-codepipeline/blob/882d7e0ea01e932bdc70ada8c953ec5bc7df361f/main.tf#L9

then we can update the pin for ecs web module to >= 4.0

Ok I understand now. Unfortunately this process will introduce breaking changes for users of this module, which makes me worry that these PRs will move along much slower. I wish that in the meantime we could lock things to provider version less-than-4

Updated the PR. It had a misplace comma.

thought we had one for this

@jose.amengual

cc: @Jeremy G (Cloud Posse) i approved this. tests passed and the versions for terraform match s3 bucket module except s3 bucket module pins aws provider to 4.2.x and this repo pr pins to 4.x which is minor

should be safe to merge unless we also want to include migration docs?

thx guys

@RB @Bart Coddens We need migration docs. You can reference the S3 bucket migration doc (do not need to completely duplicated it), but you need to explain how it applies to this module.

I added something minimal to the release notes, but since I don’t know what the experience is of upgrading, I cannot tell if it is sufficient or not.