#pr-reviews (2021-11)

Pull Request Reviews for Cloud Posse Projects

2021-11-23

Frank avatar
Frank

Got another tiny one (only 1 line changed): https://github.com/cloudposse/terraform-aws-rds-cluster/pull/126

fix: prevent creating empty replicas record by syphernl · Pull Request #126 · cloudposse/terraform-aws-rds-cluster

what Prevent creating empty DNS replicas record when cluster_size < 1 why If the cluster_size = 0 this would result in an attempt to create an empty DNS record, which is not permitted by the …

1
1
Max Lobur (Cloud Posse) avatar
Max Lobur (Cloud Posse)

@RB (Ronak) (Cloud Posse) how do you usually handle those bridgecrew warnings? they are unrelated. Separate ticket?

fix: prevent creating empty replicas record by syphernl · Pull Request #126 · cloudposse/terraform-aws-rds-cluster

what Prevent creating empty DNS replicas record when cluster_size < 1 why If the cluster_size = 0 this would result in an attempt to create an empty DNS record, which is not permitted by the …

Max Lobur (Cloud Posse) avatar
Max Lobur (Cloud Posse)
Reiterate on BridgeCrew warnings · Issue #127 · cloudposse/terraform-aws-rds-cluster attachment image

Describe the Bug A bunch of unrelated warnings appeared in a PR: #126 I think BridgeCrew has updated their database Expected Behavior Keep master clean so that people don&#39;t get confused when th…

2021-11-22

Frank avatar
Frank

Can someone please take a look at this (small) PR? https://github.com/cloudposse/terraform-aws-ses/pull/58

feat: add `iam_access_key_max_age` variable by syphernl · Pull Request #58 · cloudposse/terraform-aws-ses attachment image

what Added iam_access_key_max_age to configure when the IAM credentials are to be rotated. why Since v0.21.0 the IAM user created by this module expires by-default without being able to override…

1
1
1
RB (Ronak) (Cloud Posse) avatar
RB (Ronak) (Cloud Posse)
Disable provider role assumption if enabled is false by nitrocode · Pull Request #56 · cloudposse/terraform-aws-vpc-peering-multi-account attachment image

what Disable provider role assumption if enabled is false why Allow enabled = false references N/A

1
1
RB (Ronak) (Cloud Posse) avatar
RB (Ronak) (Cloud Posse)
1
RB (Ronak) (Cloud Posse) avatar
RB (Ronak) (Cloud Posse)

looks like i need an admin approval here too cc: @Andriy Knysh (Cloud Posse) @Erik Osterman (Cloud Posse)

2021-11-19

RB (Ronak) (Cloud Posse) avatar
RB (Ronak) (Cloud Posse)
RB (Ronak) (Cloud Posse) avatar
RB (Ronak) (Cloud Posse)

terratest fails normally, last pr merged also failed terratest

https://github.com/cloudposse/terraform-opsgenie-incident-management/pull/22

Change for_each to avoid nested maps typing_error by nate-selzer · Pull Request #22 · cloudposse/terraform-opsgenie-incident-management attachment image

what Fix conditional operator why Prevent terraform errors like Error: Inconsistent conditional result types on .terraform/modules/opsgenie_config/modules/config/integration_actions.tf line …

RB (Ronak) (Cloud Posse) avatar
RB (Ronak) (Cloud Posse)
Disable policy if no principals by nitrocode · Pull Request #44 · cloudposse/terraform-aws-sns-topic attachment image

what Disable policy if no principals why Prevent a malformed policy references https://github.com/cloudposse/actions/runs/4267827651?check_suite_focus=true Fixes cloudposse/terraform-aws-code-…

1
1

2021-11-18

RB (Ronak) (Cloud Posse) avatar
RB (Ronak) (Cloud Posse)
Allow slash in log group names by nitrocode · Pull Request #26 · cloudposse/terraform-aws-cloudwatch-logs attachment image

what Custom label for cloudwatch log group name why Allow slash in log group names references https://sweetops.slack.com/archives/CB6GHNLG0/p1636985722167300 test provider &quot;aws&quot; { …

1
1
RB (Ronak) (Cloud Posse) avatar
RB (Ronak) (Cloud Posse)
Additional inputs by nitrocode · Pull Request #124 · cloudposse/terraform-aws-rds-cluster attachment image

what Add performance_insights_retention_period Add ca_cert_identifier Add preferred_maintenance_window to instances Add timeout to instances why Performance insights retention Add a ca cert iden…

1
1
1

2021-11-12

nnsense avatar
nnsense

S3 bucket versioning fix (thanks @Andriy Knysh (Cloud Posse) ) https://github.com/cloudposse/terraform-aws-s3-bucket/pull/118

Dynamic block for versioning added by nnsense · Pull Request #118 · cloudposse/terraform-aws-s3-bucket attachment image

what Enabling versioning on a bucket is a permanent action that cannot be disabled. For this reason, when versioning attribute is added to the s3 resource, the bucket is prepared to be versioned an…

1

2021-11-10

mihai avatar
mihai
Add response headers policy input for CloudFront distributions default behaviour by itschrishudson · Pull Request #195 · cloudposse/terraform-aws-cloudfront-s3-cdn attachment image

what Adds an input to pass a response headers policy ID into the CloudFront distribution in the default cache behaviour. why AWS have recently released the ability to generate response header po…

1
mihai avatar
mihai
Add response headers policy input for CloudFront distributions default behaviour by itschrishudson · Pull Request #76 · cloudposse/terraform-aws-cloudfront-cdn attachment image

what Adds an input to pass a response headers policy ID into the CloudFront distribution in the default cache behaviour. why AWS have recently released the ability to generate response header po…

1

2021-11-09

2021-11-08

Kevin Mahoney avatar
Kevin Mahoney
IAM role fails to create without SNS topic by kevcube · Pull Request #40 · cloudposse/terraform-aws-config attachment image

what The IAM role for putting objects into S3 can only be created if create_sns_topic is true, because the data object on line 144 depends on it, and the IAM role currently needs this data object …

1
1
Matt Gowie avatar
Matt Gowie

Merged — Thanks @

IAM role fails to create without SNS topic by kevcube · Pull Request #40 · cloudposse/terraform-aws-config attachment image

what The IAM role for putting objects into S3 can only be created if create_sns_topic is true, because the data object on line 144 depends on it, and the IAM role currently needs this data object …

Kevin Mahoney avatar
Kevin Mahoney

Thanks Matt!

2021-11-02

Kevin Mahoney avatar
Kevin Mahoney
enable sns topic encryption by kevcube · Pull Request #39 · cloudposse/terraform-aws-config attachment image

what can now enable encryption on the sns topic why we’re encrypting everything

    keyboard_arrow_up