#pr-reviews (2021-11)
Pull Request Reviews for Cloud Posse Projects
2021-11-02
![kevcube avatar](https://avatars.slack-edge.com/2022-02-16/3117652675890_e629b00375cf1d67c74d_72.jpg)
https://github.com/cloudposse/terraform-aws-config/pull/39 quick encryption on SNS topic PR
what can now enable encryption on the sns topic why we’re encrypting everything
2021-11-08
![kevcube avatar](https://avatars.slack-edge.com/2022-02-16/3117652675890_e629b00375cf1d67c74d_72.jpg)
^ Different PR, same repo
what The IAM role for putting objects into S3 can only be created if create_sns_topic is true, because the data object on line 144 depends on it, and the IAM role currently needs this data object …
![Matt Gowie avatar](https://avatars.slack-edge.com/2023-02-06/4762019351860_44dadfaff89f62cba646_72.jpg)
Merged — Thanks @kevcube
what The IAM role for putting objects into S3 can only be created if create_sns_topic is true, because the data object on line 144 depends on it, and the IAM role currently needs this data object …
![kevcube avatar](https://avatars.slack-edge.com/2022-02-16/3117652675890_e629b00375cf1d67c74d_72.jpg)
Thanks Matt!
2021-11-09
2021-11-10
![mihai.plesa avatar](https://secure.gravatar.com/avatar/663277330091d41f09410afd2b1606e1.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
what Adds an input to pass a response headers policy ID into the CloudFront distribution in the default cache behaviour. why AWS have recently released the ability to generate response header po…
![mihai.plesa avatar](https://secure.gravatar.com/avatar/663277330091d41f09410afd2b1606e1.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
same as above but different module https://github.com/cloudposse/terraform-aws-cloudfront-cdn/pull/76
what Adds an input to pass a response headers policy ID into the CloudFront distribution in the default cache behaviour. why AWS have recently released the ability to generate response header po…
2021-11-12
![nnsense avatar](https://avatars.slack-edge.com/2021-11-13/2724381855556_9b369968ac638fae65f2_72.png)
S3 bucket versioning fix (thanks @Andriy Knysh (Cloud Posse) ) https://github.com/cloudposse/terraform-aws-s3-bucket/pull/118
what Enabling versioning on a bucket is a permanent action that cannot be disabled. For this reason, when versioning attribute is added to the s3 resource, the bucket is prepared to be versioned an…
2021-11-18
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
tiny pr ready for review https://github.com/cloudposse/terraform-aws-cloudwatch-logs/pull/26/files
what Custom label for cloudwatch log group name why Allow slash in log group names references https://sweetops.slack.com/archives/CB6GHNLG0/p1636985722167300 test provider "aws" { …
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
can i get a review here plz https://github.com/cloudposse/terraform-aws-rds-cluster/pull/124
what Add performance_insights_retention_period Add ca_cert_identifier Add preferred_maintenance_window to instances Add timeout to instances why Performance insights retention Add a ca cert iden…
2021-11-19
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
please review https://github.com/cloudposse/terraform-opsgenie-incident-management/pull/24#pullrequestreview-811797288 (need admin to review)
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
terratest fails normally, last pr merged also failed terratest
https://github.com/cloudposse/terraform-opsgenie-incident-management/pull/22
what Fix conditional operator why Prevent terraform errors like Error: Inconsistent conditional result types on .terraform/modules/opsgenie_config/modules/config/integration_actions.tf line …
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
tiny pr https://github.com/cloudposse/terraform-aws-sns-topic/pull/44 (tests pass)
what Disable policy if no principals why Prevent a malformed policy references https://github.com/cloudposse/actions/runs/4267827651?check_suite_focus=true Fixes cloudposse/terraform-aws-code-…
2021-11-22
![Frank avatar](https://secure.gravatar.com/avatar/1b4b7744d083431522fb3e1b49206492.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
Can someone please take a look at this (small) PR? https://github.com/cloudposse/terraform-aws-ses/pull/58
what Added iam_access_key_max_age to configure when the IAM credentials are to be rotated. why Since v0.21.0 the IAM user created by this module expires by-default without being able to override…
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
tiny pr https://github.com/cloudposse/terraform-aws-vpc-peering-multi-account/pull/56 (enabled = false)
what Disable provider role assumption if enabled is false why Allow enabled = false references N/A
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
tiny pr https://github.com/cloudposse/terraform-aws-rds-db-proxy/pull/4 (make github/init)
what make github/init why latest context references N/A
![RB avatar](https://avatars.slack-edge.com/2020-02-26/958727689603_86844033e59114029b3c_72.png)
looks like i need an admin approval here too cc: @Andriy Knysh (Cloud Posse) @Erik Osterman (Cloud Posse)
what make github/init why latest context references N/A
2021-11-23
![Frank avatar](https://secure.gravatar.com/avatar/1b4b7744d083431522fb3e1b49206492.jpg?s=72&d=https%3A%2F%2Fa.slack-edge.com%2Fdf10d%2Fimg%2Favatars%2Fava_0003-72.png)
Got another tiny one (only 1 line changed): https://github.com/cloudposse/terraform-aws-rds-cluster/pull/126
what Prevent creating empty DNS replicas record when cluster_size < 1 why If the cluster_size = 0 this would result in an attempt to create an empty DNS record, which is not permitted by the …
![Max Lobur (Cloud Posse) avatar](https://avatars.slack-edge.com/2021-07-20/2316891735296_3098d8d2760936592f52_72.jpg)
@RB how do you usually handle those bridgecrew warnings? they are unrelated. Separate ticket?
what Prevent creating empty DNS replicas record when cluster_size < 1 why If the cluster_size = 0 this would result in an attempt to create an empty DNS record, which is not permitted by the …
![Max Lobur (Cloud Posse) avatar](https://avatars.slack-edge.com/2021-07-20/2316891735296_3098d8d2760936592f52_72.jpg)
Created https://github.com/cloudposse/terraform-aws-rds-cluster/issues/127 and merged the PR
Describe the Bug A bunch of unrelated warnings appeared in a PR: #126 I think BridgeCrew has updated their database Expected Behavior Keep master clean so that people don't get confused when th…